Use type-declaration on api module constructor

Parent class constructor gets type-declaration in 1145328459
Remove simple doc-blocks without further information

Change-Id: I5d2179af0c7b826ca48df239152412205702cd77
This commit is contained in:
Umherirrender 2024-10-25 19:02:04 +02:00
parent 43f8580bdf
commit 6757ee9d32
7 changed files with 24 additions and 98 deletions

View file

@ -32,17 +32,11 @@ use Wikimedia\ParamValidator\ParamValidator;
*/
class AbuseLogPrivateDetails extends ApiBase {
/** @var AbuseFilterPermissionManager */
private $afPermManager;
private AbuseFilterPermissionManager $afPermManager;
/**
* @param ApiMain $main
* @param string $action
* @param AbuseFilterPermissionManager $afPermManager
*/
public function __construct(
ApiMain $main,
$action,
string $action,
AbuseFilterPermissionManager $afPermManager
) {
parent::__construct( $main, $action );

View file

@ -22,29 +22,14 @@ use Wikimedia\ParamValidator\ParamValidator;
class CheckMatch extends ApiBase {
/** @var RuleCheckerFactory */
private $ruleCheckerFactory;
private RuleCheckerFactory $ruleCheckerFactory;
private AbuseFilterPermissionManager $afPermManager;
private VariablesBlobStore $afVariablesBlobStore;
private VariableGeneratorFactory $afVariableGeneratorFactory;
/** @var AbuseFilterPermissionManager */
private $afPermManager;
/** @var VariablesBlobStore */
private $afVariablesBlobStore;
/** @var VariableGeneratorFactory */
private $afVariableGeneratorFactory;
/**
* @param ApiMain $main
* @param string $action
* @param RuleCheckerFactory $ruleCheckerFactory
* @param AbuseFilterPermissionManager $afPermManager
* @param VariablesBlobStore $afVariablesBlobStore
* @param VariableGeneratorFactory $afVariableGeneratorFactory
*/
public function __construct(
ApiMain $main,
$action,
string $action,
RuleCheckerFactory $ruleCheckerFactory,
AbuseFilterPermissionManager $afPermManager,
VariablesBlobStore $afVariablesBlobStore,

View file

@ -11,21 +11,12 @@ use Wikimedia\ParamValidator\ParamValidator;
class CheckSyntax extends ApiBase {
/** @var RuleCheckerFactory */
private $ruleCheckerFactory;
private RuleCheckerFactory $ruleCheckerFactory;
private AbuseFilterPermissionManager $afPermManager;
/** @var AbuseFilterPermissionManager */
private $afPermManager;
/**
* @param ApiMain $main
* @param string $action
* @param RuleCheckerFactory $ruleCheckerFactory
* @param AbuseFilterPermissionManager $afPermManager
*/
public function __construct(
ApiMain $main,
$action,
string $action,
RuleCheckerFactory $ruleCheckerFactory,
AbuseFilterPermissionManager $afPermManager
) {

View file

@ -14,25 +14,13 @@ use Wikimedia\ParamValidator\ParamValidator;
class EvalExpression extends ApiBase {
/** @var RuleCheckerFactory */
private $ruleCheckerFactory;
private RuleCheckerFactory $ruleCheckerFactory;
private AbuseFilterPermissionManager $afPermManager;
private VariableGeneratorFactory $afVariableGeneratorFactory;
/** @var AbuseFilterPermissionManager */
private $afPermManager;
/** @var VariableGeneratorFactory */
private $afVariableGeneratorFactory;
/**
* @param ApiMain $main
* @param string $action
* @param RuleCheckerFactory $ruleCheckerFactory
* @param AbuseFilterPermissionManager $afPermManager
* @param VariableGeneratorFactory $afVariableGeneratorFactory
*/
public function __construct(
ApiMain $main,
$action,
string $action,
RuleCheckerFactory $ruleCheckerFactory,
AbuseFilterPermissionManager $afPermManager,
VariableGeneratorFactory $afVariableGeneratorFactory

View file

@ -39,17 +39,11 @@ use Wikimedia\ParamValidator\TypeDef\IntegerDef;
*/
class QueryAbuseFilters extends ApiQueryBase {
/** @var AbuseFilterPermissionManager */
private $afPermManager;
private AbuseFilterPermissionManager $afPermManager;
/**
* @param ApiQuery $query
* @param string $moduleName
* @param AbuseFilterPermissionManager $afPermManager
*/
public function __construct(
ApiQuery $query,
$moduleName,
string $moduleName,
AbuseFilterPermissionManager $afPermManager
) {
parent::__construct( $query, $moduleName, 'abf' );

View file

@ -50,36 +50,16 @@ use Wikimedia\ParamValidator\TypeDef\IntegerDef;
*/
class QueryAbuseLog extends ApiQueryBase {
/** @var FilterLookup */
private $afFilterLookup;
/** @var AbuseFilterPermissionManager */
private $afPermManager;
/** @var VariablesBlobStore */
private $afVariablesBlobStore;
/** @var VariablesManager */
private $afVariablesManager;
/** @var UserFactory */
private $userFactory;
private FilterLookup $afFilterLookup;
private AbuseFilterPermissionManager $afPermManager;
private VariablesBlobStore $afVariablesBlobStore;
private VariablesManager $afVariablesManager;
private UserFactory $userFactory;
private AbuseLoggerFactory $abuseLoggerFactory;
/**
* @param ApiQuery $query
* @param string $moduleName
* @param FilterLookup $afFilterLookup
* @param AbuseFilterPermissionManager $afPermManager
* @param VariablesBlobStore $afVariablesBlobStore
* @param VariablesManager $afVariablesManager
* @param UserFactory $userFactory
* @param AbuseLoggerFactory $abuseLoggerFactory
*/
public function __construct(
ApiQuery $query,
$moduleName,
string $moduleName,
FilterLookup $afFilterLookup,
AbuseFilterPermissionManager $afPermManager,
VariablesBlobStore $afVariablesBlobStore,

View file

@ -10,17 +10,11 @@ use Wikimedia\ParamValidator\ParamValidator;
class UnblockAutopromote extends ApiBase {
/** @var BlockAutopromoteStore */
private $afBlockAutopromoteStore;
private BlockAutopromoteStore $afBlockAutopromoteStore;
/**
* @param ApiMain $main
* @param string $action
* @param BlockAutopromoteStore $afBlockAutopromoteStore
*/
public function __construct(
ApiMain $main,
$action,
string $action,
BlockAutopromoteStore $afBlockAutopromoteStore
) {
parent::__construct( $main, $action );