wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-09-24 02:38:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Distinguish AbuseFilter warnings and errors in VE"

Browse source
This commit is contained in:
jenkins-bot 2019-08-20 12:32:26 +00:00 committed by Gerrit Code Review
parent 6bcc2d2ccd 34cbad3d45
commit 671b8b7fb3
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
modules/ve-abusefilter/ve.init.mw.AbuseFilterSaveErrorHandler.js
View file

@ -11,11 +11,11 @@ mw.libs.ve.targetLoader.addPlugin( function () {
};
ve.init.mw.AbuseFilterSaveErrorHandler.static.process = function ( data, target ) {
var
$message = $( $.parseHTML( ve.getProp( data, 'visualeditoredit', 'edit', 'warning' ) ) ),
isWarning = ve.getProp( data, 'visualeditoredit', 'edit', 'code' ) !== 'abusefilter-disallowed';
// Handle warnings/errors from Extension:AbuseFilter
target.showSaveError( $( $.parseHTML( ve.getProp( data, 'visualeditoredit', 'edit', 'warning' ) ) ) );
// Don't disable the save button. If the action is not disallowed the user may save the
// edit by pressing Save again. The AbuseFilter API currently has no way to distinguish
// between filter triggers that are and aren't disallowing the action.
target.showSaveError( $message, isWarning, isWarning );
// Emit event for tracking. TODO: This is a bad design
target.emit( 'saveErrorAbuseFilter' );
};