wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-11-12 00:38:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

ext.abuseFilter.edit.js - minor cleanup

Browse source 
Avoid saving variables only used once, and other cleanup

Change-Id: Id47ebb889fa41373694f226c1a8f39cb2a6d8250
This commit is contained in:
DannyS712 2020-06-10 23:52:37 +00:00
parent 3f8e61b42f
commit 5f9c1ab053
1 changed files with 17 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
modules/ext.abuseFilter.edit.js
View file

@ -135,14 +135,13 @@
* @param {jQuery.Event} e The event fired when the function is called
*/
function doSyntaxCheck() {
var filter = $plainTextBox.val(),
api = new mw.Api();
var filter = $plainTextBox.val();
$( this )
.prop( 'disabled', true )
.injectSpinner( { id: 'abusefilter-syntaxcheck', size: 'large' } );
api.post( {
new mw.Api().post( {
action: 'abusefilterchecksyntax',
filter: filter
} )
@ -180,8 +179,7 @@
* @param {jQuery.Event} e The event fired when the function is called
*/
function fetchFilter() {
var filterId = $( '#mw-abusefilter-load-filter input' ).val().trim(),
api;
var filterId = $( '#mw-abusefilter-load-filter input' ).val().trim();
if ( filterId === '' ) {
return;
@ -190,8 +188,7 @@
$( this ).injectSpinner( { id: 'fetch-spinner', size: 'large' } );
// We just ignore errors or unexisting filters over here
api = new mw.Api();
api.get( {
new mw.Api().get( {
action: 'query',
list: 'abusefilters',
abfprop: 'pattern',
@ -238,7 +235,7 @@
* @param {string} action The action the message refers to
*/
function previewMessage( action ) {
var api = new mw.Api(),
var api,
args = [
'<nowiki>' + $( 'input[name=wpFilterDescription]' ).val() + '</nowiki>',
$( '#mw-abusefilter-edit-id' ).children().last().text()
@ -252,6 +249,7 @@
$element.hide();
previewButton.setFlags( { destructive: false, progressive: true } );
} else {
api = new mw.Api();
api.get( {
action: 'query',
meta: 'allmessages',
@ -394,18 +392,17 @@
separator = action === 'throttle' ? '\n' : ',',
selector, field, fieldOpts, hiddenField;
selector =
new OO.ui.TagMultiselectWidget( {
inputPosition: 'outline',
allowArbitrary: true,
allowEditTags: true,
selected: config.values,
// The following messages are used here:
// * abusefilter-edit-throttle-placeholder
// * abusefilter-edit-tag-placeholder
placeholder: OO.ui.msg( 'abusefilter-edit-' + action + '-placeholder' ),
disabled: config.disabled
} );
selector = new OO.ui.TagMultiselectWidget( {
inputPosition: 'outline',
allowArbitrary: true,
allowEditTags: true,
selected: config.values,
// The following messages are used here:
// * abusefilter-edit-throttle-placeholder
// * abusefilter-edit-tag-placeholder
placeholder: OO.ui.msg( 'abusefilter-edit-' + action + '-placeholder' ),
disabled: config.disabled
} );
fieldOpts = {
label: $( $.parseHTML( config.label ) ),