wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-11-23 13:46:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Simplify code by replacing isset() with falsy check"

Browse source
This commit is contained in:
jenkins-bot 2024-10-28 17:02:32 +00:00 committed by Gerrit Code Review
parent 0a62ce6587 6252afcac7
commit 5a930d59d3
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
includes/View/AbuseFilterViewHistory.php
View file

@ -74,16 +74,17 @@ class AbuseFilterViewHistory extends AbuseFilterView {
$canViewProtectedVars = $this->afPermManager->canViewProtectedVariables( $this->getAuthority() );
if ( $filter ) {
$filterObj = null;
try {
$filterObj = $this->filterLookup->getFilter( $filter, false );
} catch ( FilterNotFoundException $_ ) {
$filter = null;
}
if ( isset( $filterObj ) && $filterObj->isHidden() && !$canViewPrivate ) {
if ( $filterObj && $filterObj->isHidden() && !$canViewPrivate ) {
$out->addWikiMsg( 'abusefilter-history-error-hidden' );
return;
}
if ( isset( $filterObj ) && $filterObj->isProtected() && !$canViewProtectedVars ) {
if ( $filterObj && $filterObj->isProtected() && !$canViewProtectedVars ) {
$out->addWikiMsg( 'abusefilter-history-error-protected' );
return;
}