wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-11-27 15:30:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Remove script for blockautopromote entries"

Browse source
This commit is contained in:
jenkins-bot 2019-09-10 08:22:16 +00:00 committed by Gerrit Code Review
parent fa1e458e25 173bd089b3
commit 3c869b9290
2 changed files with 1 additions and 80 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
includes/AbuseFilterRightsLogFormatter.php
View file

@ -24,12 +24,7 @@ class AbuseFilterRightsLogFormatter extends LogFormatter {
if ( $this->entry->getSubType() === 'blockautopromote' ) {
$parameters = $this->entry->getParameters();
$duration = $parameters['7::duration'];
// @fixme Temporary for back-compat, all entries will have an int here
if ( is_int( $duration ) ) {
$ret[4] = $this->context->getLanguage()->formatDuration( $duration );
} else {
$ret[4] = $duration;
}
$ret[4] = $this->context->getLanguage()->formatDuration( $duration );
}
return $ret;
}

74
maintenance/fixFirstBlockautopromoteEntries.php
View file

@ -1,74 +0,0 @@
<?php
if ( getenv( 'MW_INSTALL_PATH' ) ) {
$IP = getenv( 'MW_INSTALL_PATH' );
} else {
$IP = __DIR__ . '/../../..';
}
require_once "$IP/maintenance/Maintenance.php";
/**
* Fix the first blockautopromote right entries, which had hardcoded duration
* NOTE: Given that the bad change has only survived for a couple of weeks, this script should
* only be executed in WMF production, and deleted afterwards.
*/
class FixFirstBlockautopromoteEntries extends Maintenance {
public function __construct() {
parent::__construct();
$this->addDescription( 'Fix old blockautopromote log entries with hardcoded duration' );
$this->addOption( 'verbose', 'Print some more debug info' );
$this->addOption( 'dry-run', 'Perform a dry run' );
$this->requireExtension( 'Abuse Filter' );
}
/**
* @inheritDoc
*/
public function execute() {
$dbr = wfGetDB( DB_REPLICA, 'vslow' );
$dbw = wfGetDB( DB_MASTER );
$res = $dbr->select(
'logging',
[ 'log_id', 'log_params' ],
[
'log_type' => 'rights',
'log_action' => 'blockautopromote'
],
__METHOD__
);
$updated = [];
foreach ( $res as $row ) {
$params = unserialize( $row->log_params );
$dur = $params['7::duration'];
if ( !is_int( $dur ) ) {
// This is the value that AbuseFilter::BLOCKAUTOPROMOTE_DURATION has for broken entries
$newVal = 5 * 86400;
$params['7::duration'] = $newVal;
if ( !$this->hasOption( 'dry-run' ) ) {
$dbw->update(
'logging',
[ 'log_params' => serialize( $params ) ],
[ 'log_id' => $row->log_id ],
__METHOD__
);
}
$updated[] = $row->log_id;
}
}
$verb = $this->hasOption( 'dry-run' ) ? 'would update' : 'updated';
$numUpd = count( $updated );
$this->output(
__CLASS__ . ": $verb $numUpd rows out of " . $res->numRows() . " rows found.\n"
);
if ( $updated && $this->hasOption( 'verbose' ) ) {
$this->output( 'The affected log IDs are: ' . implode( ', ', $updated ) . "\n" );
}
return true;
}
}
$maintClass = 'FixFirstBlockautopromoteEntries';
require_once RUN_MAINTENANCE_IF_MAIN;