From 38c46216db0a62334687409719aa50723dba725e Mon Sep 17 00:00:00 2001 From: Daimona Eaytoy Date: Thu, 10 May 2018 22:20:05 +0200 Subject: [PATCH] Explicitly declare title fields as optional They were defaulted to false with I93ad51ffe7bee597d2d127f4c5d6b2929ffc8f7e, which broke use cases where the page field is NOT required, nor has a 'required' => false explicitly declared. Bug: T194425 Change-Id: I5ab768c02a30b6d053104e590729ef22bb4e0808 --- includes/Views/AbuseFilterViewTestBatch.php | 3 ++- includes/special/SpecialAbuseLog.php | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/includes/Views/AbuseFilterViewTestBatch.php b/includes/Views/AbuseFilterViewTestBatch.php index 92337f24f..d54dfbefc 100644 --- a/includes/Views/AbuseFilterViewTestBatch.php +++ b/includes/Views/AbuseFilterViewTestBatch.php @@ -78,7 +78,8 @@ class AbuseFilterViewTestBatch extends AbuseFilterView { 'type' => 'title', 'label-message' => 'abusefilter-test-page', 'default' => $this->mTestPage, - 'creatable' => true + 'creatable' => true, + 'required' => false ]; $formFields['wpShowNegative'] = [ 'name' => 'wpShowNegative', diff --git a/includes/special/SpecialAbuseLog.php b/includes/special/SpecialAbuseLog.php index dc985fc80..f573dab53 100644 --- a/includes/special/SpecialAbuseLog.php +++ b/includes/special/SpecialAbuseLog.php @@ -169,6 +169,7 @@ class SpecialAbuseLog extends SpecialPage { 'label-message' => 'abusefilter-log-search-title', 'type' => 'title', 'default' => $this->mSearchTitle, + 'required' => false ], 'SearchImpact' => [ 'label-message' => 'abusefilter-log-search-impact',