wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-09-24 02:38:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Fix flags checkboxes broken in recent patch"

Browse source
This commit is contained in:
jenkins-bot 2018-05-06 02:35:01 +00:00 committed by Gerrit Code Review
parent 92ca600311 096bb4872b
commit 20b447f42e
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
includes/Views/AbuseFilterViewEdit.php
View file

@ -578,23 +578,25 @@ class AbuseFilterViewEdit extends AbuseFilterView {
$message = "abusefilter-edit-$checkboxId";
$dbField = "af_$checkboxId";
$postVar = 'wpFilter' . ucfirst( $checkboxId );
$cbReadOnlyAttrib = [];
$localReadOnlyAttrib = [];
if ( $checkboxId == 'global' && !$this->canEditGlobal() ) {
$cbReadOnlyAttrib['disabled'] = 'disabled';
$localReadOnlyAttrib['disabled'] = 'disabled';
}
// Set readonly on deleted if the filter isn't disabled
if ( $checkboxId == 'deleted' && $row->af_enabled == 1 ) {
$cbReadOnlyAttrib['disabled'] = 'disabled';
$localReadOnlyAttrib['disabled'] = 'disabled';
}
$readOnly = array_merge( $cbReadOnlyAttrib, $localReadOnlyAttrib );
$checkbox = Xml::checkLabel(
$this->msg( $message )->text(),
$postVar,
$postVar,
isset( $row->$dbField ) ? $row->$dbField : false,
$cbReadOnlyAttrib
$readOnly
);
$checkbox = Xml::tags( 'p', null, $checkbox );
$flags .= $checkbox;