mediawiki-extensions-AbuseF.../includes/AbuseFilterServices.php

<?php

namespace MediaWiki\Extension\AbuseFilter;

use MediaWiki\MediaWikiServices;

class AbuseFilterServices {
	/**
	 * Conveniency wrapper for strong typing
	 * @return KeywordsManager
	 */
	public static function getKeywordsManager() : KeywordsManager {
		return MediaWikiServices::getInstance()->getService( KeywordsManager::SERVICE_NAME );
	}
}
Introduce a KeywordsManager service This will decouple a bit the huge and chaotic tangle of AF classes. Some boilerplate code for AbuseFilter services is also added with this patch. Note that this requires injecting a KeywordsManager in AbuseFilterVariableHolder, or unit tests would fail. This is still incomplete, and the Manager is only injected in tests, because VariableHolder still has to be refactored. The test for the UpdateVarDumps script had to be updated, because serializing VHs in there was a bad choice. As pointed out in a comment, the test is likely going to break again once we remove the BC code, but I hope that we'll be able to remove the test at that point. Change-Id: I12a656a310adb8c5f75cab63f6db9e121e109717 2020-01-15 16:08:53 +00:00			`<?php`

			`namespace MediaWiki\Extension\AbuseFilter;`

			`use MediaWiki\MediaWikiServices;`

			`class AbuseFilterServices {`
			`/**`
			`* Conveniency wrapper for strong typing`
			`* @return KeywordsManager`
			`*/`
			`public static function getKeywordsManager() : KeywordsManager {`
			`return MediaWikiServices::getInstance()->getService( KeywordsManager::SERVICE_NAME );`
			`}`
			`}`