wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-11-12 00:38:23 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-AbuseF.../extension.json

605 lines
19 KiB
JSON
Raw Normal View History

Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
{
"name": "Abuse Filter",
"author": [
"Andrew Garrett",
Add `Daimona Eaytoy` to authors Daimona has been an extraordinary maintainer of this tool and has also implemented new features on Abuse Filter, so I guess it is just and fair to include his name to this list. Hyperlink is because `Daimona Eaytoy` is not a real name, according to his mediawiki.org userpage (can be removed if required; the law accepts authorship attributed to pseudonyms). In addition, the list of authors has been sorted alphabetically by name. If you prefer to order it by family name instead, please let me know. Change-Id: I6a3b0a757f9fd2af09358298e55a8b0487ce5b32
2019-07-04 10:22:20 +00:00
"[https://www.mediawiki.org/wiki/User:Daimona_Eaytoy Daimona Eaytoy]",
"Marius Hoch",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"River Tarnell",
Add `Daimona Eaytoy` to authors Daimona has been an extraordinary maintainer of this tool and has also implemented new features on Abuse Filter, so I guess it is just and fair to include his name to this list. Hyperlink is because `Daimona Eaytoy` is not a real name, according to his mediawiki.org userpage (can be removed if required; the law accepts authorship attributed to pseudonyms). In addition, the list of authors has been sorted alphabetically by name. If you prefer to order it by family name instead, please let me know. Change-Id: I6a3b0a757f9fd2af09358298e55a8b0487ce5b32
2019-07-04 10:22:20 +00:00
"Victor Vasiliev"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
],
"url": "https://www.mediawiki.org/wiki/Extension:AbuseFilter",
"descriptionmsg": "abusefilter-desc",
Use SPDX 3.0 license identifier SPDX released version 3 of their license list (<https://spdx.org/licenses/>), which changed the FSF licenses to explicitly end in -only or -or-later instead of relying on an easy to miss + symbol. Bug: T183858 Change-Id: Ib7a48d3a432f12ce1c27fe989e85a80335a25801
2018-01-04 03:01:35 +00:00
"license-name": "GPL-2.0-or-later",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"type": "antispam",
"requires": {
Use namespaced classes This requires 1.42 for some new names Changes to the use statements done automatically via script Addition of missing use statements and changes to docs done manually Change-Id: Ic1e2c9a0c891382744e4792bba1effece48e53f3
2023-12-10 19:03:19 +00:00
"MediaWiki": ">= 1.42.0"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"AvailableRights": [
"abusefilter-modify",
"abusefilter-log-detail",
"abusefilter-view",
"abusefilter-log",
Use "privatedetails" instead of "private" where needed To keep a clear distinction between "private details" (i.e. user's ip) and "private filters" (i.e. not publicly viewable). This patch renames rights, i18n keys and methods names. The patch for renaming globals and rights in WMF config is I7e6b3d4453403edb6aa602587374b4ff5b6d625f. Bug: T211004 Change-Id: I613dbadb8f75c8c4116a362607563a436a73d321
2019-01-07 15:23:21 +00:00
"abusefilter-privatedetails",
"abusefilter-privatedetails-log",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"abusefilter-modify-restricted",
"abusefilter-revert",
"abusefilter-view-private",
"abusefilter-log-private",
"abusefilter-hidden-log",
"abusefilter-hide-log",
BlockedExternalDomains: Make this a special right, prohibit direct editing Bug: T337431 Bug: T279275 Change-Id: I96d1e2c8d8728c26e38515032ef773770e26dda4
2023-06-01 13:01:14 +00:00
"abusefilter-modify-global",
Add abusefilter-bypass-blocked-external-domains right This is similar to sboverride right in SpamBlacklist. Defaults are also the same Bug: T337431 Change-Id: Iaff91c1f9f7aece0787348dd071701ef99e0291d
2023-06-08 19:26:33 +00:00
"abusefilter-modify-blocked-external-domains",
"abusefilter-bypass-blocked-external-domains"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
],
Add default rights config Add a conservative default configuration so that admins can use abuse filters without any need for manual setup, and users can see what's happening. Also expand grants a bit. Bug: T191740 Change-Id: I4e3125a708277474f416903928397db7f8fb850d
2018-04-08 17:46:18 +00:00
"GroupPermissions": {
"*": {
"abusefilter-view": true,
"abusefilter-log": true
},
"sysop": {
"abusefilter-log-detail": true,
Rearrange config to provide better experience In order to bundle AbuseFilter, we have to provide an optimal configuration for sysadmins. This patch aims to provide such configuration, and of course it's open to changes. Changed values: *Grant abusefilter-view-private to admins. This is mostly for redundancy-safety (they already have -modify) *Grant modify-restricted to admins (see T200032) *Disable the 'degroup' action. This is really dangerous, not ideal to be enabled by default. *Grant the abusefilter-revert right to sysops. This is similar to assigning the modify-restricted right in its rationale. *Add abusefilter-log-private to viewrestrictedlogs grant. This right should go together with abusefilter-view-private. (T226987) *Remove abusefilter-revert from the rollback grant, as that right is for reverting AF actions and has nothing to do with rollbacks. This mostly copies the config of WMF production: degrouping is already disabled there, and modify-restricted should be assigned to sysops on WMF wikis as well. The assignment of the abusefilter-view-private and abusefiliter-revert rights is handled in I09cb462312c5bbc71ee3a8f0fbd91357908130d4 (parent patch) to keep the status quo. NOTE: this patch should be *deployed* together with the config patch to avoid discontinuities. Thus, please ONLY provide a virtual +2 using a +1, and I'll coordinate the +2 with a deployer. Bug: T191740 Bug: T200032 Bug: T226987 Depends-On: I09cb462312c5bbc71ee3a8f0fbd91357908130d4 Change-Id: I58f215b8aa3444602532098a3c9dfd25409f29eb
2018-10-20 10:24:53 +00:00
"abusefilter-view-private": true,
"abusefilter-log-private": true,
"abusefilter-modify": true,
"abusefilter-modify-restricted": true,
BlockedExternalDomains: Make this a special right, prohibit direct editing Bug: T337431 Bug: T279275 Change-Id: I96d1e2c8d8728c26e38515032ef773770e26dda4
2023-06-01 13:01:14 +00:00
"abusefilter-revert": true,
"abusefilter-modify-blocked-external-domains": true
Rearrange config to provide better experience In order to bundle AbuseFilter, we have to provide an optimal configuration for sysadmins. This patch aims to provide such configuration, and of course it's open to changes. Changed values: *Grant abusefilter-view-private to admins. This is mostly for redundancy-safety (they already have -modify) *Grant modify-restricted to admins (see T200032) *Disable the 'degroup' action. This is really dangerous, not ideal to be enabled by default. *Grant the abusefilter-revert right to sysops. This is similar to assigning the modify-restricted right in its rationale. *Add abusefilter-log-private to viewrestrictedlogs grant. This right should go together with abusefilter-view-private. (T226987) *Remove abusefilter-revert from the rollback grant, as that right is for reverting AF actions and has nothing to do with rollbacks. This mostly copies the config of WMF production: degrouping is already disabled there, and modify-restricted should be assigned to sysops on WMF wikis as well. The assignment of the abusefilter-view-private and abusefiliter-revert rights is handled in I09cb462312c5bbc71ee3a8f0fbd91357908130d4 (parent patch) to keep the status quo. NOTE: this patch should be *deployed* together with the config patch to avoid discontinuities. Thus, please ONLY provide a virtual +2 using a +1, and I'll coordinate the +2 with a deployer. Bug: T191740 Bug: T200032 Bug: T226987 Depends-On: I09cb462312c5bbc71ee3a8f0fbd91357908130d4 Change-Id: I58f215b8aa3444602532098a3c9dfd25409f29eb
2018-10-20 10:24:53 +00:00
},
"suppress": {
"abusefilter-hidden-log": true,
"abusefilter-hide-log": true
Add abusefilter-bypass-blocked-external-domains right This is similar to sboverride right in SpamBlacklist. Defaults are also the same Bug: T337431 Change-Id: Iaff91c1f9f7aece0787348dd071701ef99e0291d
2023-06-08 19:26:33 +00:00
},
"bot": {
"abusefilter-bypass-blocked-external-domains": true
Add default rights config Add a conservative default configuration so that admins can use abuse filters without any need for manual setup, and users can see what's happening. Also expand grants a bit. Bug: T191740 Change-Id: I4e3125a708277474f416903928397db7f8fb850d
2018-04-08 17:46:18 +00:00
}
},
"GrantPermissions": {
"basic": {
"abusefilter-log": true,
add grant to view private abusefilter log entries Bug: T191703 Change-Id: I56233786ddaa6c44e6778b56070cf9b13df20dcc
2018-04-07 19:45:28 +00:00
"abusefilter-log-detail": true,
"abusefilter-view": true
Add default rights config Add a conservative default configuration so that admins can use abuse filters without any need for manual setup, and users can see what's happening. Also expand grants a bit. Bug: T191740 Change-Id: I4e3125a708277474f416903928397db7f8fb850d
2018-04-08 17:46:18 +00:00
},
Rearrange config to provide better experience In order to bundle AbuseFilter, we have to provide an optimal configuration for sysadmins. This patch aims to provide such configuration, and of course it's open to changes. Changed values: *Grant abusefilter-view-private to admins. This is mostly for redundancy-safety (they already have -modify) *Grant modify-restricted to admins (see T200032) *Disable the 'degroup' action. This is really dangerous, not ideal to be enabled by default. *Grant the abusefilter-revert right to sysops. This is similar to assigning the modify-restricted right in its rationale. *Add abusefilter-log-private to viewrestrictedlogs grant. This right should go together with abusefilter-view-private. (T226987) *Remove abusefilter-revert from the rollback grant, as that right is for reverting AF actions and has nothing to do with rollbacks. This mostly copies the config of WMF production: degrouping is already disabled there, and modify-restricted should be assigned to sysops on WMF wikis as well. The assignment of the abusefilter-view-private and abusefiliter-revert rights is handled in I09cb462312c5bbc71ee3a8f0fbd91357908130d4 (parent patch) to keep the status quo. NOTE: this patch should be *deployed* together with the config patch to avoid discontinuities. Thus, please ONLY provide a virtual +2 using a +1, and I'll coordinate the +2 with a deployer. Bug: T191740 Bug: T200032 Bug: T226987 Depends-On: I09cb462312c5bbc71ee3a8f0fbd91357908130d4 Change-Id: I58f215b8aa3444602532098a3c9dfd25409f29eb
2018-10-20 10:24:53 +00:00
"oversight": {
"abusefilter-hide-log": true
Add default rights config Add a conservative default configuration so that admins can use abuse filters without any need for manual setup, and users can see what's happening. Also expand grants a bit. Bug: T191740 Change-Id: I4e3125a708277474f416903928397db7f8fb850d
2018-04-08 17:46:18 +00:00
},
"viewrestrictedlogs": {
add grant to view private abusefilter log entries Bug: T191703 Change-Id: I56233786ddaa6c44e6778b56070cf9b13df20dcc
2018-04-07 19:45:28 +00:00
"abusefilter-hidden-log": true,
Rearrange config to provide better experience In order to bundle AbuseFilter, we have to provide an optimal configuration for sysadmins. This patch aims to provide such configuration, and of course it's open to changes. Changed values: *Grant abusefilter-view-private to admins. This is mostly for redundancy-safety (they already have -modify) *Grant modify-restricted to admins (see T200032) *Disable the 'degroup' action. This is really dangerous, not ideal to be enabled by default. *Grant the abusefilter-revert right to sysops. This is similar to assigning the modify-restricted right in its rationale. *Add abusefilter-log-private to viewrestrictedlogs grant. This right should go together with abusefilter-view-private. (T226987) *Remove abusefilter-revert from the rollback grant, as that right is for reverting AF actions and has nothing to do with rollbacks. This mostly copies the config of WMF production: degrouping is already disabled there, and modify-restricted should be assigned to sysops on WMF wikis as well. The assignment of the abusefilter-view-private and abusefiliter-revert rights is handled in I09cb462312c5bbc71ee3a8f0fbd91357908130d4 (parent patch) to keep the status quo. NOTE: this patch should be *deployed* together with the config patch to avoid discontinuities. Thus, please ONLY provide a virtual +2 using a +1, and I'll coordinate the +2 with a deployer. Bug: T191740 Bug: T200032 Bug: T226987 Depends-On: I09cb462312c5bbc71ee3a8f0fbd91357908130d4 Change-Id: I58f215b8aa3444602532098a3c9dfd25409f29eb
2018-10-20 10:24:53 +00:00
"abusefilter-log-private": true,
add grant to view private abusefilter log entries Bug: T191703 Change-Id: I56233786ddaa6c44e6778b56070cf9b13df20dcc
2018-04-07 19:45:28 +00:00
"abusefilter-view-private": true
Add abusefilter-bypass-blocked-external-domains right This is similar to sboverride right in SpamBlacklist. Defaults are also the same Bug: T337431 Change-Id: Iaff91c1f9f7aece0787348dd071701ef99e0291d
2023-06-08 19:26:33 +00:00
},
"editprotected": {
"abusefilter-bypass-blocked-external-domains": true
Add default rights config Add a conservative default configuration so that admins can use abuse filters without any need for manual setup, and users can see what's happening. Also expand grants a bit. Bug: T191740 Change-Id: I4e3125a708277474f416903928397db7f8fb850d
2018-04-08 17:46:18 +00:00
}
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"SpecialPages": {
Use LinkBatchFactory in Special:AbuseLog Change-Id: I2ccf9cd36475a65e61ad0e80ec159f841849089f
2020-08-07 21:48:47 +00:00
"AbuseLog": {
Move special page classes to own namespace Change-Id: Ic2d13518924e77b1be96d1a7489abcd07e6d1dab
2021-01-01 17:28:36 +00:00
"class": "MediaWiki\\Extension\\AbuseFilter\\Special\\SpecialAbuseLog",
Use LinkBatchFactory in Special:AbuseLog Change-Id: I2ccf9cd36475a65e61ad0e80ec159f841849089f
2020-08-07 21:48:47 +00:00
"services": [
Replace deprecated database object access methods Use the very new getPrimaryDatabase and getReplicaDatabase. We skip FilterLookup and CentralDBManager in this patch. Change-Id: I22c6f8fa60be90599ee177a4ac4a97e1547f79be
2023-02-26 12:51:08 +00:00
"DBLoadBalancerFactory",
Inject PermissionManager to SpecialAbuseLog Change-Id: I1c80490567ac2d9f716c988ebdad6b59cf28aa06
2020-09-17 06:54:06 +00:00
"LinkBatchFactory",
Add an AbuseFilterPermissionManager service This service should act as a mediator between the AF code and the permission manager, and it should know what are the permissions required by each action. Change-Id: Ieb177d9992147b11fa7b8f05929da6c182cc2286
2020-09-18 14:49:13 +00:00
"PermissionManager",
Use UserIdentity/Authority in SpecialAbuseLog Change-Id: I5b3b2b758e17c94298e7217d755dd8c7b08cb1ac
2022-06-27 20:23:24 +00:00
"UserIdentityLookup",
Add ConsequencesRegistry Change-Id: I91f4f28e09fa46b9ab2457b2a241b6f105320bdd
2020-11-29 22:55:34 +00:00
"AbuseFilterPermissionManager",
Add a VariablesBlobStore service Change-Id: If0c1eab2391819f8b4c801d12275d9ec14490f7a
2020-09-29 14:52:05 +00:00
"AbuseFilterConsequencesRegistry",
Add a service to format filter specs This requires a MessageLocalizer, which currently means providing the main RequestContext. This is the only alternative right now, until core provides a proper MessageLocalizer service (see T247127). Change-Id: I8c93e2ae7e7bd4fc561c5e8490ed2feb1ef0edc2
2020-10-02 15:08:48 +00:00
"AbuseFilterVariablesBlobStore",
Introduce a VariablesFormatter service Moves more methods away from the AbuseFilter class. Testing buildVarDumpTable is not easy because we'd have to parse the generated HTML. Change-Id: I073a537201de150ba9dd7bf15a99f3a009dc6ba1
2020-12-31 13:29:00 +00:00
"AbuseFilterSpecsFormatter",
Create a VariablesManager service This makes VariableHolder a true value object, and introduces a stateless service, VariableManager, to operate on it. Note, in theory, this new service is still cyclically coupled with LazyVariableComputed. However, it's now two stateless service being coupled, not two smart/god value objects, so we've still earned something. For now, the dependency is hidden by using a callback. Some alternatives for that are mentioned in a code comment. Bug: T261069 Change-Id: I2f2c84c8e91472ba36084a8bbb4a923f6e04354b
2020-10-18 22:25:05 +00:00
"AbuseFilterVariablesFormatter",
"AbuseFilterVariablesManager"
Use LinkBatchFactory in Special:AbuseLog Change-Id: I2ccf9cd36475a65e61ad0e80ec159f841849089f
2020-08-07 21:48:47 +00:00
]
},
DI for AbuseFilterView and subclasses Also add a test to ensure all views can be instantiated without problem. Change-Id: Iedd7a5dca240efab1077fa51a3522c983b0ba4fa
2020-10-23 14:19:02 +00:00
"AbuseFilter": {
Move special page classes to own namespace Change-Id: Ic2d13518924e77b1be96d1a7489abcd07e6d1dab
2021-01-01 17:28:36 +00:00
"class": "MediaWiki\\Extension\\AbuseFilter\\Special\\SpecialAbuseFilter",
DI for AbuseFilterView and subclasses Also add a test to ensure all views can be instantiated without problem. Change-Id: Iedd7a5dca240efab1077fa51a3522c983b0ba4fa
2020-10-23 14:19:02 +00:00
"services": [
DI for AbuseFilterSpecialPage Change-Id: I5c702990398e0adb5fa73be54638cb8b6b268beb
2021-01-02 09:52:35 +00:00
"AbuseFilterPermissionManager",
DI for AbuseFilterView and subclasses Also add a test to ensure all views can be instantiated without problem. Change-Id: Iedd7a5dca240efab1077fa51a3522c983b0ba4fa
2020-10-23 14:19:02 +00:00
"ObjectFactory"
]
Introduce Special:BlockedExternalDomains It is behind a feature flag. Improvements on it can happen in follow ups. The patch is already quite massive. Bug: T337431 Bug: T279275 Change-Id: I3df949c4d41ce65bb4afa013da9c691ac05fc760
2023-05-24 20:09:59 +00:00
},
"BlockedExternalDomains": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Special\\BlockedExternalDomains",
"services": [
"AbuseFilterBlockedDomainStorage",
BlockedDomains: Put a cache behind parsing of notes of blocked domains It'll be 6K rows in enwiki, parsing 6000 wikitext notes is going to be expensive. Bug: T337431 Change-Id: I010d773a7b096c783f5da0d6997d946b3bfd6b6e
2023-06-01 17:10:07 +00:00
"MainWANObjectCache"
Introduce Special:BlockedExternalDomains It is behind a feature flag. Improvements on it can happen in follow ups. The patch is already quite massive. Bug: T337431 Bug: T279275 Change-Id: I3df949c4d41ce65bb4afa013da9c691ac05fc760
2023-05-24 20:09:59 +00:00
]
DI for AbuseFilterView and subclasses Also add a test to ensure all views can be instantiated without problem. Change-Id: Iedd7a5dca240efab1077fa51a3522c983b0ba4fa
2020-10-23 14:19:02 +00:00
}
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"LogTypes": [
Log accessing private information in abuse filter logs Bug: T152934 Change-Id: I8049df3b2b9343a6877e9a306d2781d3f27ec657
2016-12-12 16:30:06 +00:00
"abusefilter",
BlockedDomains: Add logging in case of hit This is basically copy paste of SpamBlacklist logging with the added extra bit of what triggered the hit. Bug: T337431 Change-Id: Ieb9e3ca615af88ab56735b56e24c80c42a68d478
2023-06-12 01:32:07 +00:00
"abusefilterblockeddomainhit",
Log accessing private information in abuse filter logs Bug: T152934 Change-Id: I8049df3b2b9343a6877e9a306d2781d3f27ec657
2016-12-12 16:30:06 +00:00
"abusefilterprivatedetails"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
],
"LogNames": {
Log accessing private information in abuse filter logs Bug: T152934 Change-Id: I8049df3b2b9343a6877e9a306d2781d3f27ec657
2016-12-12 16:30:06 +00:00
"abusefilter": "abusefilter-log-name",
"abusefilterprivatedetails": "abusefilterprivatedetails-log-name"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"LogHeaders": {
"abusefilter": "abusefilter-log-header"
},
"LogActionsHandlers": {
Move log formatters to a separate directory and namespace This will clean up the includes/ directory a little. Change-Id: I61adacf32257bb2402a272b60b52b69505d981c5
2020-10-07 11:23:10 +00:00
"abusefilter/hit": "MediaWiki\\Extension\\AbuseFilter\\LogFormatter\\AbuseLogHitFormatter",
"abusefilter/modify": "MediaWiki\\Extension\\AbuseFilter\\LogFormatter\\AbuseFilterModifyLogFormatter",
"abusefilter/create": "MediaWiki\\Extension\\AbuseFilter\\LogFormatter\\AbuseFilterModifyLogFormatter",
BlockedDomains: Add logging in case of hit This is basically copy paste of SpamBlacklist logging with the added extra bit of what triggered the hit. Bug: T337431 Change-Id: Ieb9e3ca615af88ab56735b56e24c80c42a68d478
2023-06-12 01:32:07 +00:00
"abusefilterblockeddomainhit/*": "MediaWiki\\Extension\\AbuseFilter\\LogFormatter\\AbuseFilterBlockedDomainHitLogFormatter",
Migrate AbuseFilter suppress log Also make entries in Special:Log/suppress filterable. Change-Id: Ic23e724997e4748c8d0da8138aa73d31b17b7064
2017-02-15 18:12:31 +00:00
"abusefilterprivatedetails/access": "LogFormatter",
Move log formatters to a separate directory and namespace This will clean up the includes/ directory a little. Change-Id: I61adacf32257bb2402a272b60b52b69505d981c5
2020-10-07 11:23:10 +00:00
"suppress/hide-afl": "MediaWiki\\Extension\\AbuseFilter\\LogFormatter\\AbuseFilterSuppressLogFormatter",
"suppress/unhide-afl": "MediaWiki\\Extension\\AbuseFilter\\LogFormatter\\AbuseFilterSuppressLogFormatter",
"rights/blockautopromote": "MediaWiki\\Extension\\AbuseFilter\\LogFormatter\\AbuseFilterRightsLogFormatter",
"rights/restoreautopromote": "MediaWiki\\Extension\\AbuseFilter\\LogFormatter\\AbuseFilterRightsLogFormatter"
Actually mark abusefilter creations as such in the AbuseFilter log Bug: T178283 Co-Authored-By: Matěj Suchánek <matejsuchanek97@gmail.com> Change-Id: I89776eff2fc420b1fe3e2c3b88671749fadb57b4
2017-10-16 11:19:30 +00:00
},
"ActionFilteredLogs": {
"abusefilter": {
"modify": [
"modify"
],
"create": [
"create"
]
Inject dependencies into the authentication provider - Define it with the extension.json key, instead of using the registration callback - Inject the services it needs - Replace direct User instantiation with UserFactory - Move log subtypes to extension.json as well Change-Id: I86a761c7fa844b1f417b974798373622a15f6411
2022-04-09 15:07:45 +00:00
},
"suppress": {
"abuselog": [
"hide-afl",
"unhide-afl"
]
},
"rights": {
"blockautopromote": [
"blockautopromote"
],
"restoreautopromote": [
"restoreautopromote"
]
Actually mark abusefilter creations as such in the AbuseFilter log Bug: T178283 Co-Authored-By: Matěj Suchánek <matejsuchanek97@gmail.com> Change-Id: I89776eff2fc420b1fe3e2c3b88671749fadb57b4
2017-10-16 11:19:30 +00:00
}
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
Log accessing private information in abuse filter logs Bug: T152934 Change-Id: I8049df3b2b9343a6877e9a306d2781d3f27ec657
2016-12-12 16:30:06 +00:00
"LogRestrictions": {
Restrict viewing Special:Log/AbuseFilter, and remove from recent changes Only allow users with `abusefilter-view` to see abuse filter log entries. Note that this is different from the abuse log itself. Bug: T34959 Change-Id: I587c2eb9bdc2e5ca2652aa338440cdc5b6eb9235
2019-11-10 10:33:51 +00:00
"abusefilter": "abusefilter-view",
Restrict view of "abusefilterblockeddomainhit" logs to "*" That is noop but at the same time prevents logs of hitting blocked domains list from showing up in watchlists. Change-Id: I56225f80bb7d87841fd991f5cde49e67bdb5823a
2023-06-27 18:16:00 +00:00
"abusefilterprivatedetails": "abusefilter-privatedetails-log",
"abusefilterblockeddomainhit": "abusefilter-view"
Log accessing private information in abuse filter logs Bug: T152934 Change-Id: I8049df3b2b9343a6877e9a306d2781d3f27ec657
2016-12-12 16:30:06 +00:00
},
Inject dependencies into the authentication provider - Define it with the extension.json key, instead of using the registration callback - Inject the services it needs - Replace direct User instantiation with UserFactory - Move log subtypes to extension.json as well Change-Id: I86a761c7fa844b1f417b974798373622a15f6411
2022-04-09 15:07:45 +00:00
"AuthManagerAutoConfig": {
"preauth": {
"AbuseFilterPreAuthenticationProvider": {
"class": "MediaWiki\\Extension\\AbuseFilter\\AbuseFilterPreAuthenticationProvider",
"services": [
"AbuseFilterVariableGeneratorFactory",
Add tests for extension.json and services Change-Id: Ie83e4a85a408e1ba1d2cc827c4bf353bdd5500df
2023-03-27 16:43:06 +00:00
"AbuseFilterFilterRunnerFactory",
Inject dependencies into the authentication provider - Define it with the extension.json key, instead of using the registration callback - Inject the services it needs - Replace direct User instantiation with UserFactory - Move log subtypes to extension.json as well Change-Id: I86a761c7fa844b1f417b974798373622a15f6411
2022-04-09 15:07:45 +00:00
"StatsdDataFactory",
"UserFactory"
],
"sort": 5
}
}
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"APIModules": {
Api: inject AbuseFilterPermissionManager where needed Some of these api modules still retrieve other services statically, this patch is focused just on injecting the permission manager and setting up DI Bug: T259960 Change-Id: Ic5196f230d68604fdf321f705377a1e6e1e2efca
2021-03-25 03:48:03 +00:00
"abusefilterchecksyntax": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Api\\CheckSyntax",
"services": [
Rename ParserFactory -> RuleCheckerFactory The old parser now has the correct name "Evaluator", so the ParserFactory name was outdated. Additionally, the plan is to create a new RuleChecker class, acting as a facade for the different parsing-related stages (lexer, parser, evaluator, etc.), which is what most if not all callers should use. The RuleCheckerFactory still returns a FilterEvaluator for now. Also, "Parser" is a specific term defining *how* things happen internally, whereas "RuleChecker" describes *what* callers should expect from the new class. Change-Id: I25b47a162d933c1e385175aae715ca38872b1442
2021-09-01 11:53:38 +00:00
"AbuseFilterRuleCheckerFactory",
Api: inject AbuseFilterPermissionManager where needed Some of these api modules still retrieve other services statically, this patch is focused just on injecting the permission manager and setting up DI Bug: T259960 Change-Id: Ic5196f230d68604fdf321f705377a1e6e1e2efca
2021-03-25 03:48:03 +00:00
"AbuseFilterPermissionManager"
]
},
"abusefilterevalexpression": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Api\\EvalExpression",
"services": [
Rename ParserFactory -> RuleCheckerFactory The old parser now has the correct name "Evaluator", so the ParserFactory name was outdated. Additionally, the plan is to create a new RuleChecker class, acting as a facade for the different parsing-related stages (lexer, parser, evaluator, etc.), which is what most if not all callers should use. The RuleCheckerFactory still returns a FilterEvaluator for now. Also, "Parser" is a specific term defining *how* things happen internally, whereas "RuleChecker" describes *what* callers should expect from the new class. Change-Id: I25b47a162d933c1e385175aae715ca38872b1442
2021-09-01 11:53:38 +00:00
"AbuseFilterRuleCheckerFactory",
Api: inject more abuse filter services Bug: T259960 Change-Id: I50565bdc8669f233ac68589a203104bf1632d637
2021-04-04 18:57:49 +00:00
"AbuseFilterPermissionManager",
"AbuseFilterVariableGeneratorFactory"
]
},
"abusefilterunblockautopromote": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Api\\UnblockAutopromote",
"services": [
"AbuseFilterBlockAutopromoteStore"
Api: inject AbuseFilterPermissionManager where needed Some of these api modules still retrieve other services statically, this patch is focused just on injecting the permission manager and setting up DI Bug: T259960 Change-Id: Ic5196f230d68604fdf321f705377a1e6e1e2efca
2021-03-25 03:48:03 +00:00
]
},
"abusefiltercheckmatch": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Api\\CheckMatch",
"services": [
Rename ParserFactory -> RuleCheckerFactory The old parser now has the correct name "Evaluator", so the ParserFactory name was outdated. Additionally, the plan is to create a new RuleChecker class, acting as a facade for the different parsing-related stages (lexer, parser, evaluator, etc.), which is what most if not all callers should use. The RuleCheckerFactory still returns a FilterEvaluator for now. Also, "Parser" is a specific term defining *how* things happen internally, whereas "RuleChecker" describes *what* callers should expect from the new class. Change-Id: I25b47a162d933c1e385175aae715ca38872b1442
2021-09-01 11:53:38 +00:00
"AbuseFilterRuleCheckerFactory",
Api: inject more abuse filter services Bug: T259960 Change-Id: I50565bdc8669f233ac68589a203104bf1632d637
2021-04-04 18:57:49 +00:00
"AbuseFilterPermissionManager",
"AbuseFilterVariablesBlobStore",
"AbuseFilterVariableGeneratorFactory"
Api: inject AbuseFilterPermissionManager where needed Some of these api modules still retrieve other services statically, this patch is focused just on injecting the permission manager and setting up DI Bug: T259960 Change-Id: Ic5196f230d68604fdf321f705377a1e6e1e2efca
2021-03-25 03:48:03 +00:00
]
},
"abuselogprivatedetails": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Api\\AbuseLogPrivateDetails",
"services": [
"AbuseFilterPermissionManager"
]
}
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"APIListModules": {
Api: inject AbuseFilterPermissionManager where needed Some of these api modules still retrieve other services statically, this patch is focused just on injecting the permission manager and setting up DI Bug: T259960 Change-Id: Ic5196f230d68604fdf321f705377a1e6e1e2efca
2021-03-25 03:48:03 +00:00
"abuselog": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Api\\QueryAbuseLog",
"services": [
Api: inject more abuse filter services Bug: T259960 Change-Id: I50565bdc8669f233ac68589a203104bf1632d637
2021-04-04 18:57:49 +00:00
"AbuseFilterFilterLookup",
"AbuseFilterPermissionManager",
"AbuseFilterVariablesBlobStore",
"AbuseFilterVariablesManager"
Api: inject AbuseFilterPermissionManager where needed Some of these api modules still retrieve other services statically, this patch is focused just on injecting the permission manager and setting up DI Bug: T259960 Change-Id: Ic5196f230d68604fdf321f705377a1e6e1e2efca
2021-03-25 03:48:03 +00:00
]
},
"abusefilters": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Api\\QueryAbuseFilters",
"services": [
"AbuseFilterPermissionManager"
]
}
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"MessagesDirs": {
"AbuseFilter": [
Move all apihelp translatable messages to separate files Should be merged along with Ib66f4614285411e5fd971dc0cb4291ea8113418c Bug: T189982 Change-Id: Id9beb08ee34e6861543cf59d80abfac616bf9238
2018-03-19 16:07:25 +00:00
"i18n",
"i18n/api"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
]
},
"ExtensionMessagesFiles": {
"AbuseFilterAliases": "AbuseFilter.alias.php"
},
Re-add BC alias for the VariableHolder class Looks like it's needed for the UpdateVarDumps script, so add a note about that. Also add a type check to the script so that it produces a clearer error message if it finds an entity with unexpected type. Bug: T331861 Change-Id: I68f8f954ed754c4282e13599ce06118e2336ecbb
2023-03-13 12:46:09 +00:00
"AutoloadClasses": {
"AbuseFilterVariableHolder": "includes/Variables/VariableHolder.php",
"MediaWiki\\Extension\\AbuseFilter\\Variables\\VariableHolder": "includes/Variables/VariableHolder.php"
},
Move variable generators to new classes RunVariableGenerator is for generating variables based on the current action; RowVariableGenerator is for RC entries; VariableGenerator is the generic one. This patch only moves the methods to the new classes, to keep the diff easier to read, and facilitate conflict resolution. These classes will then be revamped in I366d598b69ad866496b7cb0059e0835c02e54041. Note that these classes are now namespaced. One method, AbuseFilter::getEditVars, was renamed to AbuseFilterVariableGenerator::generateEditVars, because it would otherwise conflict with an incompatible method in RunVariableGenerator. Change-Id: Iff412e5492873d4fae55402939a51609e64d55a8
2020-01-11 17:05:30 +00:00
"AutoloadNamespaces": {
Move remaining classes to own namespace So everything can be loaded using PSR-4. These classes weren't renamed, nor the alias for the AbuseFilter class was deprecated, because they should be refactored first. Change-Id: Ia328db58eb326968edf5591daac9bacf8c2f75da
2021-01-03 11:12:16 +00:00
"MediaWiki\\Extension\\AbuseFilter\\": "includes/",
"MediaWiki\\Extension\\AbuseFilter\\Maintenance\\": "maintenance/"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
Move test-only classes to new TestAutoloadClasses declaration Bug: T196090 Depends-On: I88cf69663362fd599c20649b1df641907a02678d Change-Id: I5e3ef040628c4ff629a8aabc56a3b8ba259b7e78
2019-12-10 19:40:18 +00:00
"TestAutoloadClasses": {
Organize unit tests Add namespaces, shorten class names. Non-unit tests and AbuseFilterTest are untouched because those should be refactored first. Change-Id: Ie46ef18d6ba1017e25c76b1762f678e5452264d9
2021-01-01 13:11:09 +00:00
"MediaWiki\\Extension\\AbuseFilter\\Tests\\Unit\\Parser\\ParserTestCase": "tests/phpunit/unit/Parser/ParserTestCase.php",
Cover some API modules by tests Change-Id: Icc57e260b3b06a58fc05f304d6e63dc40f970fe9
2021-02-02 11:16:40 +00:00
"MediaWiki\\Extension\\AbuseFilter\\Tests\\Integration\\Api\\AbuseFilterApiTestTrait": "tests/phpunit/integration/Api/AbuseFilterApiTestTrait.php",
Add test traits for uploads and account creation Ideally, this might live in MediaWikiIntegrationTestCase. For the createaccount one, AuthManager should also provide a method to log the creation, because currently we are forced to copypaste that code here. - Add the missing tests for 'upload' in RCVariableGenerator, and adjust the existing ones (delete file afterwards, more tablesUsed, use the right extension). - Exclude from the coverage report a couple of lines which should theoretically be unreachable. Escalate logging to WARN level, where it's more likely to be spotted. - Remove an unused method (RCVariableGenerator::newFromID). This denies the need to maintain and cover it. We also don't want this generator to act as a factory. Overall, this change brings the coverage for RCVariableGenerator to 100% Bug: T201193 Change-Id: I425c3d9f6800f74eb6e4eda483b90cfb3bbbcb51
2020-09-16 09:15:38 +00:00
"AbuseFilterUploadTestTrait": "tests/phpunit/AbuseFilterUploadTestTrait.php",
Add a FilterLookup service Some pieces of code were updated to use Filter objects, while other places are still to be updated. We also need to change the history part to exclude actions somehow, cleanup the ViewEdit, reduce direct DB access or anything mentioning DB fields outside of FilterLookup, etc. Change-Id: I42b7ded685db76eddd45e4b1336f9828cba811ce
2020-09-20 11:30:59 +00:00
"AbuseFilterCreateAccountTestTrait": "tests/phpunit/AbuseFilterCreateAccountTestTrait.php",
Improve coverage for Consequences methods In particular getMessage Change-Id: I1c0e533bccde458e64008a4e02556273ce11d5e7
2021-01-06 13:07:02 +00:00
"AbuseFilterRowsAndFiltersTestTrait": "tests/phpunit/AbuseFilterRowsAndFiltersTestTrait.php",
"ConsequenceGetMessageTestTrait": "tests/phpunit/ConsequenceGetMessageTestTrait.php"
Move test-only classes to new TestAutoloadClasses declaration Bug: T196090 Depends-On: I88cf69663362fd599c20649b1df641907a02678d Change-Id: I5e3ef040628c4ff629a8aabc56a3b8ba259b7e78
2019-12-10 19:40:18 +00:00
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"ResourceModules": {
"ext.abuseFilter": {
"styles": "ext.abuseFilter.css"
},
"ext.abuseFilter.edit": {
"scripts": "ext.abuseFilter.edit.js",
"messages": [
"abusefilter-edit-syntaxok",
"abusefilter-edit-syntaxerr",
"abusefilter-http-error",
Change throttle selector to restore old functionality, overall improvement Long (sigh) explanation in T203587#4569698. Also, simplified the way TagMultiselect are generated, this one and the one for change tags. This new selector is back-compat both with the old textarea and the OOUI checkboxMultiselect; actually, this one is //fully// compatible with the old textarea. Add validation for throttle parameters and unit tests for validation (split from I976c95658cddb2585910b6f8a5f047aadc4e4d47). Added a trim when retrieving throttle identifier to allow syntax like 'ip, user'. Improved the message shown on history. Re-added the maintenance script to clean DB. As I wrote in the task, a review by two other people would be great, at least for the maintenance script (it could potentially break the DB). Bug: T203587 Bug: T203336 Bug: T203584 Bug: T203585 Depends-On: I3b2e763bd8835207dc5df1db43d3e1881e6961c3 Change-Id: I7831dbb0bab55807392ac1f7915d6cb0cb713593
2018-09-09 10:14:31 +00:00
"abusefilter-edit-throttle-placeholder",
"abusefilter-edit-tag-placeholder",
Warn the user if they try to leave the page with unsaved changes While editing filters, sometimes it happen that you make some change, forget about it and then reload/close the page, and no warnings will be issued. This patch makes use of the core module used for normal page editing to display a warning if trying to leave a filter editing page with any unsaved change (both to the filter pattern or other form elements). Change-Id: I78d79215565d5c82028b1a2a4276497ccbffdea2
2018-12-04 12:06:46 +00:00
"abusefilter-edit-warn-leave",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"unknown-error"
],
"dependencies": [
"mediawiki.util",
"mediawiki.api",
Warn the user if they try to leave the page with unsaved changes While editing filters, sometimes it happen that you make some change, forget about it and then reload/close the page, and no warnings will be issued. This patch makes use of the core module used for normal page editing to display a warning if trying to leave a filter editing page with any unsaved change (both to the filter pattern or other form elements). Change-Id: I78d79215565d5c82028b1a2a4276497ccbffdea2
2018-12-04 12:06:46 +00:00
"mediawiki.confirmCloseWindow",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"jquery.textSelection",
Switch editing interface to OOUI & improve NoJS usability This settles almost everything, leaving the tags part ready to be further improved in the follow-ups. Also, replaced some fields with totally different ones, improved the warn preview area and improved a bit nojs experience by hiding unusable buttons. Bug: T132284 Bug: T154749 Change-Id: I7a5caa862a32f9792140c6a4d9708a2d20472672
2018-03-23 09:13:41 +00:00
"jquery.spinner",
"oojs-ui-core",
"oojs-ui-widgets"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
]
},
"ext.abuseFilter.tools": {
"scripts": "ext.abuseFilter.tools.js",
"messages": [
"abusefilter-reautoconfirm-notallowed",
"abusefilter-reautoconfirm-none",
"abusefilter-reautoconfirm-done",
"abusefilter-http-error",
Improve var dumping in /details, /examine and /tools Using var_export for better visual effect, especially for arrays. The result from /tools is much clearer and the 'wrong syntax' message is a bit more explicative than before. Bug: T190653 Bug: T239972 Change-Id: I79a17305c7f19f7900f896f895e9365bb5f2fd58
2018-03-26 18:41:20 +00:00
"abusefilter-tools-syntax-error",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"unknown-error"
],
"dependencies": [
"mediawiki.api",
Migrate 'user.tokens' dependency to 'user.options' The 'user.tokens' module is a deprecated alias to 'user.options' since MW 1.35. Bug: T235457 Change-Id: I45e8e35edf4e6f901c2045d2592326e531607726
2020-03-27 16:21:46 +00:00
"user.options",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"jquery.spinner"
]
},
"ext.abuseFilter.examine": {
"scripts": "ext.abuseFilter.examine.js",
"messages": [
"abusefilter-examine-match",
"abusefilter-examine-nomatch",
"abusefilter-examine-syntaxerror",
"abusefilter-examine-notfound",
Allow users with abusefilter-view-private to use testing interface Now the required need will be abusefilter-modify OR abusefilter-view-private for /tools, /test and /examine. Bug: T193903 Change-Id: I3f1a91a2cc1df2272e5d4099cefd7c649a0683d5
2018-05-04 19:56:45 +00:00
"abusefilter-mustviewprivateoredit",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"abusefilter-http-error",
"unknown-error"
],
"dependencies": [
"jquery.spinner",
"mediawiki.api"
]
Revert "Revert "Switch editor to Ace and provide syntax highlight"" Make Ace use a fixed size in em. This reverts commit 272775ff81f230659b678d4c514f7a8ef817d9f7. Change-Id: I9b439b20df91eb367bcef4b6f33ff087aded0b62
2018-03-30 06:55:03 +00:00
},
"ext.abuseFilter.ace": {
"scripts": "mode-abusefilter.js",
"dependencies": "ext.codeEditor.ace"
Bring in VE support from VE extension Change-Id: Ib1354f0404209a15194895026ff9d179d16b1900
2018-11-29 18:17:12 +00:00
},
"ext.abuseFilter.visualEditor": {
extension.json: Drop RL targets definitions, no longer honoured Bug: T328497 Change-Id: Ifed1146525a3b4370844144c7dafa2af0a98bd16
2024-01-12 13:38:57 +00:00
"scripts": "ve-abusefilter/ve.init.mw.AbuseFilterSaveErrorHandler.js"
Show notification when editor links to a blocked domain This leverages the new BlockedExternalDomains system that is now part of AbuseFilter. It notifies editors in realtime if a link they add is blocked. See https://w.wiki/7ZsF for more information. BlockedExternalDomains is slated to have its own API tantamount to the action=spamblacklist endpoint, after which case this code will need to be updated. In the meantime, it's meant to serve as a minimal viable product for the CWS 2023 wish <https://w.wiki/7ZsE> for wikitext users. The new $wgAbuseFilterBlockedExternalDomainsNotification configuration setting controls the availability of this feature. A similar feature for VisaulEditor is tracked at T276857 Bug: T347435 Change-Id: I7eae55f12da9ee58be5786bfc153e549b09598e7
2023-09-26 22:25:32 +00:00
},
"ext.abuseFilter.wikiEditor": {
"packageFiles": [
"wikieditor/ext.abuseFilter.wikiEditor.js"
],
"styles": [
"wikieditor/ext.abuseFilter.wikiEditor.less"
],
"dependencies": [
"mediawiki.Title",
"mediawiki.jqueryMsg",
"mediawiki.notification"
],
"messages": [
"abusefilter-blocked-domains-notif-body",
"abusefilter-blocked-domains-notif-review-link"
]
Bring in VE support from VE extension Change-Id: Ib1354f0404209a15194895026ff9d179d16b1900
2018-11-29 18:17:12 +00:00
}
},
"attributes": {
"VisualEditor": {
"PluginModules": [
"ext.abuseFilter.visualEditor"
]
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
}
},
"ResourceFileModulePaths": {
"localBasePath": "modules",
"remoteExtPath": "AbuseFilter/modules"
},
Move all "secondary" hooks away from AbuseFilterHooks Every hook that is not directly responsible for filtering an action is now moved to its own handler class. Some of these are still static methods because the respective hooks still use the old system. Bug: T261067 Change-Id: I157169f968a7d6a4d1bcfde09358e5a66a3353bf
2021-02-01 16:18:24 +00:00
"callback": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\RegistrationCallback::onRegistration",
Migrate a few hook handlers to DI Bug: T261067 Change-Id: If699917c3d2e9e22525c7d0495554e25f6b45125
2020-10-04 11:29:06 +00:00
"HookHandlers": {
"ToolLinks": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\ToolLinksHandler",
Update moved class WikiMap See T321882. Moved in I60cf4b9ef02b9d5 Bug: T321681 Change-Id: I2c9a5dbde0080984dad1a23eba52504c4b7df4d1
2023-04-25 09:52:41 +00:00
"services": [
"AbuseFilterPermissionManager"
]
Migrate change tags hooks to DI Bug: T261067 Change-Id: I7b95cd19ab0ae04820e8dcb3481d29a2f9e7a0ca
2020-10-14 14:32:55 +00:00
},
Implement GetAutoPromoteGroupsHook Test coverage included. Bug: T261067 Change-Id: Iba49f0518d2c1a72405498b2743e5ef300dd6d61
2020-12-15 16:29:02 +00:00
"AutoPromoteGroups": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\AutoPromoteGroupsHandler",
"factory": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\AutoPromoteGroupsHandler::factory",
Update moved class WikiMap See T321882. Moved in I60cf4b9ef02b9d5 Bug: T321681 Change-Id: I2c9a5dbde0080984dad1a23eba52504c4b7df4d1
2023-04-25 09:52:41 +00:00
"services": [
"AbuseFilterConsequencesRegistry",
"AbuseFilterBlockAutopromoteStore"
]
Implement GetAutoPromoteGroupsHook Test coverage included. Bug: T261067 Change-Id: Iba49f0518d2c1a72405498b2743e5ef300dd6d61
2020-12-15 16:29:02 +00:00
},
Migrate change tags hooks to DI Bug: T261067 Change-Id: I7b95cd19ab0ae04820e8dcb3481d29a2f9e7a0ca
2020-10-14 14:32:55 +00:00
"ChangeTags": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\ChangeTagsHandler",
Update moved class WikiMap See T321882. Moved in I60cf4b9ef02b9d5 Bug: T321681 Change-Id: I2c9a5dbde0080984dad1a23eba52504c4b7df4d1
2023-04-25 09:52:41 +00:00
"services": [
"AbuseFilterChangeTagsManager"
]
Add dedicated classes for more hook handlers The schema changes hook was chosen because the handler is very long. The test ones were chosen to keep test things away from actual code. Bug: T261067 Change-Id: Ie06bf62399f6353e3e268cccb3fe4b41bbf951c5
2020-10-08 17:38:52 +00:00
},
"SchemaChanges": {
Improve coverage for hooks - Exclude a couple of classes from coverage reports - Add tests for all handlers - Add tests for the runner, copied from core - Make AbuseFilterRunner a real service Change-Id: I7a0fe3cd8300faef5ef72d7f986b1734c324d8d1
2021-01-09 13:40:10 +00:00
"class": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\SchemaChangesHandler",
"factory": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\SchemaChangesHandler::newFromGlobalState"
Move all "secondary" hooks away from AbuseFilterHooks Every hook that is not directly responsible for filtering an action is now moved to its own handler class. Some of these are still static methods because the respective hooks still use the old system. Bug: T261067 Change-Id: I157169f968a7d6a4d1bcfde09358e5a66a3353bf
2021-02-01 16:18:24 +00:00
},
"UserRename": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\UserRenameHandler"
},
BlockedExternalDomains: Make this a special right, prohibit direct editing Bug: T337431 Bug: T279275 Change-Id: I96d1e2c8d8728c26e38515032ef773770e26dda4
2023-06-01 13:01:14 +00:00
"EditPermission": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\EditPermissionHandler"
},
Move all "secondary" hooks away from AbuseFilterHooks Every hook that is not directly responsible for filtering an action is now moved to its own handler class. Some of these are still static methods because the respective hooks still use the old system. Bug: T261067 Change-Id: I157169f968a7d6a4d1bcfde09358e5a66a3353bf
2021-02-01 16:18:24 +00:00
"PageSave": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\PageSaveHandler",
Update moved class WikiMap See T321882. Moved in I60cf4b9ef02b9d5 Bug: T321681 Change-Id: I2c9a5dbde0080984dad1a23eba52504c4b7df4d1
2023-04-25 09:52:41 +00:00
"services": [
"AbuseFilterEditRevUpdater"
]
Move all "secondary" hooks away from AbuseFilterHooks Every hook that is not directly responsible for filtering an action is now moved to its own handler class. Some of these are still static methods because the respective hooks still use the old system. Bug: T261067 Change-Id: I157169f968a7d6a4d1bcfde09358e5a66a3353bf
2021-02-01 16:18:24 +00:00
},
"RecentChangeSave": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\RecentChangeSaveHandler",
Update moved class WikiMap See T321882. Moved in I60cf4b9ef02b9d5 Bug: T321681 Change-Id: I2c9a5dbde0080984dad1a23eba52504c4b7df4d1
2023-04-25 09:52:41 +00:00
"services": [
"AbuseFilterChangeTagger"
]
Switch filterable actions hooks to the new system Bug: T261067 Bug: T211680 Change-Id: I0e7e4a48b56c3e5fde56f50693fd0cdc19c30dd0
2021-08-14 14:03:08 +00:00
},
"FilteredActions": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\FilteredActionsHandler",
Update moved class WikiMap See T321882. Moved in I60cf4b9ef02b9d5 Bug: T321681 Change-Id: I2c9a5dbde0080984dad1a23eba52504c4b7df4d1
2023-04-25 09:52:41 +00:00
"services": [
"StatsdDataFactory",
"AbuseFilterFilterRunnerFactory",
"AbuseFilterVariableGeneratorFactory",
Introduce Special:BlockedExternalDomains It is behind a feature flag. Improvements on it can happen in follow ups. The patch is already quite massive. Bug: T337431 Bug: T279275 Change-Id: I3df949c4d41ce65bb4afa013da9c691ac05fc760
2023-05-24 20:09:59 +00:00
"AbuseFilterEditRevUpdater",
BlockedDomains: Move filtering logic to a dedicated class I'm planning to add support for bypass and regex-based blocking which means it'll grow a bit. So let's give it a dedicated class. Bug: T337431 Change-Id: I5a6fe2fd2f1efdebd8cada0ba6c481341f830e27
2023-08-06 11:44:16 +00:00
"AbuseFilterBlockedDomainFilter",
Add abusefilter-bypass-blocked-external-domains right This is similar to sboverride right in SpamBlacklist. Defaults are also the same Bug: T337431 Change-Id: Iaff91c1f9f7aece0787348dd071701ef99e0291d
2023-06-08 19:26:33 +00:00
"PermissionManager"
Update moved class WikiMap See T321882. Moved in I60cf4b9ef02b9d5 Bug: T321681 Change-Id: I2c9a5dbde0080984dad1a23eba52504c4b7df4d1
2023-04-25 09:52:41 +00:00
]
Ensure IP, XFF and UA are valid for abuse filter user actions in CheckUser Change the IP to 127.0.0.1 (to indicate an internal IP), and blank the XFF and UA when the performer of an action being logged by CheckUser is the abuse filter user. Actions performed by the abuse filter user can only be initated by the software, and as such should not use the request's IP, XFF and UA. Also test the newly added code. Bug: T44345 Depends-On: I28acaaebd2d0067b700da0930e7b7ba924fa5c1c Change-Id: Idd77545af94f9f9930d9ff38ab6423a72e680df9
2022-11-08 19:32:30 +00:00
},
"CheckUser": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\CheckUserHandler",
Update moved class WikiMap See T321882. Moved in I60cf4b9ef02b9d5 Bug: T321681 Change-Id: I2c9a5dbde0080984dad1a23eba52504c4b7df4d1
2023-04-25 09:52:41 +00:00
"services": [
Update user type checks to handle temporary users * Set the same block expiry for temp and anon users * Don't block autopromote for temp users; they can't be autopromoted * Bail early from CheckUserHandler if the user is temporary Bug: T335062 Change-Id: I6b72537f568c4c70a0b86f1825ea30b767f5634a
2023-04-24 13:37:53 +00:00
"AbuseFilterFilterUser",
Replace userNameUtils with UserIdentityUtils Where UserIdentity is available and where it's necessary to check ::isNamed Bug: T342741 Change-Id: I5b52686f1c072282e76874f3863962345ca8097e
2023-07-26 14:22:30 +00:00
"UserIdentityUtils"
Update moved class WikiMap See T321882. Moved in I60cf4b9ef02b9d5 Bug: T321681 Change-Id: I2c9a5dbde0080984dad1a23eba52504c4b7df4d1
2023-04-25 09:52:41 +00:00
]
Use HookHandlers for Echo hook Bug: T254306 Depends-On: Iffa2b409502b4269c9746e0304feb4aaee37a86e Change-Id: I0e27c535367b37b7038a54955e43ff96d9c81d32
2023-08-15 22:18:02 +00:00
},
"Echo": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\EchoHandler"
Use HookHandlers for UserMerge hook Bug: T254306 Depends-On: Ib78dae49854863af1a37a00636737c94694776ae Change-Id: If2bc517fb612199f4d744efbfa261ee5c556b6a5
2023-08-15 21:29:46 +00:00
},
"UserMerge": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\UserMergeHandler",
"services": [
"MainConfig"
]
Show notification when editor links to a blocked domain This leverages the new BlockedExternalDomains system that is now part of AbuseFilter. It notifies editors in realtime if a link they add is blocked. See https://w.wiki/7ZsF for more information. BlockedExternalDomains is slated to have its own API tantamount to the action=spamblacklist endpoint, after which case this code will need to be updated. In the meantime, it's meant to serve as a minimal viable product for the CWS 2023 wish <https://w.wiki/7ZsE> for wikitext users. The new $wgAbuseFilterBlockedExternalDomainsNotification configuration setting controls the availability of this feature. A similar feature for VisaulEditor is tracked at T276857 Bug: T347435 Change-Id: I7eae55f12da9ee58be5786bfc153e549b09598e7
2023-09-26 22:25:32 +00:00
},
"EditPage": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\EditPageHandler",
"services": [
"MainConfig"
],
"optional_services": [
"MobileFrontend.Context"
]
Migrate a few hook handlers to DI Bug: T261067 Change-Id: If699917c3d2e9e22525c7d0495554e25f6b45125
2020-10-04 11:29:06 +00:00
}
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"Hooks": {
Switch filterable actions hooks to the new system Bug: T261067 Bug: T211680 Change-Id: I0e7e4a48b56c3e5fde56f50693fd0cdc19c30dd0
2021-08-14 14:03:08 +00:00
"EditFilterMergedContent": "FilteredActions",
Implement GetAutoPromoteGroupsHook Test coverage included. Bug: T261067 Change-Id: Iba49f0518d2c1a72405498b2743e5ef300dd6d61
2020-12-15 16:29:02 +00:00
"GetAutoPromoteGroups": "AutoPromoteGroups",
Switch filterable actions hooks to the new system Bug: T261067 Bug: T211680 Change-Id: I0e7e4a48b56c3e5fde56f50693fd0cdc19c30dd0
2021-08-14 14:03:08 +00:00
"TitleMove": "FilteredActions",
"ArticleDelete": "FilteredActions",
Move all "secondary" hooks away from AbuseFilterHooks Every hook that is not directly responsible for filtering an action is now moved to its own handler class. Some of these are still static methods because the respective hooks still use the old system. Bug: T261067 Change-Id: I157169f968a7d6a4d1bcfde09358e5a66a3353bf
2021-02-01 16:18:24 +00:00
"RecentChange_save": "RecentChangeSave",
Migrate change tags hooks to DI Bug: T261067 Change-Id: I7b95cd19ab0ae04820e8dcb3481d29a2f9e7a0ca
2020-10-14 14:32:55 +00:00
"ListDefinedTags": "ChangeTags",
"ChangeTagsListActive": "ChangeTags",
Add dedicated classes for more hook handlers The schema changes hook was chosen because the handler is very long. The test ones were chosen to keep test things away from actual code. Bug: T261067 Change-Id: Ie06bf62399f6353e3e268cccb3fe4b41bbf951c5
2020-10-08 17:38:52 +00:00
"LoadExtensionSchemaUpdates": "SchemaChanges",
Migrate a few hook handlers to DI Bug: T261067 Change-Id: If699917c3d2e9e22525c7d0495554e25f6b45125
2020-10-04 11:29:06 +00:00
"ContributionsToolLinks": "ToolLinks",
"HistoryPageToolLinks": "ToolLinks",
"UndeletePageToolLinks": "ToolLinks",
Switch filterable actions hooks to the new system Bug: T261067 Bug: T211680 Change-Id: I0e7e4a48b56c3e5fde56f50693fd0cdc19c30dd0
2021-08-14 14:03:08 +00:00
"UploadVerifyUpload": "FilteredActions",
"UploadStashFile": "FilteredActions",
Move all "secondary" hooks away from AbuseFilterHooks Every hook that is not directly responsible for filtering an action is now moved to its own handler class. Some of these are still static methods because the respective hooks still use the old system. Bug: T261067 Change-Id: I157169f968a7d6a4d1bcfde09358e5a66a3353bf
2021-02-01 16:18:24 +00:00
"PageSaveComplete": "PageSave",
"RenameUserSQL": "UserRename",
BlockedExternalDomains: Make this a special right, prohibit direct editing Bug: T337431 Bug: T279275 Change-Id: I96d1e2c8d8728c26e38515032ef773770e26dda4
2023-06-01 13:01:14 +00:00
"getUserPermissionsErrors": "EditPermission",
Ensure IP, XFF and UA are valid for abuse filter user actions in CheckUser Change the IP to 127.0.0.1 (to indicate an internal IP), and blank the XFF and UA when the performer of an action being logged by CheckUser is the abuse filter user. Actions performed by the abuse filter user can only be initated by the software, and as such should not use the request's IP, XFF and UA. Also test the newly added code. Bug: T44345 Depends-On: I28acaaebd2d0067b700da0930e7b7ba924fa5c1c Change-Id: Idd77545af94f9f9930d9ff38ab6423a72e680df9
2022-11-08 19:32:30 +00:00
"CheckUserInsertChangesRow": "CheckUser",
Add missing CheckUser hooks to extension.json which have handlers Add the CheckUser hooks CheckUserInsertPrivateEventRow and CheckUserInsertLogEventRow to extension.json which were both added to the CheckUser CheckUserHandler, but mistakenly not added to extension.json in 8e4a1237f142f052ec2968e456a9b4022084bb71. Bug: T324907 Follow-Up: Id78417e9d95220946f110afbe1430df5b3bb4f4f Change-Id: I7a53f1933a0dafa66973a773a551c497b2eb5b05
2023-04-22 18:22:08 +00:00
"CheckUserInsertPrivateEventRow": "CheckUser",
"CheckUserInsertLogEventRow": "CheckUser",
Use HookHandlers for UserMerge hook Bug: T254306 Depends-On: Ib78dae49854863af1a37a00636737c94694776ae Change-Id: If2bc517fb612199f4d744efbfa261ee5c556b6a5
2023-08-15 21:29:46 +00:00
"UserMergeAccountFields": "UserMerge",
Use HookHandlers for Echo hook Bug: T254306 Depends-On: Iffa2b409502b4269c9746e0304feb4aaee37a86e Change-Id: I0e27c535367b37b7038a54955e43ff96d9c81d32
2023-08-15 22:18:02 +00:00
"BeforeCreateEchoEvent": "Echo",
Switch filterable actions hooks to the new system Bug: T261067 Bug: T211680 Change-Id: I0e7e4a48b56c3e5fde56f50693fd0cdc19c30dd0
2021-08-14 14:03:08 +00:00
"ParserOutputStashForEdit": "FilteredActions",
Show notification when editor links to a blocked domain This leverages the new BlockedExternalDomains system that is now part of AbuseFilter. It notifies editors in realtime if a link they add is blocked. See https://w.wiki/7ZsF for more information. BlockedExternalDomains is slated to have its own API tantamount to the action=spamblacklist endpoint, after which case this code will need to be updated. In the meantime, it's meant to serve as a minimal viable product for the CWS 2023 wish <https://w.wiki/7ZsE> for wikitext users. The new $wgAbuseFilterBlockedExternalDomainsNotification configuration setting controls the availability of this feature. A similar feature for VisaulEditor is tracked at T276857 Bug: T347435 Change-Id: I7eae55f12da9ee58be5786bfc153e549b09598e7
2023-09-26 22:25:32 +00:00
"JsonValidateSave": "EditPermission",
"EditPage::showEditForm:initial": "EditPage"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
Introduce a KeywordsManager service This will decouple a bit the huge and chaotic tangle of AF classes. Some boilerplate code for AbuseFilter services is also added with this patch. Note that this requires injecting a KeywordsManager in AbuseFilterVariableHolder, or unit tests would fail. This is still incomplete, and the Manager is only injected in tests, because VariableHolder still has to be refactored. The test for the UpdateVarDumps script had to be updated, because serializing VHs in there was a bad choice. As pointed out in a comment, the test is likely going to break again once we remove the BC code, but I hope that we'll be able to remove the test at that point. Change-Id: I12a656a310adb8c5f75cab63f6db9e121e109717
2020-01-15 16:08:53 +00:00
"ServiceWiringFiles": [
"includes/ServiceWiring.php"
],
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"config": {
Change some globals to work better with extension registration Rename $wgAbuseFilterAvailableActions / $wgAbuseFilterRestrictedActions to $wgAbuseFilterActions / $wgAbuseFilterRestrictions and make them an associative array instead of a plain one, as that works more sanely with extension registration. (The renaming helps to give more useful errors to sites using the old config.) Change-Id: I790d39c2849922d7daf7479f298cd90cf30af129
2016-06-03 18:01:56 +00:00
"AbuseFilterActions": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"throttle": true,
"warn": true,
"disallow": true,
"blockautopromote": true,
"block": true,
"rangeblock": false,
Rearrange config to provide better experience In order to bundle AbuseFilter, we have to provide an optimal configuration for sysadmins. This patch aims to provide such configuration, and of course it's open to changes. Changed values: *Grant abusefilter-view-private to admins. This is mostly for redundancy-safety (they already have -modify) *Grant modify-restricted to admins (see T200032) *Disable the 'degroup' action. This is really dangerous, not ideal to be enabled by default. *Grant the abusefilter-revert right to sysops. This is similar to assigning the modify-restricted right in its rationale. *Add abusefilter-log-private to viewrestrictedlogs grant. This right should go together with abusefilter-view-private. (T226987) *Remove abusefilter-revert from the rollback grant, as that right is for reverting AF actions and has nothing to do with rollbacks. This mostly copies the config of WMF production: degrouping is already disabled there, and modify-restricted should be assigned to sysops on WMF wikis as well. The assignment of the abusefilter-view-private and abusefiliter-revert rights is handled in I09cb462312c5bbc71ee3a8f0fbd91357908130d4 (parent patch) to keep the status quo. NOTE: this patch should be *deployed* together with the config patch to avoid discontinuities. Thus, please ONLY provide a virtual +2 using a +1, and I'll coordinate the +2 with a deployer. Bug: T191740 Bug: T200032 Bug: T226987 Depends-On: I09cb462312c5bbc71ee3a8f0fbd91357908130d4 Change-Id: I58f215b8aa3444602532098a3c9dfd25409f29eb
2018-10-20 10:24:53 +00:00
"degroup": false,
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"tag": true
},
"description": "Array of enabled actions in the form [action name => is enabled?]. At the end of setup, false values will be filtered out"
},
"AbuseFilterConditionLimit": {
"value": 1000,
"description": "The maximum number of 'conditions' that can be used each time the filters are run against a change. (More complex filters require more 'conditions')."
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"AbuseFilterEmergencyDisableThreshold": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"default": 0.05
},
Update description of AbuseFilterEmergencyDisableThreshold The emergency disable feature does not depend on profiling data anymore since b8ac52c. Change-Id: Ibf3282f13c23e6b3d95cfd156132253d56afb28a
2022-01-24 12:36:24 +00:00
"description": "Disable potentially dangerous actions (AbuseFilterRestrictions) of a filter if it matches more than X actions, constituting more than Y% (e.g. 0.05 = 5%) of the last Z actions, and the filter has been modified in the last S seconds. X is AbuseFilterEmergencyDisableCount, Y is AbuseFilterEmergencyDisableThreshold, S is AbuseFilterEmergencyDisableAge and Z is the number of analyzed actions since the filter was modified."
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"AbuseFilterEmergencyDisableCount": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"default": 2
},
"description": "See description for AbuseFilterEmergencyDisableThreshold"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"AbuseFilterEmergencyDisableAge": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"default": 86400
},
"description": "See description for AbuseFilterEmergencyDisableThreshold"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
Replace $wgAbuseFilterRestrictions with more specific variables So that sysadmins can further customize the extension. It was also wrong to use the same variable for many different things. Note that there's no associated patch in wmf-config because we use the defaults. However, before merging this patch, please recheck that AbuseFilterRestrictions and AbuseFilterDisallowGlobalLocalBlocks aren't used there (https://codesearch.wmflabs.org/operations/?q=AbuseFilterDisallowGlobalLocalBlocks%7CAbuseFilterRestrictions&i=nope&files=&repos=) Bug: T175221 Change-Id: I7581b3ee6d9d11a6cf1599b8ff874e8c3d54adf4
2018-09-22 10:18:50 +00:00
"AbuseFilterActionRestrictions": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"throttle": false,
"warn": false,
"disallow": false,
"blockautopromote": true,
"block": true,
"rangeblock": true,
"degroup": true,
"tag": false
},
build: Upgrade eslint-config-wikimedia from 0.17.0 to 0.18.0 and make pass Change-Id: I2053ee5521434bc04a28b137eb3745e2c6f3c06a
2021-01-25 18:10:44 +00:00
"description": "Do users need 'abusefilter-modify-restricted' user right as well as 'abusefilter-modify' in order to create or modify filters which carry out this action? Array like [action name => is restricted?]"
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
},
"AbuseFilterNotifications": {
"value": false,
"description": "Allows to configure the extension to send hit notifications to Special:RecentChanges or UDP. Available options: rc, udp, rcandudp"
},
"AbuseFilterNotificationsPrivate": {
"value": false,
"description": "Enable notifications for private filters"
},
"AbuseFilterCentralDB": {
"value": null,
Add tests for global filters Another crucial part to have covered. Also clarify that AbuseFilterCentralDB can be of the form "dbname-prefix". Remove a filter used for profiling and replace it with a global one: we're still fine, and the list is kept shorter. Bug: T201193 Depends-On: I5ee7ba44a6cd82a5ddb24fb4127af04d96e647f4 Change-Id: If6b91711534c0d60e1aa27bd5748c3023e29f376
2018-08-25 12:44:01 +00:00
"description": "Name of a database where global abuse filters will be stored in. To use a DB with prefixed tables, set this to \"{$databaseName}-{$prefix}\"."
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
},
"AbuseFilterIsCentral": {
"value": false,
"description": "Set this variable to true for the wiki where global AbuseFilters are stored in"
},
Replace $wgAbuseFilterRestrictions with more specific variables So that sysadmins can further customize the extension. It was also wrong to use the same variable for many different things. Note that there's no associated patch in wmf-config because we use the defaults. However, before merging this patch, please recheck that AbuseFilterRestrictions and AbuseFilterDisallowGlobalLocalBlocks aren't used there (https://codesearch.wmflabs.org/operations/?q=AbuseFilterDisallowGlobalLocalBlocks%7CAbuseFilterRestrictions&i=nope&files=&repos=) Bug: T175221 Change-Id: I7581b3ee6d9d11a6cf1599b8ff874e8c3d54adf4
2018-09-22 10:18:50 +00:00
"AbuseFilterLocallyDisabledGlobalActions": {
"value": {
"throttle": false,
"warn": false,
"disallow": false,
"blockautopromote": false,
"block": false,
"rangeblock": false,
"degroup": false,
"tag": false
},
build: Upgrade eslint-config-wikimedia from 0.17.0 to 0.18.0 and make pass Change-Id: I2053ee5521434bc04a28b137eb3745e2c6f3c06a
2021-01-25 18:10:44 +00:00
"description": "An array of actions which, if set on a global filter, will not be used for local hits of such filter (not in the central wiki). The array is [ action => will be disabled? ]. NOTE: Locally disabling throttle or warn will *not* disable the remaining actions."
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
},
"AbuseFilterBlockDuration": {
"value": "indefinite",
"description": "Old standard block duration for logged in users. Kept for backward compatibility after T32024."
},
"AbuseFilterAnonBlockDuration": {
"value": null,
"description": "Old standard block duration for anonymous users, $wgAbuseFilterBlockDuration will be used if null. Kept for backward compatibility after T32024."
},
Allow Blockautopromote duration to be configured for wikis. Rather than always using 5 days, the length (in days) can be configured by setting `AbuseFilterBlockAutopromoteDuration` to the desired length. Bug: T231756 Change-Id: I996e08a9099ab59657fe511ec2934d26edfa5c7b
2019-09-15 04:09:02 +00:00
"AbuseFilterBlockAutopromoteDuration": {
"value": 5,
"description": "Duration, in days, for which users' autopromotion is blocked by filters."
},
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"AbuseFilterValidGroups": {
Update moved class WikiMap See T321882. Moved in I60cf4b9ef02b9d5 Bug: T321681 Change-Id: I2c9a5dbde0080984dad1a23eba52504c4b7df4d1
2023-04-25 09:52:41 +00:00
"value": [
"default"
],
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"description": "The list of 'groups' filters can be divided into – used for applying edit filters to certain types of actions. By default there is only one group."
Change some globals to work better with extension registration Rename $wgAbuseFilterAvailableActions / $wgAbuseFilterRestrictedActions to $wgAbuseFilterActions / $wgAbuseFilterRestrictions and make them an associative array instead of a plain one, as that works more sanely with extension registration. (The renaming helps to give more useful errors to sites using the old config.) Change-Id: I790d39c2849922d7daf7479f298cd90cf30af129
2016-06-03 18:01:56 +00:00
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"AbuseFilterDefaultWarningMessage": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"default": "abusefilter-warning"
},
"description": "Default warning messages, per filter group"
},
Allow selecting custom disallow message You can now select a custom message to be displayed for disallowing a edit the same way as for warn mode. This can be the same or a totally different message. This also solves the usecase, when a edit filter is set to warn AND disallow, to be able to show the user a custom message, but the generic is shown on the second try (disallow). Now it can be only set to disallow. Bug: T27086 Change-Id: Ic1de03a6944c43a346fa317ee0a217551f0d284a
2014-10-04 14:42:46 +00:00
"AbuseFilterDefaultDisallowMessage": {
"value": {
"default": "abusefilter-disallowed"
},
Remove incorrect merge_strategy definitions Those merge strategies aren't needed because array_plus is for when the keys of the array are integers, not necessarily the values. Change-Id: I164723c4cc6b12cd6e4ce0d49c74d93eda5d871d
2020-05-12 19:48:36 +00:00
"description": "Default disallow messages, per filter group"
Allow selecting custom disallow message You can now select a custom message to be displayed for disallowing a edit the same way as for warn mode. This can be the same or a totally different message. This also solves the usecase, when a edit filter is set to warn AND disallow, to be able to show the user a custom message, but the generic is shown on the second try (disallow). Now it can be only set to disallow. Bug: T27086 Change-Id: Ic1de03a6944c43a346fa317ee0a217551f0d284a
2014-10-04 14:42:46 +00:00
},
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"AbuseFilterLogIPMaxAge": {
"value": 7776000,
"description": "Age used as cutoff when purging old IP log data, defaults to 3 months. Used by maintenance script purgeOldLogIPData.php"
},
"AbuseFilterSlowFilterRuntimeLimit": {
"value": 500,
"description": "Runtime in milliseconds before a filter is considered slow."
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
Overhaul Blockautopromote action As for all mostly unused consequences, blockautopromote has a couple of major problems: first, it blocked the status for a random time between 3 and 7 days, which to me makes no sense at all (is it some sort of casino?), and this patch fixes it to 5 days. Second, nothing was logged, not the blocking nor the unblocking. Here I'm adding a LogHandler for two new sub-actions of 'rights' to keep track of both action. Bug: T49412 Change-Id: If48a48f5b8baaf9e77c0826466f5d03bb7f691d0
2018-07-16 12:10:36 +00:00
"AbuseFilterRangeBlockSize": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"IPv4": 16,
"IPv6": 19
},
"description": "Size of the range blocked by 'rangeblock' action."
},
Use "privatedetails" instead of "private" where needed To keep a clear distinction between "private details" (i.e. user's ip) and "private filters" (i.e. not publicly viewable). This patch renames rights, i18n keys and methods names. The patch for renaming globals and rights in WMF config is I7e6b3d4453403edb6aa602587374b4ff5b6d625f. Bug: T211004 Change-Id: I613dbadb8f75c8c4116a362607563a436a73d321
2019-01-07 15:23:21 +00:00
"AbuseFilterLogPrivateDetailsAccess": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": false,
Fix extension doc for AbuseFilterPrivateLog This variable is actually here to determine whether accessing private info should be logged, not if it's possible to access such info. In fact, you can still do it if this variable is set to false. Change-Id: Ieba191bff4ea56eb166bbbd03cb7b1a05ca42c52
2018-07-16 13:32:38 +00:00
"description": "Whether accessing private information from a filter log entry is logged."
Log accessing private information in abuse filter logs Bug: T152934 Change-Id: I8049df3b2b9343a6877e9a306d2781d3f27ec657
2016-12-12 16:30:06 +00:00
},
Use "privatedetails" instead of "private" where needed To keep a clear distinction between "private details" (i.e. user's ip) and "private filters" (i.e. not publicly viewable). This patch renames rights, i18n keys and methods names. The patch for renaming globals and rights in WMF config is I7e6b3d4453403edb6aa602587374b4ff5b6d625f. Bug: T211004 Change-Id: I613dbadb8f75c8c4116a362607563a436a73d321
2019-01-07 15:23:21 +00:00
"AbuseFilterPrivateDetailsForceReason": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": false,
"description": "Whether users are forced to provide a reason for accessing private information from a filter log entry."
},
"AbuseFilterLogIP": {
"value": true,
"description": "Whether to include IP in the abuse_filter_log"
Use actor table in AbuseFilter This patch migrates abuse_filter and abuse_filter_history tables to new actor schema. MigrateActorsAF was copy-pasted from core's maintenance/includes/MigrateActors.php before removal (ba3155214). Bug: T188180 Change-Id: Ic755526d5f989c4a66b1d37527cda235f61cb437
2018-03-08 21:16:25 +00:00
},
"AbuseFilterActorTableSchemaMigrationStage": {
"value": 3,
Drop obsolete reference from config description The other migration was done meanwhile. Change-Id: I7f3867dfa746ace26836677a7cbc2b4d9cf1d314 Follows-Up: Ic755526d5f989c4a66b1d37527cda235f61cb437
2023-03-29 07:45:12 +00:00
"description": "Stage of the migration of af_user/af_user_text to af_actor and afh_user/afh_user_text to afh_actor. Should be one of the following (combinations of) constants: SCHEMA_COMPAT_OLD, SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_OLD, SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_NEW, SCHEMA_COMPAT_NEW. See also \"Schema compatibility flags\" in includes/Defines.php in core. Note: When changing the default here, change it also in unit tests."
Introduce Special:BlockedExternalDomains It is behind a feature flag. Improvements on it can happen in follow ups. The patch is already quite massive. Bug: T337431 Bug: T279275 Change-Id: I3df949c4d41ce65bb4afa013da9c691ac05fc760
2023-05-24 20:09:59 +00:00
},
"AbuseFilterEnableBlockedExternalDomain": {
"value": false,
"description": "Temporary config value to disable Special:BlockedExternalDomains"
Show notification when editor links to a blocked domain This leverages the new BlockedExternalDomains system that is now part of AbuseFilter. It notifies editors in realtime if a link they add is blocked. See https://w.wiki/7ZsF for more information. BlockedExternalDomains is slated to have its own API tantamount to the action=spamblacklist endpoint, after which case this code will need to be updated. In the meantime, it's meant to serve as a minimal viable product for the CWS 2023 wish <https://w.wiki/7ZsE> for wikitext users. The new $wgAbuseFilterBlockedExternalDomainsNotification configuration setting controls the availability of this feature. A similar feature for VisaulEditor is tracked at T276857 Bug: T347435 Change-Id: I7eae55f12da9ee58be5786bfc153e549b09598e7
2023-09-26 22:25:32 +00:00
},
"AbuseFilterBlockedExternalDomainsNotifications": {
"value": false,
"description": "Feature flag to enable realtime notifications when an editor types a link to a blocked external domain."
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
}
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"load_composer_autoloader": true,
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"manifest_version": 2
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
}
Reference in a new issue Copy permalink