mediawiki-extensions-AbuseF.../includes/Variables/UnsetVariableException.php

<?php

namespace MediaWiki\Extension\AbuseFilter\Variables;

use RuntimeException;

/**
 * @codeCoverageIgnore
 */
class UnsetVariableException extends RuntimeException {
	/**
	 * @param string $varName
	 */
	public function __construct( string $varName ) {
		parent::__construct( "Variable $varName is not set" );
	}
}
Create a VariablesManager service This makes VariableHolder a true value object, and introduces a stateless service, VariableManager, to operate on it. Note, in theory, this new service is still cyclically coupled with LazyVariableComputed. However, it's now two stateless service being coupled, not two smart/god value objects, so we've still earned something. For now, the dependency is hidden by using a callback. Some alternatives for that are mentioned in a code comment. Bug: T261069 Change-Id: I2f2c84c8e91472ba36084a8bbb4a923f6e04354b 2020-10-18 22:25:05 +00:00			`<?php`

Create a dedicated namespace for variables-related classes Some cleanup is left for later to keep the diff easier to read. Change-Id: Ife445b5e47e707ab77ec867ac3b005866aa74ef2 2021-01-02 13:41:31 +00:00			`namespace MediaWiki\Extension\AbuseFilter\Variables;`
Create a VariablesManager service This makes VariableHolder a true value object, and introduces a stateless service, VariableManager, to operate on it. Note, in theory, this new service is still cyclically coupled with LazyVariableComputed. However, it's now two stateless service being coupled, not two smart/god value objects, so we've still earned something. For now, the dependency is hidden by using a callback. Some alternatives for that are mentioned in a code comment. Bug: T261069 Change-Id: I2f2c84c8e91472ba36084a8bbb4a923f6e04354b 2020-10-18 22:25:05 +00:00
			`use RuntimeException;`

Create a dedicated namespace for variables-related classes Some cleanup is left for later to keep the diff easier to read. Change-Id: Ife445b5e47e707ab77ec867ac3b005866aa74ef2 2021-01-02 13:41:31 +00:00			`/**`
			`* @codeCoverageIgnore`
			`*/`
Create a VariablesManager service This makes VariableHolder a true value object, and introduces a stateless service, VariableManager, to operate on it. Note, in theory, this new service is still cyclically coupled with LazyVariableComputed. However, it's now two stateless service being coupled, not two smart/god value objects, so we've still earned something. For now, the dependency is hidden by using a callback. Some alternatives for that are mentioned in a code comment. Bug: T261069 Change-Id: I2f2c84c8e91472ba36084a8bbb4a923f6e04354b 2020-10-18 22:25:05 +00:00			`class UnsetVariableException extends RuntimeException {`
			`/**`
			`* @param string $varName`
			`*/`
			`public function __construct( string $varName ) {`
			`parent::__construct( "Variable $varName is not set" );`
			`}`
			`}`