wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-11-28 07:50:24 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-AbuseF.../extension.json

481 lines
19 KiB
JSON
Raw Normal View History

Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
{
"name": "Abuse Filter",
"author": [
"Andrew Garrett",
Add `Daimona Eaytoy` to authors Daimona has been an extraordinary maintainer of this tool and has also implemented new features on Abuse Filter, so I guess it is just and fair to include his name to this list. Hyperlink is because `Daimona Eaytoy` is not a real name, according to his mediawiki.org userpage (can be removed if required; the law accepts authorship attributed to pseudonyms). In addition, the list of authors has been sorted alphabetically by name. If you prefer to order it by family name instead, please let me know. Change-Id: I6a3b0a757f9fd2af09358298e55a8b0487ce5b32
2019-07-04 10:22:20 +00:00
"[https://www.mediawiki.org/wiki/User:Daimona_Eaytoy Daimona Eaytoy]",
"Marius Hoch",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"River Tarnell",
Add `Daimona Eaytoy` to authors Daimona has been an extraordinary maintainer of this tool and has also implemented new features on Abuse Filter, so I guess it is just and fair to include his name to this list. Hyperlink is because `Daimona Eaytoy` is not a real name, according to his mediawiki.org userpage (can be removed if required; the law accepts authorship attributed to pseudonyms). In addition, the list of authors has been sorted alphabetically by name. If you prefer to order it by family name instead, please let me know. Change-Id: I6a3b0a757f9fd2af09358298e55a8b0487ce5b32
2019-07-04 10:22:20 +00:00
"Victor Vasiliev"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
],
"url": "https://www.mediawiki.org/wiki/Extension:AbuseFilter",
"descriptionmsg": "abusefilter-desc",
Use SPDX 3.0 license identifier SPDX released version 3 of their license list (<https://spdx.org/licenses/>), which changed the FSF licenses to explicitly end in -only or -or-later instead of relying on an easy to miss + symbol. Bug: T183858 Change-Id: Ib7a48d3a432f12ce1c27fe989e85a80335a25801
2018-01-04 03:01:35 +00:00
"license-name": "GPL-2.0-or-later",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"type": "antispam",
"requires": {
Use new services in AbuseFilterRunner The first one is UserGroupManager, used for the 'degroup' action. This is a simple one-line replacement (repeated twice), and the current code was already using this service under the hood. The second one is BlockUser, which is not a one-line change (but still quite simple). In particular, this allows us to avoid duplication with core logic when constructing the log entry (this is now done by BlockUser). Bug: T248743 Change-Id: Ib7c1dc107a169b575f7021e64b6a8fee09529548
2020-10-11 21:35:13 +00:00
"MediaWiki": ">= 1.36.0"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"AvailableRights": [
"abusefilter-modify",
"abusefilter-log-detail",
"abusefilter-view",
"abusefilter-log",
Use "privatedetails" instead of "private" where needed To keep a clear distinction between "private details" (i.e. user's ip) and "private filters" (i.e. not publicly viewable). This patch renames rights, i18n keys and methods names. The patch for renaming globals and rights in WMF config is I7e6b3d4453403edb6aa602587374b4ff5b6d625f. Bug: T211004 Change-Id: I613dbadb8f75c8c4116a362607563a436a73d321
2019-01-07 15:23:21 +00:00
"abusefilter-privatedetails",
"abusefilter-privatedetails-log",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"abusefilter-modify-restricted",
"abusefilter-revert",
"abusefilter-view-private",
"abusefilter-log-private",
"abusefilter-hidden-log",
"abusefilter-hide-log",
"abusefilter-modify-global"
],
Add default rights config Add a conservative default configuration so that admins can use abuse filters without any need for manual setup, and users can see what's happening. Also expand grants a bit. Bug: T191740 Change-Id: I4e3125a708277474f416903928397db7f8fb850d
2018-04-08 17:46:18 +00:00
"GroupPermissions": {
"*": {
"abusefilter-view": true,
"abusefilter-log": true
},
"sysop": {
"abusefilter-log-detail": true,
Rearrange config to provide better experience In order to bundle AbuseFilter, we have to provide an optimal configuration for sysadmins. This patch aims to provide such configuration, and of course it's open to changes. Changed values: *Grant abusefilter-view-private to admins. This is mostly for redundancy-safety (they already have -modify) *Grant modify-restricted to admins (see T200032) *Disable the 'degroup' action. This is really dangerous, not ideal to be enabled by default. *Grant the abusefilter-revert right to sysops. This is similar to assigning the modify-restricted right in its rationale. *Add abusefilter-log-private to viewrestrictedlogs grant. This right should go together with abusefilter-view-private. (T226987) *Remove abusefilter-revert from the rollback grant, as that right is for reverting AF actions and has nothing to do with rollbacks. This mostly copies the config of WMF production: degrouping is already disabled there, and modify-restricted should be assigned to sysops on WMF wikis as well. The assignment of the abusefilter-view-private and abusefiliter-revert rights is handled in I09cb462312c5bbc71ee3a8f0fbd91357908130d4 (parent patch) to keep the status quo. NOTE: this patch should be *deployed* together with the config patch to avoid discontinuities. Thus, please ONLY provide a virtual +2 using a +1, and I'll coordinate the +2 with a deployer. Bug: T191740 Bug: T200032 Bug: T226987 Depends-On: I09cb462312c5bbc71ee3a8f0fbd91357908130d4 Change-Id: I58f215b8aa3444602532098a3c9dfd25409f29eb
2018-10-20 10:24:53 +00:00
"abusefilter-view-private": true,
"abusefilter-log-private": true,
"abusefilter-modify": true,
"abusefilter-modify-restricted": true,
"abusefilter-revert": true
},
"suppress": {
"abusefilter-hidden-log": true,
"abusefilter-hide-log": true
Add default rights config Add a conservative default configuration so that admins can use abuse filters without any need for manual setup, and users can see what's happening. Also expand grants a bit. Bug: T191740 Change-Id: I4e3125a708277474f416903928397db7f8fb850d
2018-04-08 17:46:18 +00:00
}
},
"GrantPermissions": {
"basic": {
"abusefilter-log": true,
add grant to view private abusefilter log entries Bug: T191703 Change-Id: I56233786ddaa6c44e6778b56070cf9b13df20dcc
2018-04-07 19:45:28 +00:00
"abusefilter-log-detail": true,
"abusefilter-view": true
Add default rights config Add a conservative default configuration so that admins can use abuse filters without any need for manual setup, and users can see what's happening. Also expand grants a bit. Bug: T191740 Change-Id: I4e3125a708277474f416903928397db7f8fb850d
2018-04-08 17:46:18 +00:00
},
Rearrange config to provide better experience In order to bundle AbuseFilter, we have to provide an optimal configuration for sysadmins. This patch aims to provide such configuration, and of course it's open to changes. Changed values: *Grant abusefilter-view-private to admins. This is mostly for redundancy-safety (they already have -modify) *Grant modify-restricted to admins (see T200032) *Disable the 'degroup' action. This is really dangerous, not ideal to be enabled by default. *Grant the abusefilter-revert right to sysops. This is similar to assigning the modify-restricted right in its rationale. *Add abusefilter-log-private to viewrestrictedlogs grant. This right should go together with abusefilter-view-private. (T226987) *Remove abusefilter-revert from the rollback grant, as that right is for reverting AF actions and has nothing to do with rollbacks. This mostly copies the config of WMF production: degrouping is already disabled there, and modify-restricted should be assigned to sysops on WMF wikis as well. The assignment of the abusefilter-view-private and abusefiliter-revert rights is handled in I09cb462312c5bbc71ee3a8f0fbd91357908130d4 (parent patch) to keep the status quo. NOTE: this patch should be *deployed* together with the config patch to avoid discontinuities. Thus, please ONLY provide a virtual +2 using a +1, and I'll coordinate the +2 with a deployer. Bug: T191740 Bug: T200032 Bug: T226987 Depends-On: I09cb462312c5bbc71ee3a8f0fbd91357908130d4 Change-Id: I58f215b8aa3444602532098a3c9dfd25409f29eb
2018-10-20 10:24:53 +00:00
"oversight": {
"abusefilter-hide-log": true
Add default rights config Add a conservative default configuration so that admins can use abuse filters without any need for manual setup, and users can see what's happening. Also expand grants a bit. Bug: T191740 Change-Id: I4e3125a708277474f416903928397db7f8fb850d
2018-04-08 17:46:18 +00:00
},
"viewrestrictedlogs": {
add grant to view private abusefilter log entries Bug: T191703 Change-Id: I56233786ddaa6c44e6778b56070cf9b13df20dcc
2018-04-07 19:45:28 +00:00
"abusefilter-hidden-log": true,
Rearrange config to provide better experience In order to bundle AbuseFilter, we have to provide an optimal configuration for sysadmins. This patch aims to provide such configuration, and of course it's open to changes. Changed values: *Grant abusefilter-view-private to admins. This is mostly for redundancy-safety (they already have -modify) *Grant modify-restricted to admins (see T200032) *Disable the 'degroup' action. This is really dangerous, not ideal to be enabled by default. *Grant the abusefilter-revert right to sysops. This is similar to assigning the modify-restricted right in its rationale. *Add abusefilter-log-private to viewrestrictedlogs grant. This right should go together with abusefilter-view-private. (T226987) *Remove abusefilter-revert from the rollback grant, as that right is for reverting AF actions and has nothing to do with rollbacks. This mostly copies the config of WMF production: degrouping is already disabled there, and modify-restricted should be assigned to sysops on WMF wikis as well. The assignment of the abusefilter-view-private and abusefiliter-revert rights is handled in I09cb462312c5bbc71ee3a8f0fbd91357908130d4 (parent patch) to keep the status quo. NOTE: this patch should be *deployed* together with the config patch to avoid discontinuities. Thus, please ONLY provide a virtual +2 using a +1, and I'll coordinate the +2 with a deployer. Bug: T191740 Bug: T200032 Bug: T226987 Depends-On: I09cb462312c5bbc71ee3a8f0fbd91357908130d4 Change-Id: I58f215b8aa3444602532098a3c9dfd25409f29eb
2018-10-20 10:24:53 +00:00
"abusefilter-log-private": true,
add grant to view private abusefilter log entries Bug: T191703 Change-Id: I56233786ddaa6c44e6778b56070cf9b13df20dcc
2018-04-07 19:45:28 +00:00
"abusefilter-view-private": true
Add default rights config Add a conservative default configuration so that admins can use abuse filters without any need for manual setup, and users can see what's happening. Also expand grants a bit. Bug: T191740 Change-Id: I4e3125a708277474f416903928397db7f8fb850d
2018-04-08 17:46:18 +00:00
}
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"SpecialPages": {
Use LinkBatchFactory in Special:AbuseLog Change-Id: I2ccf9cd36475a65e61ad0e80ec159f841849089f
2020-08-07 21:48:47 +00:00
"AbuseLog": {
"class": "SpecialAbuseLog",
"services": [
Inject PermissionManager to SpecialAbuseLog Change-Id: I1c80490567ac2d9f716c988ebdad6b59cf28aa06
2020-09-17 06:54:06 +00:00
"LinkBatchFactory",
Add an AbuseFilterPermissionManager service This service should act as a mediator between the AF code and the permission manager, and it should know what are the permissions required by each action. Change-Id: Ieb177d9992147b11fa7b8f05929da6c182cc2286
2020-09-18 14:49:13 +00:00
"PermissionManager",
Add ConsequencesRegistry Change-Id: I91f4f28e09fa46b9ab2457b2a241b6f105320bdd
2020-11-29 22:55:34 +00:00
"AbuseFilterPermissionManager",
Add a VariablesBlobStore service Change-Id: If0c1eab2391819f8b4c801d12275d9ec14490f7a
2020-09-29 14:52:05 +00:00
"AbuseFilterConsequencesRegistry",
Add a service to format filter specs This requires a MessageLocalizer, which currently means providing the main RequestContext. This is the only alternative right now, until core provides a proper MessageLocalizer service (see T247127). Change-Id: I8c93e2ae7e7bd4fc561c5e8490ed2feb1ef0edc2
2020-10-02 15:08:48 +00:00
"AbuseFilterVariablesBlobStore",
Introduce a VariablesFormatter service Moves more methods away from the AbuseFilter class. Testing buildVarDumpTable is not easy because we'd have to parse the generated HTML. Change-Id: I073a537201de150ba9dd7bf15a99f3a009dc6ba1
2020-12-31 13:29:00 +00:00
"AbuseFilterSpecsFormatter",
"AbuseFilterVariablesFormatter"
Use LinkBatchFactory in Special:AbuseLog Change-Id: I2ccf9cd36475a65e61ad0e80ec159f841849089f
2020-08-07 21:48:47 +00:00
]
},
DI for AbuseFilterView and subclasses Also add a test to ensure all views can be instantiated without problem. Change-Id: Iedd7a5dca240efab1077fa51a3522c983b0ba4fa
2020-10-23 14:19:02 +00:00
"AbuseFilter": {
"class": "SpecialAbuseFilter",
"services": [
"ObjectFactory"
]
}
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"LogTypes": [
Log accessing private information in abuse filter logs Bug: T152934 Change-Id: I8049df3b2b9343a6877e9a306d2781d3f27ec657
2016-12-12 16:30:06 +00:00
"abusefilter",
"abusefilterprivatedetails"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
],
"LogNames": {
Log accessing private information in abuse filter logs Bug: T152934 Change-Id: I8049df3b2b9343a6877e9a306d2781d3f27ec657
2016-12-12 16:30:06 +00:00
"abusefilter": "abusefilter-log-name",
"abusefilterprivatedetails": "abusefilterprivatedetails-log-name"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"LogHeaders": {
"abusefilter": "abusefilter-log-header"
},
"LogActionsHandlers": {
Move log formatters to a separate directory and namespace This will clean up the includes/ directory a little. Change-Id: I61adacf32257bb2402a272b60b52b69505d981c5
2020-10-07 11:23:10 +00:00
"abusefilter/hit": "MediaWiki\\Extension\\AbuseFilter\\LogFormatter\\AbuseLogHitFormatter",
"abusefilter/modify": "MediaWiki\\Extension\\AbuseFilter\\LogFormatter\\AbuseFilterModifyLogFormatter",
"abusefilter/create": "MediaWiki\\Extension\\AbuseFilter\\LogFormatter\\AbuseFilterModifyLogFormatter",
Migrate AbuseFilter suppress log Also make entries in Special:Log/suppress filterable. Change-Id: Ic23e724997e4748c8d0da8138aa73d31b17b7064
2017-02-15 18:12:31 +00:00
"abusefilterprivatedetails/access": "LogFormatter",
Move log formatters to a separate directory and namespace This will clean up the includes/ directory a little. Change-Id: I61adacf32257bb2402a272b60b52b69505d981c5
2020-10-07 11:23:10 +00:00
"suppress/hide-afl": "MediaWiki\\Extension\\AbuseFilter\\LogFormatter\\AbuseFilterSuppressLogFormatter",
"suppress/unhide-afl": "MediaWiki\\Extension\\AbuseFilter\\LogFormatter\\AbuseFilterSuppressLogFormatter",
"rights/blockautopromote": "MediaWiki\\Extension\\AbuseFilter\\LogFormatter\\AbuseFilterRightsLogFormatter",
"rights/restoreautopromote": "MediaWiki\\Extension\\AbuseFilter\\LogFormatter\\AbuseFilterRightsLogFormatter"
Actually mark abusefilter creations as such in the AbuseFilter log Bug: T178283 Co-Authored-By: Matěj Suchánek <matejsuchanek97@gmail.com> Change-Id: I89776eff2fc420b1fe3e2c3b88671749fadb57b4
2017-10-16 11:19:30 +00:00
},
"ActionFilteredLogs": {
"abusefilter": {
"modify": [
"modify"
],
"create": [
"create"
]
}
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
Log accessing private information in abuse filter logs Bug: T152934 Change-Id: I8049df3b2b9343a6877e9a306d2781d3f27ec657
2016-12-12 16:30:06 +00:00
"LogRestrictions": {
Restrict viewing Special:Log/AbuseFilter, and remove from recent changes Only allow users with `abusefilter-view` to see abuse filter log entries. Note that this is different from the abuse log itself. Bug: T34959 Change-Id: I587c2eb9bdc2e5ca2652aa338440cdc5b6eb9235
2019-11-10 10:33:51 +00:00
"abusefilter": "abusefilter-view",
Use "privatedetails" instead of "private" where needed To keep a clear distinction between "private details" (i.e. user's ip) and "private filters" (i.e. not publicly viewable). This patch renames rights, i18n keys and methods names. The patch for renaming globals and rights in WMF config is I7e6b3d4453403edb6aa602587374b4ff5b6d625f. Bug: T211004 Change-Id: I613dbadb8f75c8c4116a362607563a436a73d321
2019-01-07 15:23:21 +00:00
"abusefilterprivatedetails": "abusefilter-privatedetails-log"
Log accessing private information in abuse filter logs Bug: T152934 Change-Id: I8049df3b2b9343a6877e9a306d2781d3f27ec657
2016-12-12 16:30:06 +00:00
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"APIModules": {
Move API modules to separate namespace and rename them Change-Id: I436e8fed4a1cbe4f1b36a16b213ede7976e871ba
2020-12-03 22:05:42 +00:00
"abusefilterchecksyntax": "MediaWiki\\Extension\\AbuseFilter\\Api\\CheckSyntax",
"abusefilterevalexpression": "MediaWiki\\Extension\\AbuseFilter\\Api\\EvalExpression",
"abusefilterunblockautopromote": "MediaWiki\\Extension\\AbuseFilter\\Api\\UnblockAutopromote",
"abusefiltercheckmatch": "MediaWiki\\Extension\\AbuseFilter\\Api\\CheckMatch",
"abuselogprivatedetails": "MediaWiki\\Extension\\AbuseFilter\\Api\\AbuseLogPrivateDetails"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"APIListModules": {
Move API modules to separate namespace and rename them Change-Id: I436e8fed4a1cbe4f1b36a16b213ede7976e871ba
2020-12-03 22:05:42 +00:00
"abuselog": "MediaWiki\\Extension\\AbuseFilter\\Api\\QueryAbuseLog",
"abusefilters": "MediaWiki\\Extension\\AbuseFilter\\Api\\QueryAbuseFilters"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"MessagesDirs": {
"AbuseFilter": [
Move all apihelp translatable messages to separate files Should be merged along with Ib66f4614285411e5fd971dc0cb4291ea8113418c Bug: T189982 Change-Id: Id9beb08ee34e6861543cf59d80abfac616bf9238
2018-03-19 16:07:25 +00:00
"i18n",
"i18n/api"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
]
},
"ExtensionMessagesFiles": {
"AbuseFilterAliases": "AbuseFilter.alias.php"
},
Move variable generators to new classes RunVariableGenerator is for generating variables based on the current action; RowVariableGenerator is for RC entries; VariableGenerator is the generic one. This patch only moves the methods to the new classes, to keep the diff easier to read, and facilitate conflict resolution. These classes will then be revamped in I366d598b69ad866496b7cb0059e0835c02e54041. Note that these classes are now namespaced. One method, AbuseFilter::getEditVars, was renamed to AbuseFilterVariableGenerator::generateEditVars, because it would otherwise conflict with an incompatible method in RunVariableGenerator. Change-Id: Iff412e5492873d4fae55402939a51609e64d55a8
2020-01-11 17:05:30 +00:00
"AutoloadNamespaces": {
Move API modules to separate namespace and rename them Change-Id: I436e8fed4a1cbe4f1b36a16b213ede7976e871ba
2020-12-03 22:05:42 +00:00
"MediaWiki\\Extension\\AbuseFilter\\Api\\": "includes/Api/",
Update hook calling to use new HookContainer Bug: T254306 Change-Id: Ic5c82a367e34135bbc0f00ece5aeef4f2d92881b
2020-06-03 00:43:22 +00:00
"MediaWiki\\Extension\\AbuseFilter\\VariableGenerator\\": "includes/VariableGenerator/",
Move log formatters to a separate directory and namespace This will clean up the includes/ directory a little. Change-Id: I61adacf32257bb2402a272b60b52b69505d981c5
2020-10-07 11:23:10 +00:00
"MediaWiki\\Extension\\AbuseFilter\\Hooks\\": "includes/Hooks/",
Introduce AbuseFilterParserFactory service TODO For the future: the final directory for Parser-related classes should be "Parser", not "ParserNS". However, moving all classes now would make it harder to rebase changes etc. Change-Id: Ice335f4723e74f4e5fbe8dcc76ff8ea16310962c
2019-12-16 16:19:48 +00:00
"MediaWiki\\Extension\\AbuseFilter\\LogFormatter\\": "includes/LogFormatter/",
Move parser classes to a dedicated namespace Names were kept for now. Change-Id: Ib2eb5d7b523a64f2a0f72fdcdde2043a76cc9a37
2020-12-03 22:22:43 +00:00
"MediaWiki\\Extension\\AbuseFilter\\Parser\\": "includes/Parser/",
Create a base interface for watchers This will ease adding new watchers, for instance to send Echo notifications (see T179495 and T100892). For now, this is just boilerplate, and converting EmergencyWatcher to the new interface. Change-Id: I18d62aba53471202b709cdb19033b1729c5c25b4
2020-11-19 15:32:39 +00:00
"MediaWiki\\Extension\\AbuseFilter\\Filter\\": "includes/Filter/",
Move pagers to their own namespace Change-Id: I5d3da5e51bbc54179c0618f1877f2eabb8302542
2020-12-03 14:11:19 +00:00
"MediaWiki\\Extension\\AbuseFilter\\Pager\\": "includes/Pager/",
Move AbuseFilterView classes to separate namespace Change-Id: I569281b13ec81d9f35038c7ef17a2d98f16f9b5c
2020-11-29 10:53:29 +00:00
"MediaWiki\\Extension\\AbuseFilter\\View\\": "includes/View/",
Represent Consequences with command objects The consequence-taking logic is moved away from AbuseFilterRunner, to dedicated classes. There's now one class per consequence, encapsulating everything it needs to take the consequence. Several interfaces allow customizing different types of consequences. Every "special check" in AbuseFilter was generalized to use these interfaces, rather than knowing how to handle each consequence. Adding more consequences from other extensions will also be easier, and it should happen via a hook (not a global), returning a class that implements Consequence. The BCConsequence class was temporarily added for legacy custom consequences. A ConsequenceFactory class is added to instantiate consequences; this would possibly benefit from using ObjectFactory, but it doesn't because it would also reduce readability (although we might do that in the future). These classes are still not covered by unit tests, and this is left to do for later. The new unit tests should mostly replace AbuseFilterConsequencesTest. @covers tag were added to keep the status quo (i.e. code that was considered covered while in AbuseFilterRunner will still be considered covered), although we'll have to adjust them. Change-Id: Ia1a9a8bbf55ddd875dfd5bbc55fcd612cff568ef
2020-10-11 21:17:41 +00:00
"MediaWiki\\Extension\\AbuseFilter\\Watcher\\": "includes/Watcher/",
Create a dedicated namespace for all consequences-related classes Change-Id: Ibc39593e34da36e57b640af0b5bbf2145f725e92
2020-12-18 14:05:33 +00:00
"MediaWiki\\Extension\\AbuseFilter\\Consequences\\": "includes/Consequences/",
Move ChangeTags stuff to separate namespace Change-Id: I6d7bed0e62f001f82c00a3528cc0018388c9c70e
2020-11-26 15:23:22 +00:00
"MediaWiki\\Extension\\AbuseFilter\\ChangeTags\\": "includes/ChangeTags/"
Move variable generators to new classes RunVariableGenerator is for generating variables based on the current action; RowVariableGenerator is for RC entries; VariableGenerator is the generic one. This patch only moves the methods to the new classes, to keep the diff easier to read, and facilitate conflict resolution. These classes will then be revamped in I366d598b69ad866496b7cb0059e0835c02e54041. Note that these classes are now namespaced. One method, AbuseFilter::getEditVars, was renamed to AbuseFilterVariableGenerator::generateEditVars, because it would otherwise conflict with an incompatible method in RunVariableGenerator. Change-Id: Iff412e5492873d4fae55402939a51609e64d55a8
2020-01-11 17:05:30 +00:00
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"AutoloadClasses": {
Rename files to match class name Change-Id: Ia19bfec6c2289912699b6c90261afda311afb56e
2018-03-30 00:50:44 +00:00
"AbuseFilter": "includes/AbuseFilter.php",
"AbuseFilterHooks": "includes/AbuseFilterHooks.php",
Move various classes to their own files Change-Id: I5d418b3fa27aa6e04b9a680922e5eab2439ffb20
2016-12-17 17:52:36 +00:00
"AbuseFilterPreAuthenticationProvider": "includes/AbuseFilterPreAuthenticationProvider.php",
Add a parent class for special pages This allows us to extract yet another static method from the AbuseFilter class. This class should be expanded in the future, and an example use case could be Ia5fd4f0b35fcabf045a7b49fa40fa85b72c92544. Depends-On: I7c0170167b508132cd16e566c654a6c98dd683e9 Change-Id: I1bb45e47c3b42c01388b99778ce833e4e44419e1
2019-02-08 17:45:25 +00:00
"AbuseFilterSpecialPage": "includes/special/AbuseFilterSpecialPage.php",
Normalize file layout Aka move all code into includes/. Change-Id: I21f7b80bb6df04abbed6bfccb94f92100dc8f071
2017-08-07 23:11:38 +00:00
"SpecialAbuseLog": "includes/special/SpecialAbuseLog.php",
"SpecialAbuseFilter": "includes/special/SpecialAbuseFilter.php",
Move classes to own files Makes MediaWiki.Files.OneClassPerFile.MultipleFound pass Change-Id: I3b08a69fe7990d6fe5f71cda51d6ac01f11aad2d
2017-12-16 00:26:25 +00:00
"AbuseFilterChangesList": "includes/AbuseFilterChangesList.php",
"TableDiffFormatterFullContext": "includes/TableDiffFormatterFullContext.php",
Move AbuseFilterVariableHolder up to /includes This class is not for parsing logic or tree nodes Change-Id: I07a499cc972c30fc249ec4de3250900a3b703443
2016-12-19 01:13:06 +00:00
"AbuseFilterVariableHolder": "includes/AbuseFilterVariableHolder.php",
Add GlobalNameUtils class This is just a temporary location for these two methods. Since they're used a lot, having them in the AbuseFilter class means that the dependency graph is unnecessarily complicated. Thus, since these methods aren't doing much, they were moved to a dedicated class. Future todo is finding an appropriate location, that might be either as part of another service, or keep them in a Utilities class, perhaps a single class with all util methods, rather than a specific class. Change-Id: I52cc47a6b9a387cd1e68c5127f6598a4c43ca428
2020-12-02 22:47:40 +00:00
"MediaWiki\\Extension\\AbuseFilter\\GlobalNameUtils": "includes/GlobalNameUtils.php",
Add a FilterLookup service Some pieces of code were updated to use Filter objects, while other places are still to be updated. We also need to change the history part to exclude actions somehow, cleanup the ViewEdit, reduce direct DB access or anything mentioning DB fields outside of FilterLookup, etc. Change-Id: I42b7ded685db76eddd45e4b1336f9828cba811ce
2020-09-20 11:30:59 +00:00
"MediaWiki\\Extension\\AbuseFilter\\FilterLookup": "includes/FilterLookup.php",
Introduce a KeywordsManager service This will decouple a bit the huge and chaotic tangle of AF classes. Some boilerplate code for AbuseFilter services is also added with this patch. Note that this requires injecting a KeywordsManager in AbuseFilterVariableHolder, or unit tests would fail. This is still incomplete, and the Manager is only injected in tests, because VariableHolder still has to be refactored. The test for the UpdateVarDumps script had to be updated, because serializing VHs in there was a bad choice. As pointed out in a comment, the test is likely going to break again once we remove the BC code, but I hope that we'll be able to remove the test at that point. Change-Id: I12a656a310adb8c5f75cab63f6db9e121e109717
2020-01-15 16:08:53 +00:00
"MediaWiki\\Extension\\AbuseFilter\\KeywordsManager": "includes/KeywordsManager.php",
Add an AbuseFilterPermissionManager service This service should act as a mediator between the AF code and the permission manager, and it should know what are the permissions required by each action. Change-Id: Ieb177d9992147b11fa7b8f05929da6c182cc2286
2020-09-18 14:49:13 +00:00
"MediaWiki\\Extension\\AbuseFilter\\AbuseFilterPermissionManager": "includes/AbuseFilterPermissionManager.php",
Notify of a throttled filter Use Echo for delivering the notification to the last user who edited the filter. Much boilerplate. Change-Id: I7a46a03b4f15de20902ec70c62fb4fe750096842 Depends-On: If585b14a6dd6fb8c7d2c3bee1f20d9d08eaac706
2020-11-10 12:58:11 +00:00
"MediaWiki\\Extension\\AbuseFilter\\EchoNotifier": "includes/EchoNotifier.php",
"MediaWiki\\Extension\\AbuseFilter\\ThrottleFilterPresentationModel": "includes/ThrottleFilterPresentationModel.php",
Add a service to format filter specs This requires a MessageLocalizer, which currently means providing the main RequestContext. This is the only alternative right now, until core provides a proper MessageLocalizer service (see T247127). Change-Id: I8c93e2ae7e7bd4fc561c5e8490ed2feb1ef0edc2
2020-10-02 15:08:48 +00:00
"MediaWiki\\Extension\\AbuseFilter\\SpecsFormatter": "includes/SpecsFormatter.php",
Introduce a VariablesFormatter service Moves more methods away from the AbuseFilter class. Testing buildVarDumpTable is not easy because we'd have to parse the generated HTML. Change-Id: I073a537201de150ba9dd7bf15a99f3a009dc6ba1
2020-12-31 13:29:00 +00:00
"MediaWiki\\Extension\\AbuseFilter\\VariablesFormatter": "includes/VariablesFormatter.php",
Add a LazyVariableComputer service See task for a description of the plan. Also note that AFComputedVariable should be renamed and its properties made private. This commit includes some adjustments for taint-check in AbuseFilter::buildVarDumpTable and ::revisionToString. There's some space for improvement in the new LazyVariableComputer, but that's left for another commit. Bug: T261069 Change-Id: Ia44f6e079d39f44cf0122dec5ddb5513ab54f0c6
2020-09-25 22:32:01 +00:00
"MediaWiki\\Extension\\AbuseFilter\\LazyVariableComputer": "includes/LazyVariableComputer.php",
Add a TextExtractor service This is an important step towards removing the AbuseFilter class. Note: proposals for the name of the new service are welcome. Change-Id: Ib4632173f728b1bdafadef96e01645a833bfceaa
2020-09-29 18:48:51 +00:00
"MediaWiki\\Extension\\AbuseFilter\\TextExtractor": "includes/TextExtractor.php",
Introduce a KeywordsManager service This will decouple a bit the huge and chaotic tangle of AF classes. Some boilerplate code for AbuseFilter services is also added with this patch. Note that this requires injecting a KeywordsManager in AbuseFilterVariableHolder, or unit tests would fail. This is still incomplete, and the Manager is only injected in tests, because VariableHolder still has to be refactored. The test for the UpdateVarDumps script had to be updated, because serializing VHs in there was a bad choice. As pointed out in a comment, the test is likely going to break again once we remove the BC code, but I hope that we'll be able to remove the test at that point. Change-Id: I12a656a310adb8c5f75cab63f6db9e121e109717
2020-01-15 16:08:53 +00:00
"MediaWiki\\Extension\\AbuseFilter\\AbuseFilterServices": "includes/AbuseFilterServices.php",
Add a new FilterProfiler service Change-Id: Ib66c42ac220731f4e1da9ee6cfb5290759dd6494
2020-09-20 22:31:41 +00:00
"MediaWiki\\Extension\\AbuseFilter\\FilterProfiler": "includes/FilterProfiler.php",
Introduce BlockAutopromoteStore service This service is responsible for the blockautopromote feature: (un)block autopromotion and check status. The patch mostly moves code from static methods to the new class and relaxes type hints (e.g. from User to UserIdentity). Change-Id: I79a72377881cf06717931cd09af12f3b8e5f3e3f
2020-10-21 14:18:08 +00:00
"MediaWiki\\Extension\\AbuseFilter\\BlockAutopromoteStore": "includes/BlockAutopromoteStore.php",
Add a service to retrieve the filter user Unfortunately, this isn't using DI completely, because of the User::newSystemUser call. I'm not even sure if we really need to call it or we can just stick to new UserIdentityValue, but leaving like this for now. Also, the types were weakened to UserIdentity, so the transition is going to be easy anyway. Change-Id: I08f8fae0fcc622ff0ac3f86771476d06d1c18549
2020-10-25 15:30:43 +00:00
"MediaWiki\\Extension\\AbuseFilter\\FilterUser": "includes/FilterUser.php",
Add a service to retrieve the central DB This is a thin wrapper around LBFactory and the global variable, that can be injected in classes requiring it (no real class right now, but that's going to change soon). Also, remove some DWIM-style returns which made the code harder to understand. Change-Id: I1d28ad4a67f914103f3a17cda5f61b28070c7f1c
2020-10-16 22:29:41 +00:00
"MediaWiki\\Extension\\AbuseFilter\\CentralDBManager": "includes/CentralDBManager.php",
"MediaWiki\\Extension\\AbuseFilter\\CentralDBNotAvailableException": "includes/CentralDBNotAvailableException.php",
Introduce a FilterValidator This moves a lot of things away from the AbuseFilter class. There's a nasty static dependency on ChangeTags, but it's very limited anyway, and it's going to be fixed once T245964 is resolved. Change-Id: Ia7df4b4d3289c2722323f59ceecf3fdd38277785
2020-10-10 17:20:21 +00:00
"MediaWiki\\Extension\\AbuseFilter\\FilterValidator": "includes/FilterValidator.php",
Introduce a FilterCompare service The scope is still quite limited, but as noted in a todo, we might want to make this completely independent from the database, and add the use case of ViewDiff. Change-Id: Ie980fff0983b3e86037265e85da04444c809a6e8
2020-11-07 11:40:26 +00:00
"MediaWiki\\Extension\\AbuseFilter\\FilterCompare": "includes/FilterCompare.php",
Add an interface for exporting/importing filters The main benefit of having a dedicated interface is that we can easily change the output format. So we're now using a custom array without references to the DB schema, thus making the import/export process completely independent from the schema. Change-Id: I4c0de41d914baf1e9a0e588bd31f95b3524a424b
2020-10-15 22:00:32 +00:00
"MediaWiki\\Extension\\AbuseFilter\\FilterImporter": "includes/FilterImporter.php",
Introduce EditBoxBuilderFactory service and EditBoxBuilder It makes sense to look at this and Iedd7a5dca24 together, as this patch itself doesn't really fix anything. Change-Id: Ifef5266b1803d1a96489789b08d9beed044d908f
2020-11-24 12:16:41 +00:00
"MediaWiki\\Extension\\AbuseFilter\\EditBoxBuilder": "includes/EditBoxBuilder.php",
"MediaWiki\\Extension\\AbuseFilter\\EditBoxBuilderFactory": "includes/EditBoxBuilderFactory.php",
Add an interface for exporting/importing filters The main benefit of having a dedicated interface is that we can easily change the output format. So we're now using a custom array without references to the DB schema, thus making the import/export process completely independent from the schema. Change-Id: I4c0de41d914baf1e9a0e588bd31f95b3524a424b
2020-10-15 22:00:32 +00:00
"MediaWiki\\Extension\\AbuseFilter\\InvalidImportDataException": "includes/InvalidImportDataException.php",
Introduce a service for saving filters Change-Id: I6b7d16ad7ea1124989ed67c74413979cfd0275c4
2020-09-19 22:16:35 +00:00
"MediaWiki\\Extension\\AbuseFilter\\FilterStore": "includes/FilterStore.php",
Add a VariablesBlobStore service Change-Id: If0c1eab2391819f8b4c801d12275d9ec14490f7a
2020-09-29 14:52:05 +00:00
"MediaWiki\\Extension\\AbuseFilter\\VariablesBlobStore": "includes/VariablesBlobStore.php",
Create an AbuseLogger service For now this is just moving code around. Change-Id: Ie61a1c122b4e93a74b465eb781f9cbf49f0b32e6
2020-10-24 11:58:46 +00:00
"MediaWiki\\Extension\\AbuseFilter\\AbuseLogger": "includes/AbuseLogger.php",
"MediaWiki\\Extension\\AbuseFilter\\AbuseLoggerFactory": "includes/AbuseLoggerFactory.php",
Create FilterRunnerFactory Next step is splitting the Runner into various subclasses. Change-Id: I766555f31b425cee52fd262c5bfb1c73f3f170d2
2020-11-27 14:49:41 +00:00
"MediaWiki\\Extension\\AbuseFilter\\FilterRunner": "includes/FilterRunner.php",
"MediaWiki\\Extension\\AbuseFilter\\FilterRunnerFactory": "includes/FilterRunnerFactory.php",
Move various classes to their own files Change-Id: I5d418b3fa27aa6e04b9a680922e5eab2439ffb20
2016-12-17 17:52:36 +00:00
"AFComputedVariable": "includes/AFComputedVariable.php",
Add tests for global filters Another crucial part to have covered. Also clarify that AbuseFilterCentralDB can be of the form "dbname-prefix". Remove a filter used for profiling and replace it with a global one: we're still fine, and the list is kept shorter. Bug: T201193 Depends-On: I5ee7ba44a6cd82a5ddb24fb4127af04d96e647f4 Change-Id: If6b91711534c0d60e1aa27bd5748c3023e29f376
2018-08-25 12:44:01 +00:00
"NormalizeThrottleParameters": "maintenance/normalizeThrottleParameters.php",
Add a maintenance script to clean afl_var_dump This script aims to fix every problem reported in T213006. Subsequent patches will add new code and drop the back-compat one. Bug: T213006 Bug: T187153 Bug: T204236 Bug: T187731 Bug: T204235 Bug: T214193 Bug: T214196 Bug: T34478 Depends-On: I5b29ff556eca45fe59d15e2e3df4d06f1f6b3934 Change-Id: I22cf698c5be77506727cbd227c67e037a5d89b5c
2019-01-06 13:52:06 +00:00
"FixOldLogEntries": "maintenance/fixOldLogEntries.php",
Split afl_filter in afl_filter_id and afl_global Add a script to migrate the columns (which can also be executed in dry run), and a config option with the migration stage (defaults to SCHEMA_COMPAT_OLD). Some of the script-related code is stolen from Ic755526d5f989c4a66b1d37527cda235f61cb437. Bug: T220791 Change-Id: I7460a2d63f60c2933b36f8383a8abdbba8649e12
2018-09-11 16:57:49 +00:00
"UpdateVarDumps": "maintenance/updateVarDumps.php",
"MigrateAflFilter": "maintenance/migrateAflFilter.php"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
Move test-only classes to new TestAutoloadClasses declaration Bug: T196090 Depends-On: I88cf69663362fd599c20649b1df641907a02678d Change-Id: I5e3ef040628c4ff629a8aabc56a3b8ba259b7e78
2019-12-10 19:40:18 +00:00
"TestAutoloadClasses": {
"AbuseFilterConsequencesTest": "tests/phpunit/AbuseFilterConsequencesTest.php",
Organize unit tests Add namespaces, shorten class names. Non-unit tests and AbuseFilterTest are untouched because those should be refactored first. Change-Id: Ie46ef18d6ba1017e25c76b1762f678e5452264d9
2021-01-01 13:11:09 +00:00
"MediaWiki\\Extension\\AbuseFilter\\Tests\\Unit\\Parser\\ParserTestCase": "tests/phpunit/unit/Parser/ParserTestCase.php",
Add test traits for uploads and account creation Ideally, this might live in MediaWikiIntegrationTestCase. For the createaccount one, AuthManager should also provide a method to log the creation, because currently we are forced to copypaste that code here. - Add the missing tests for 'upload' in RCVariableGenerator, and adjust the existing ones (delete file afterwards, more tablesUsed, use the right extension). - Exclude from the coverage report a couple of lines which should theoretically be unreachable. Escalate logging to WARN level, where it's more likely to be spotted. - Remove an unused method (RCVariableGenerator::newFromID). This denies the need to maintain and cover it. We also don't want this generator to act as a factory. Overall, this change brings the coverage for RCVariableGenerator to 100% Bug: T201193 Change-Id: I425c3d9f6800f74eb6e4eda483b90cfb3bbbcb51
2020-09-16 09:15:38 +00:00
"AbuseFilterUploadTestTrait": "tests/phpunit/AbuseFilterUploadTestTrait.php",
Add a FilterLookup service Some pieces of code were updated to use Filter objects, while other places are still to be updated. We also need to change the history part to exclude actions somehow, cleanup the ViewEdit, reduce direct DB access or anything mentioning DB fields outside of FilterLookup, etc. Change-Id: I42b7ded685db76eddd45e4b1336f9828cba811ce
2020-09-20 11:30:59 +00:00
"AbuseFilterCreateAccountTestTrait": "tests/phpunit/AbuseFilterCreateAccountTestTrait.php",
"AbuseFilterRowsAndFiltersTestTrait": "tests/phpunit/AbuseFilterRowsAndFiltersTestTrait.php"
Move test-only classes to new TestAutoloadClasses declaration Bug: T196090 Depends-On: I88cf69663362fd599c20649b1df641907a02678d Change-Id: I5e3ef040628c4ff629a8aabc56a3b8ba259b7e78
2019-12-10 19:40:18 +00:00
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"ResourceModules": {
"ext.abuseFilter": {
"styles": "ext.abuseFilter.css"
},
"ext.abuseFilter.edit": {
"scripts": "ext.abuseFilter.edit.js",
"messages": [
"abusefilter-edit-syntaxok",
"abusefilter-edit-syntaxerr",
"abusefilter-http-error",
Change throttle selector to restore old functionality, overall improvement Long (sigh) explanation in T203587#4569698. Also, simplified the way TagMultiselect are generated, this one and the one for change tags. This new selector is back-compat both with the old textarea and the OOUI checkboxMultiselect; actually, this one is //fully// compatible with the old textarea. Add validation for throttle parameters and unit tests for validation (split from I976c95658cddb2585910b6f8a5f047aadc4e4d47). Added a trim when retrieving throttle identifier to allow syntax like 'ip, user'. Improved the message shown on history. Re-added the maintenance script to clean DB. As I wrote in the task, a review by two other people would be great, at least for the maintenance script (it could potentially break the DB). Bug: T203587 Bug: T203336 Bug: T203584 Bug: T203585 Depends-On: I3b2e763bd8835207dc5df1db43d3e1881e6961c3 Change-Id: I7831dbb0bab55807392ac1f7915d6cb0cb713593
2018-09-09 10:14:31 +00:00
"abusefilter-edit-throttle-placeholder",
"abusefilter-edit-tag-placeholder",
Warn the user if they try to leave the page with unsaved changes While editing filters, sometimes it happen that you make some change, forget about it and then reload/close the page, and no warnings will be issued. This patch makes use of the core module used for normal page editing to display a warning if trying to leave a filter editing page with any unsaved change (both to the filter pattern or other form elements). Change-Id: I78d79215565d5c82028b1a2a4276497ccbffdea2
2018-12-04 12:06:46 +00:00
"abusefilter-edit-warn-leave",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"unknown-error"
],
"dependencies": [
"mediawiki.util",
"mediawiki.api",
Warn the user if they try to leave the page with unsaved changes While editing filters, sometimes it happen that you make some change, forget about it and then reload/close the page, and no warnings will be issued. This patch makes use of the core module used for normal page editing to display a warning if trying to leave a filter editing page with any unsaved change (both to the filter pattern or other form elements). Change-Id: I78d79215565d5c82028b1a2a4276497ccbffdea2
2018-12-04 12:06:46 +00:00
"mediawiki.confirmCloseWindow",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"jquery.textSelection",
Switch editing interface to OOUI & improve NoJS usability This settles almost everything, leaving the tags part ready to be further improved in the follow-ups. Also, replaced some fields with totally different ones, improved the warn preview area and improved a bit nojs experience by hiding unusable buttons. Bug: T132284 Bug: T154749 Change-Id: I7a5caa862a32f9792140c6a4d9708a2d20472672
2018-03-23 09:13:41 +00:00
"jquery.spinner",
"oojs-ui-core",
"oojs-ui-widgets"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
]
},
"ext.abuseFilter.tools": {
"scripts": "ext.abuseFilter.tools.js",
"messages": [
"abusefilter-reautoconfirm-notallowed",
"abusefilter-reautoconfirm-none",
"abusefilter-reautoconfirm-done",
"abusefilter-http-error",
Improve var dumping in /details, /examine and /tools Using var_export for better visual effect, especially for arrays. The result from /tools is much clearer and the 'wrong syntax' message is a bit more explicative than before. Bug: T190653 Bug: T239972 Change-Id: I79a17305c7f19f7900f896f895e9365bb5f2fd58
2018-03-26 18:41:20 +00:00
"abusefilter-tools-syntax-error",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"unknown-error"
],
"dependencies": [
"mediawiki.api",
Migrate 'user.tokens' dependency to 'user.options' The 'user.tokens' module is a deprecated alias to 'user.options' since MW 1.35. Bug: T235457 Change-Id: I45e8e35edf4e6f901c2045d2592326e531607726
2020-03-27 16:21:46 +00:00
"user.options",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"jquery.spinner"
]
},
"ext.abuseFilter.examine": {
"scripts": "ext.abuseFilter.examine.js",
"messages": [
"abusefilter-examine-match",
"abusefilter-examine-nomatch",
"abusefilter-examine-syntaxerror",
"abusefilter-examine-notfound",
Allow users with abusefilter-view-private to use testing interface Now the required need will be abusefilter-modify OR abusefilter-view-private for /tools, /test and /examine. Bug: T193903 Change-Id: I3f1a91a2cc1df2272e5d4099cefd7c649a0683d5
2018-05-04 19:56:45 +00:00
"abusefilter-mustviewprivateoredit",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"abusefilter-http-error",
"unknown-error"
],
"dependencies": [
"jquery.spinner",
"mediawiki.api"
]
Revert "Revert "Switch editor to Ace and provide syntax highlight"" Make Ace use a fixed size in em. This reverts commit 272775ff81f230659b678d4c514f7a8ef817d9f7. Change-Id: I9b439b20df91eb367bcef4b6f33ff087aded0b62
2018-03-30 06:55:03 +00:00
},
"ext.abuseFilter.ace": {
"scripts": "mode-abusefilter.js",
"dependencies": "ext.codeEditor.ace"
Bring in VE support from VE extension Change-Id: Ib1354f0404209a15194895026ff9d179d16b1900
2018-11-29 18:17:12 +00:00
},
"ext.abuseFilter.visualEditor": {
Add mobile target to VE plugin modules Bug: T213774 Change-Id: Idb4dd58b441d24fae7012b79fc049fbd02029c4c
2019-01-15 00:05:20 +00:00
"scripts": "ve-abusefilter/ve.init.mw.AbuseFilterSaveErrorHandler.js",
"targets": [ "desktop", "mobile" ]
Bring in VE support from VE extension Change-Id: Ib1354f0404209a15194895026ff9d179d16b1900
2018-11-29 18:17:12 +00:00
}
},
"attributes": {
"VisualEditor": {
"PluginModules": [
"ext.abuseFilter.visualEditor"
]
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
}
},
"ResourceFileModulePaths": {
"localBasePath": "modules",
"remoteExtPath": "AbuseFilter/modules"
},
Change some globals to work better with extension registration Rename $wgAbuseFilterAvailableActions / $wgAbuseFilterRestrictedActions to $wgAbuseFilterActions / $wgAbuseFilterRestrictions and make them an associative array instead of a plain one, as that works more sanely with extension registration. (The renaming helps to give more useful errors to sites using the old config.) Change-Id: I790d39c2849922d7daf7479f298cd90cf30af129
2016-06-03 18:01:56 +00:00
"callback": "AbuseFilterHooks::onRegistration",
Migrate a few hook handlers to DI Bug: T261067 Change-Id: If699917c3d2e9e22525c7d0495554e25f6b45125
2020-10-04 11:29:06 +00:00
"HookHandlers": {
"ToolLinks": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\ToolLinksHandler",
"services": [ "AbuseFilterPermissionManager" ]
Migrate change tags hooks to DI Bug: T261067 Change-Id: I7b95cd19ab0ae04820e8dcb3481d29a2f9e7a0ca
2020-10-14 14:32:55 +00:00
},
Implement GetAutoPromoteGroupsHook Test coverage included. Bug: T261067 Change-Id: Iba49f0518d2c1a72405498b2743e5ef300dd6d61
2020-12-15 16:29:02 +00:00
"AutoPromoteGroups": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\AutoPromoteGroupsHandler",
"factory": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\AutoPromoteGroupsHandler::factory",
"services": [ "AbuseFilterConsequencesRegistry", "AbuseFilterBlockAutopromoteStore" ]
},
Migrate change tags hooks to DI Bug: T261067 Change-Id: I7b95cd19ab0ae04820e8dcb3481d29a2f9e7a0ca
2020-10-14 14:32:55 +00:00
"ChangeTags": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\ChangeTagsHandler",
"services": [ "AbuseFilterChangeTagsManager" ]
Add dedicated classes for more hook handlers The schema changes hook was chosen because the handler is very long. The test ones were chosen to keep test things away from actual code. Bug: T261067 Change-Id: Ie06bf62399f6353e3e268cccb3fe4b41bbf951c5
2020-10-08 17:38:52 +00:00
},
"Tests": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\TestsHandler"
},
"SchemaChanges": {
"class": "MediaWiki\\Extension\\AbuseFilter\\Hooks\\Handlers\\SchemaChangesHandler"
Migrate a few hook handlers to DI Bug: T261067 Change-Id: If699917c3d2e9e22525c7d0495554e25f6b45125
2020-10-04 11:29:06 +00:00
}
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"Hooks": {
"EditFilterMergedContent": "AbuseFilterHooks::onEditFilterMergedContent",
Implement GetAutoPromoteGroupsHook Test coverage included. Bug: T261067 Change-Id: Iba49f0518d2c1a72405498b2743e5ef300dd6d61
2020-12-15 16:29:02 +00:00
"GetAutoPromoteGroups": "AutoPromoteGroups",
Use the updated TitleMove hook to filter move actions For several reasons: *We're not really checking permissions (and the hook previously used is meant to be used in such case) *We'll show a cleaner error message (i.e. without the "You do not have permission..." part) *Filtering will happen closer to the actual move Bug: T208907 Depends-On: I4733724075b7514e9db59e7be772d9409aa9da87 Change-Id: If88f736a446247f8b4b13c055c641d56f544d1ea
2018-11-09 15:05:11 +00:00
"TitleMove": "AbuseFilterHooks::onTitleMove",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"ArticleDelete": "AbuseFilterHooks::onArticleDelete",
"RecentChange_save": "AbuseFilterHooks::onRecentChangeSave",
Migrate change tags hooks to DI Bug: T261067 Change-Id: I7b95cd19ab0ae04820e8dcb3481d29a2f9e7a0ca
2020-10-14 14:32:55 +00:00
"ListDefinedTags": "ChangeTags",
"ChangeTagsListActive": "ChangeTags",
Add dedicated classes for more hook handlers The schema changes hook was chosen because the handler is very long. The test ones were chosen to keep test things away from actual code. Bug: T261067 Change-Id: Ie06bf62399f6353e3e268cccb3fe4b41bbf951c5
2020-10-08 17:38:52 +00:00
"LoadExtensionSchemaUpdates": "SchemaChanges",
Migrate a few hook handlers to DI Bug: T261067 Change-Id: If699917c3d2e9e22525c7d0495554e25f6b45125
2020-10-04 11:29:06 +00:00
"ContributionsToolLinks": "ToolLinks",
"HistoryPageToolLinks": "ToolLinks",
"UndeletePageToolLinks": "ToolLinks",
Provide page text and edit summary when filtering file uploads This allows filters using `action='upload'` to use the variables `summary`, `new_wikitext` and several others that previously were only provided when editing pages (`action='edit'`). This is achieved using the new UploadVerifyUpload hook, introduced in MediaWiki core in change Ie68801b307de8456e1753ba54a29c34c8063bc36. `action='upload'` is now only used when publishing an upload, and not for uploads to stash. A new `action='stashupload'` is introduced, which is used for all uploads, including uploads to stash. This behaves like `action='upload'` used to, and only provides file metadata variables. Filter authors should use `action='stashupload'` when a file can be checked based only on the file contents, and `action='upload'` only when the wikitext edit needs to be examined too. Bug: T87381 Bug: T89252 Bug: T139848 Change-Id: I9654f82ecda82e4917fd0ac6b364b947a1434c73
2016-06-17 15:23:42 +00:00
"UploadVerifyUpload": "AbuseFilterHooks::onUploadVerifyUpload",
Only run filters once for direct uploads (without stash) Uses the new UploadStashFile hook. Bug: T140522 Depends-On: I2f574b355cd33b2e9fa7ff8e1793503b257cce65 Change-Id: Ic7c2dbc54c6ad300d26172796ee21027a8c372ee
2016-08-03 14:30:18 +00:00
"UploadStashFile": "AbuseFilterHooks::onUploadStashFile",
Update hooks to use `PageSaveComplete` Extension requires MW 1.35+, always available Bug: T250566 Change-Id: I60cf3cc42db989d8ccb0d06d3cf9eae8a85784ac
2020-06-16 04:12:38 +00:00
"PageSaveComplete": "AbuseFilterHooks::onPageSaveComplete",
Integrate with Renameuser Register abuse_filter and abuse_filter_history tables. abuse_filter_log is more difficult (if possible). Bug: T27377 Bug: T206477 Change-Id: If8289101a08887519d5a90ef84700421b8ed2406
2020-09-30 13:15:27 +00:00
"RenameUserSQL": "AbuseFilterHooks::onRenameUserSQL",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"UserMergeAccountFields": "AbuseFilterHooks::onUserMergeAccountFields",
Notify of a throttled filter Use Echo for delivering the notification to the last user who edited the filter. Much boilerplate. Change-Id: I7a46a03b4f15de20902ec70c62fb4fe750096842 Depends-On: If585b14a6dd6fb8c7d2c3bee1f20d9d08eaac706
2020-11-10 12:58:11 +00:00
"BeforeCreateEchoEvent": "AbuseFilterHooks::onBeforeCreateEchoEvent",
Add tests for global filters Another crucial part to have covered. Also clarify that AbuseFilterCentralDB can be of the form "dbname-prefix". Remove a filter used for profiling and replace it with a global one: we're still fine, and the list is kept shorter. Bug: T201193 Depends-On: I5ee7ba44a6cd82a5ddb24fb4127af04d96e647f4 Change-Id: If6b91711534c0d60e1aa27bd5748c3023e29f376
2018-08-25 12:44:01 +00:00
"ParserOutputStashForEdit": "AbuseFilterHooks::onParserOutputStashForEdit",
Add dedicated classes for more hook handlers The schema changes hook was chosen because the handler is very long. The test ones were chosen to keep test things away from actual code. Bug: T261067 Change-Id: Ie06bf62399f6353e3e268cccb3fe4b41bbf951c5
2020-10-08 17:38:52 +00:00
"UnitTestsAfterDatabaseSetup": "Tests",
"UnitTestsBeforeDatabaseTeardown": "Tests"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
Introduce a KeywordsManager service This will decouple a bit the huge and chaotic tangle of AF classes. Some boilerplate code for AbuseFilter services is also added with this patch. Note that this requires injecting a KeywordsManager in AbuseFilterVariableHolder, or unit tests would fail. This is still incomplete, and the Manager is only injected in tests, because VariableHolder still has to be refactored. The test for the UpdateVarDumps script had to be updated, because serializing VHs in there was a bad choice. As pointed out in a comment, the test is likely going to break again once we remove the BC code, but I hope that we'll be able to remove the test at that point. Change-Id: I12a656a310adb8c5f75cab63f6db9e121e109717
2020-01-15 16:08:53 +00:00
"ServiceWiringFiles": [
"includes/ServiceWiring.php"
],
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"config": {
Change some globals to work better with extension registration Rename $wgAbuseFilterAvailableActions / $wgAbuseFilterRestrictedActions to $wgAbuseFilterActions / $wgAbuseFilterRestrictions and make them an associative array instead of a plain one, as that works more sanely with extension registration. (The renaming helps to give more useful errors to sites using the old config.) Change-Id: I790d39c2849922d7daf7479f298cd90cf30af129
2016-06-03 18:01:56 +00:00
"AbuseFilterActions": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"throttle": true,
"warn": true,
"disallow": true,
"blockautopromote": true,
"block": true,
"rangeblock": false,
Rearrange config to provide better experience In order to bundle AbuseFilter, we have to provide an optimal configuration for sysadmins. This patch aims to provide such configuration, and of course it's open to changes. Changed values: *Grant abusefilter-view-private to admins. This is mostly for redundancy-safety (they already have -modify) *Grant modify-restricted to admins (see T200032) *Disable the 'degroup' action. This is really dangerous, not ideal to be enabled by default. *Grant the abusefilter-revert right to sysops. This is similar to assigning the modify-restricted right in its rationale. *Add abusefilter-log-private to viewrestrictedlogs grant. This right should go together with abusefilter-view-private. (T226987) *Remove abusefilter-revert from the rollback grant, as that right is for reverting AF actions and has nothing to do with rollbacks. This mostly copies the config of WMF production: degrouping is already disabled there, and modify-restricted should be assigned to sysops on WMF wikis as well. The assignment of the abusefilter-view-private and abusefiliter-revert rights is handled in I09cb462312c5bbc71ee3a8f0fbd91357908130d4 (parent patch) to keep the status quo. NOTE: this patch should be *deployed* together with the config patch to avoid discontinuities. Thus, please ONLY provide a virtual +2 using a +1, and I'll coordinate the +2 with a deployer. Bug: T191740 Bug: T200032 Bug: T226987 Depends-On: I09cb462312c5bbc71ee3a8f0fbd91357908130d4 Change-Id: I58f215b8aa3444602532098a3c9dfd25409f29eb
2018-10-20 10:24:53 +00:00
"degroup": false,
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"tag": true
},
"description": "Array of enabled actions in the form [action name => is enabled?]. At the end of setup, false values will be filtered out"
},
"AbuseFilterConditionLimit": {
"value": 1000,
"description": "The maximum number of 'conditions' that can be used each time the filters are run against a change. (More complex filters require more 'conditions')."
},
"AbuseFilterParserClass": {
"value": "AbuseFilterParser",
Introduce AbuseFilterParserFactory service TODO For the future: the final directory for Parser-related classes should be "Parser", not "ParserNS". However, moving all classes now would make it harder to rebase changes etc. Change-Id: Ice335f4723e74f4e5fbe8dcc76ff8ea16310962c
2019-12-16 16:19:48 +00:00
"description": "Class of the parser to use. The only possible values are 'AbuseFilterParser' and 'AbuseFilterCachingParser' (experimental). The code should only use the ParserFactory service."
Change some globals to work better with extension registration Rename $wgAbuseFilterAvailableActions / $wgAbuseFilterRestrictedActions to $wgAbuseFilterActions / $wgAbuseFilterRestrictions and make them an associative array instead of a plain one, as that works more sanely with extension registration. (The renaming helps to give more useful errors to sites using the old config.) Change-Id: I790d39c2849922d7daf7479f298cd90cf30af129
2016-06-03 18:01:56 +00:00
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"AbuseFilterEmergencyDisableThreshold": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"default": 0.05
},
Fix a typo in EmergencyDisable globals description And specify what we mean with "dangerous actions". Change-Id: Ida5827978b257cfdf61786c7e19c11a1dc74c664
2019-02-16 13:43:29 +00:00
"description": "Disable potentially dangerous actions (AbuseFilterRestrictions) of a filter if it matches more than X actions, constituting more than Y% (e.g. 0.05 = 5%) of the last Z actions, and the filter has been modified in the last S seconds. X is AbuseFilterEmergencyDisableCount, Y is AbuseFilterEmergencyDisableThreshold, S is AbuseFilterEmergencyDisableAge and Z is a number between 1 and AbuseFilterProfileActionsCap."
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"AbuseFilterEmergencyDisableCount": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"default": 2
},
"description": "See description for AbuseFilterEmergencyDisableThreshold"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"AbuseFilterEmergencyDisableAge": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"default": 86400
},
"description": "See description for AbuseFilterEmergencyDisableThreshold"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
Replace $wgAbuseFilterRestrictions with more specific variables So that sysadmins can further customize the extension. It was also wrong to use the same variable for many different things. Note that there's no associated patch in wmf-config because we use the defaults. However, before merging this patch, please recheck that AbuseFilterRestrictions and AbuseFilterDisallowGlobalLocalBlocks aren't used there (https://codesearch.wmflabs.org/operations/?q=AbuseFilterDisallowGlobalLocalBlocks%7CAbuseFilterRestrictions&i=nope&files=&repos=) Bug: T175221 Change-Id: I7581b3ee6d9d11a6cf1599b8ff874e8c3d54adf4
2018-09-22 10:18:50 +00:00
"AbuseFilterActionRestrictions": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"throttle": false,
"warn": false,
"disallow": false,
"blockautopromote": true,
"block": true,
"rangeblock": true,
"degroup": true,
"tag": false
},
"description": "Do users need 'abusefilter-modify-restricted' user right as well as 'abusefilter-modify' in order to create or modify filters which carry out this action? Array like [action name => is restricted?]"
},
"AbuseFilterNotifications": {
"value": false,
"description": "Allows to configure the extension to send hit notifications to Special:RecentChanges or UDP. Available options: rc, udp, rcandudp"
},
"AbuseFilterNotificationsPrivate": {
"value": false,
"description": "Enable notifications for private filters"
},
"AbuseFilterCentralDB": {
"value": null,
Add tests for global filters Another crucial part to have covered. Also clarify that AbuseFilterCentralDB can be of the form "dbname-prefix". Remove a filter used for profiling and replace it with a global one: we're still fine, and the list is kept shorter. Bug: T201193 Depends-On: I5ee7ba44a6cd82a5ddb24fb4127af04d96e647f4 Change-Id: If6b91711534c0d60e1aa27bd5748c3023e29f376
2018-08-25 12:44:01 +00:00
"description": "Name of a database where global abuse filters will be stored in. To use a DB with prefixed tables, set this to \"{$databaseName}-{$prefix}\"."
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
},
"AbuseFilterIsCentral": {
"value": false,
"description": "Set this variable to true for the wiki where global AbuseFilters are stored in"
},
Replace $wgAbuseFilterRestrictions with more specific variables So that sysadmins can further customize the extension. It was also wrong to use the same variable for many different things. Note that there's no associated patch in wmf-config because we use the defaults. However, before merging this patch, please recheck that AbuseFilterRestrictions and AbuseFilterDisallowGlobalLocalBlocks aren't used there (https://codesearch.wmflabs.org/operations/?q=AbuseFilterDisallowGlobalLocalBlocks%7CAbuseFilterRestrictions&i=nope&files=&repos=) Bug: T175221 Change-Id: I7581b3ee6d9d11a6cf1599b8ff874e8c3d54adf4
2018-09-22 10:18:50 +00:00
"AbuseFilterLocallyDisabledGlobalActions": {
"value": {
"throttle": false,
"warn": false,
"disallow": false,
"blockautopromote": false,
"block": false,
"rangeblock": false,
"degroup": false,
"tag": false
},
Little cleanup for AbuseFilterRunner Remove outdated/pointless comments, use already defined variables, etc. Additionally, make it possible to disable throttling locally. Change-Id: I98fd5f3eb47b32fc1013360e462a57d932174a95
2020-10-17 14:37:49 +00:00
"description": "An array of actions which, if set on a global filter, will not be used for local hits of such filter (not in the central wiki). The array is [ action => will be disabled? ]. NOTE: Locally disabling throttle or warn will *not* disable the remaining actions."
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
},
"AbuseFilterBlockDuration": {
"value": "indefinite",
"description": "Old standard block duration for logged in users. Kept for backward compatibility after T32024."
},
"AbuseFilterAnonBlockDuration": {
"value": null,
"description": "Old standard block duration for anonymous users, $wgAbuseFilterBlockDuration will be used if null. Kept for backward compatibility after T32024."
},
Allow Blockautopromote duration to be configured for wikis. Rather than always using 5 days, the length (in days) can be configured by setting `AbuseFilterBlockAutopromoteDuration` to the desired length. Bug: T231756 Change-Id: I996e08a9099ab59657fe511ec2934d26edfa5c7b
2019-09-15 04:09:02 +00:00
"AbuseFilterBlockAutopromoteDuration": {
"value": 5,
"description": "Duration, in days, for which users' autopromotion is blocked by filters."
},
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"AbuseFilterCustomActionsHandlers": {
"value": [],
Add a hook for extensions to add custom actions The global is now deprecated, and it will be removed soon. Bug: T265794 Change-Id: I4e6c9b143744cb72c441017921bac9cd1960609c
2020-11-29 22:20:32 +00:00
"description": "Callback functions for custom actions. DEPRECATED since 1.36! Use the AbuseFilterCustomActions hook instead."
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
},
"AbuseFilterValidGroups": {
"value": [ "default" ],
"description": "The list of 'groups' filters can be divided into – used for applying edit filters to certain types of actions. By default there is only one group."
Change some globals to work better with extension registration Rename $wgAbuseFilterAvailableActions / $wgAbuseFilterRestrictedActions to $wgAbuseFilterActions / $wgAbuseFilterRestrictions and make them an associative array instead of a plain one, as that works more sanely with extension registration. (The renaming helps to give more useful errors to sites using the old config.) Change-Id: I790d39c2849922d7daf7479f298cd90cf30af129
2016-06-03 18:01:56 +00:00
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"AbuseFilterDefaultWarningMessage": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"default": "abusefilter-warning"
},
"description": "Default warning messages, per filter group"
},
Allow selecting custom disallow message You can now select a custom message to be displayed for disallowing a edit the same way as for warn mode. This can be the same or a totally different message. This also solves the usecase, when a edit filter is set to warn AND disallow, to be able to show the user a custom message, but the generic is shown on the second try (disallow). Now it can be only set to disallow. Bug: T27086 Change-Id: Ic1de03a6944c43a346fa317ee0a217551f0d284a
2014-10-04 14:42:46 +00:00
"AbuseFilterDefaultDisallowMessage": {
"value": {
"default": "abusefilter-disallowed"
},
Remove incorrect merge_strategy definitions Those merge strategies aren't needed because array_plus is for when the keys of the array are integers, not necessarily the values. Change-Id: I164723c4cc6b12cd6e4ce0d49c74d93eda5d871d
2020-05-12 19:48:36 +00:00
"description": "Default disallow messages, per filter group"
Allow selecting custom disallow message You can now select a custom message to be displayed for disallowing a edit the same way as for warn mode. This can be the same or a totally different message. This also solves the usecase, when a edit filter is set to warn AND disallow, to be able to show the user a custom message, but the generic is shown on the second try (disallow). Now it can be only set to disallow. Bug: T27086 Change-Id: Ic1de03a6944c43a346fa317ee0a217551f0d284a
2014-10-04 14:42:46 +00:00
},
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"AbuseFilterLogIPMaxAge": {
"value": 7776000,
"description": "Age used as cutoff when purging old IP log data, defaults to 3 months. Used by maintenance script purgeOldLogIPData.php"
},
"AbuseFilterSlowFilterRuntimeLimit": {
"value": 500,
"description": "Runtime in milliseconds before a filter is considered slow."
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
Move actions limit to a global variable This opens the door to further customization and allows every wiki to set its own value. Bug: T132925 Change-Id: I63985f2809c3253b07b33caef30fcd8d4c62dfd4
2018-04-04 18:29:50 +00:00
"AbuseFilterProfileActionsCap": {
"value": 10000,
"description": "Number of action that determines when to reset profiling stats."
},
Overhaul Blockautopromote action As for all mostly unused consequences, blockautopromote has a couple of major problems: first, it blocked the status for a random time between 3 and 7 days, which to me makes no sense at all (is it some sort of casino?), and this patch fixes it to 5 days. Second, nothing was logged, not the blocking nor the unblocking. Here I'm adding a LogHandler for two new sub-actions of 'rights' to keep track of both action. Bug: T49412 Change-Id: If48a48f5b8baaf9e77c0826466f5d03bb7f691d0
2018-07-16 12:10:36 +00:00
"AbuseFilterRangeBlockSize": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"IPv4": 16,
"IPv6": 19
},
"description": "Size of the range blocked by 'rangeblock' action."
},
Use "privatedetails" instead of "private" where needed To keep a clear distinction between "private details" (i.e. user's ip) and "private filters" (i.e. not publicly viewable). This patch renames rights, i18n keys and methods names. The patch for renaming globals and rights in WMF config is I7e6b3d4453403edb6aa602587374b4ff5b6d625f. Bug: T211004 Change-Id: I613dbadb8f75c8c4116a362607563a436a73d321
2019-01-07 15:23:21 +00:00
"AbuseFilterLogPrivateDetailsAccess": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": false,
Fix extension doc for AbuseFilterPrivateLog This variable is actually here to determine whether accessing private info should be logged, not if it's possible to access such info. In fact, you can still do it if this variable is set to false. Change-Id: Ieba191bff4ea56eb166bbbd03cb7b1a05ca42c52
2018-07-16 13:32:38 +00:00
"description": "Whether accessing private information from a filter log entry is logged."
Log accessing private information in abuse filter logs Bug: T152934 Change-Id: I8049df3b2b9343a6877e9a306d2781d3f27ec657
2016-12-12 16:30:06 +00:00
},
Use "privatedetails" instead of "private" where needed To keep a clear distinction between "private details" (i.e. user's ip) and "private filters" (i.e. not publicly viewable). This patch renames rights, i18n keys and methods names. The patch for renaming globals and rights in WMF config is I7e6b3d4453403edb6aa602587374b4ff5b6d625f. Bug: T211004 Change-Id: I613dbadb8f75c8c4116a362607563a436a73d321
2019-01-07 15:23:21 +00:00
"AbuseFilterPrivateDetailsForceReason": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": false,
"description": "Whether users are forced to provide a reason for accessing private information from a filter log entry."
},
"AbuseFilterLogIP": {
"value": true,
"description": "Whether to include IP in the abuse_filter_log"
Split afl_filter in afl_filter_id and afl_global Add a script to migrate the columns (which can also be executed in dry run), and a config option with the migration stage (defaults to SCHEMA_COMPAT_OLD). Some of the script-related code is stolen from Ic755526d5f989c4a66b1d37527cda235f61cb437. Bug: T220791 Change-Id: I7460a2d63f60c2933b36f8383a8abdbba8649e12
2018-09-11 16:57:49 +00:00
},
"AbuseFilterAflFilterMigrationStage": {
"value": "Bogus value - set in AbuseFilterHooks::onRegistration",
"description": "Stage of the migration of afl_filter to afl_filter_id and afl_global. Should be one of the following (combinations of) constants: SCHEMA_COMPAT_OLD, SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_OLD, SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_NEW, SCHEMA_COMPAT_NEW. For a detailed migration guide, see https://phabricator.wikimedia.org/T220791#5496752 § Method 1."
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
}
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"load_composer_autoloader": true,
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"manifest_version": 2
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
}
Reference in a new issue Copy permalink