wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-11-12 00:38:23 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-AbuseF.../extension.json

424 lines
15 KiB
JSON
Raw Normal View History

Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
{
"name": "Abuse Filter",
"author": [
"Andrew Garrett",
Add `Daimona Eaytoy` to authors Daimona has been an extraordinary maintainer of this tool and has also implemented new features on Abuse Filter, so I guess it is just and fair to include his name to this list. Hyperlink is because `Daimona Eaytoy` is not a real name, according to his mediawiki.org userpage (can be removed if required; the law accepts authorship attributed to pseudonyms). In addition, the list of authors has been sorted alphabetically by name. If you prefer to order it by family name instead, please let me know. Change-Id: I6a3b0a757f9fd2af09358298e55a8b0487ce5b32
2019-07-04 10:22:20 +00:00
"[https://www.mediawiki.org/wiki/User:Daimona_Eaytoy Daimona Eaytoy]",
"Marius Hoch",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"River Tarnell",
Add `Daimona Eaytoy` to authors Daimona has been an extraordinary maintainer of this tool and has also implemented new features on Abuse Filter, so I guess it is just and fair to include his name to this list. Hyperlink is because `Daimona Eaytoy` is not a real name, according to his mediawiki.org userpage (can be removed if required; the law accepts authorship attributed to pseudonyms). In addition, the list of authors has been sorted alphabetically by name. If you prefer to order it by family name instead, please let me know. Change-Id: I6a3b0a757f9fd2af09358298e55a8b0487ce5b32
2019-07-04 10:22:20 +00:00
"Victor Vasiliev"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
],
"url": "https://www.mediawiki.org/wiki/Extension:AbuseFilter",
"descriptionmsg": "abusefilter-desc",
Use SPDX 3.0 license identifier SPDX released version 3 of their license list (<https://spdx.org/licenses/>), which changed the FSF licenses to explicitly end in -only or -or-later instead of relying on an easy to miss + symbol. Bug: T183858 Change-Id: Ib7a48d3a432f12ce1c27fe989e85a80335a25801
2018-01-04 03:01:35 +00:00
"license-name": "GPL-2.0-or-later",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"type": "antispam",
"requires": {
Move test-only classes to new TestAutoloadClasses declaration Bug: T196090 Depends-On: I88cf69663362fd599c20649b1df641907a02678d Change-Id: I5e3ef040628c4ff629a8aabc56a3b8ba259b7e78
2019-12-10 19:40:18 +00:00
"MediaWiki": ">= 1.35.0"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"AvailableRights": [
"abusefilter-modify",
"abusefilter-log-detail",
"abusefilter-view",
"abusefilter-log",
Use "privatedetails" instead of "private" where needed To keep a clear distinction between "private details" (i.e. user's ip) and "private filters" (i.e. not publicly viewable). This patch renames rights, i18n keys and methods names. The patch for renaming globals and rights in WMF config is I7e6b3d4453403edb6aa602587374b4ff5b6d625f. Bug: T211004 Change-Id: I613dbadb8f75c8c4116a362607563a436a73d321
2019-01-07 15:23:21 +00:00
"abusefilter-privatedetails",
"abusefilter-privatedetails-log",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"abusefilter-modify-restricted",
"abusefilter-revert",
"abusefilter-view-private",
"abusefilter-log-private",
"abusefilter-hidden-log",
"abusefilter-hide-log",
"abusefilter-modify-global"
],
Add default rights config Add a conservative default configuration so that admins can use abuse filters without any need for manual setup, and users can see what's happening. Also expand grants a bit. Bug: T191740 Change-Id: I4e3125a708277474f416903928397db7f8fb850d
2018-04-08 17:46:18 +00:00
"GroupPermissions": {
"*": {
"abusefilter-view": true,
"abusefilter-log": true
},
"sysop": {
"abusefilter-log-detail": true,
Rearrange config to provide better experience In order to bundle AbuseFilter, we have to provide an optimal configuration for sysadmins. This patch aims to provide such configuration, and of course it's open to changes. Changed values: *Grant abusefilter-view-private to admins. This is mostly for redundancy-safety (they already have -modify) *Grant modify-restricted to admins (see T200032) *Disable the 'degroup' action. This is really dangerous, not ideal to be enabled by default. *Grant the abusefilter-revert right to sysops. This is similar to assigning the modify-restricted right in its rationale. *Add abusefilter-log-private to viewrestrictedlogs grant. This right should go together with abusefilter-view-private. (T226987) *Remove abusefilter-revert from the rollback grant, as that right is for reverting AF actions and has nothing to do with rollbacks. This mostly copies the config of WMF production: degrouping is already disabled there, and modify-restricted should be assigned to sysops on WMF wikis as well. The assignment of the abusefilter-view-private and abusefiliter-revert rights is handled in I09cb462312c5bbc71ee3a8f0fbd91357908130d4 (parent patch) to keep the status quo. NOTE: this patch should be *deployed* together with the config patch to avoid discontinuities. Thus, please ONLY provide a virtual +2 using a +1, and I'll coordinate the +2 with a deployer. Bug: T191740 Bug: T200032 Bug: T226987 Depends-On: I09cb462312c5bbc71ee3a8f0fbd91357908130d4 Change-Id: I58f215b8aa3444602532098a3c9dfd25409f29eb
2018-10-20 10:24:53 +00:00
"abusefilter-view-private": true,
"abusefilter-log-private": true,
"abusefilter-modify": true,
"abusefilter-modify-restricted": true,
"abusefilter-revert": true
},
"suppress": {
"abusefilter-hidden-log": true,
"abusefilter-hide-log": true
Add default rights config Add a conservative default configuration so that admins can use abuse filters without any need for manual setup, and users can see what's happening. Also expand grants a bit. Bug: T191740 Change-Id: I4e3125a708277474f416903928397db7f8fb850d
2018-04-08 17:46:18 +00:00
}
},
"GrantPermissions": {
"basic": {
"abusefilter-log": true,
add grant to view private abusefilter log entries Bug: T191703 Change-Id: I56233786ddaa6c44e6778b56070cf9b13df20dcc
2018-04-07 19:45:28 +00:00
"abusefilter-log-detail": true,
"abusefilter-view": true
Add default rights config Add a conservative default configuration so that admins can use abuse filters without any need for manual setup, and users can see what's happening. Also expand grants a bit. Bug: T191740 Change-Id: I4e3125a708277474f416903928397db7f8fb850d
2018-04-08 17:46:18 +00:00
},
Rearrange config to provide better experience In order to bundle AbuseFilter, we have to provide an optimal configuration for sysadmins. This patch aims to provide such configuration, and of course it's open to changes. Changed values: *Grant abusefilter-view-private to admins. This is mostly for redundancy-safety (they already have -modify) *Grant modify-restricted to admins (see T200032) *Disable the 'degroup' action. This is really dangerous, not ideal to be enabled by default. *Grant the abusefilter-revert right to sysops. This is similar to assigning the modify-restricted right in its rationale. *Add abusefilter-log-private to viewrestrictedlogs grant. This right should go together with abusefilter-view-private. (T226987) *Remove abusefilter-revert from the rollback grant, as that right is for reverting AF actions and has nothing to do with rollbacks. This mostly copies the config of WMF production: degrouping is already disabled there, and modify-restricted should be assigned to sysops on WMF wikis as well. The assignment of the abusefilter-view-private and abusefiliter-revert rights is handled in I09cb462312c5bbc71ee3a8f0fbd91357908130d4 (parent patch) to keep the status quo. NOTE: this patch should be *deployed* together with the config patch to avoid discontinuities. Thus, please ONLY provide a virtual +2 using a +1, and I'll coordinate the +2 with a deployer. Bug: T191740 Bug: T200032 Bug: T226987 Depends-On: I09cb462312c5bbc71ee3a8f0fbd91357908130d4 Change-Id: I58f215b8aa3444602532098a3c9dfd25409f29eb
2018-10-20 10:24:53 +00:00
"oversight": {
"abusefilter-hide-log": true
Add default rights config Add a conservative default configuration so that admins can use abuse filters without any need for manual setup, and users can see what's happening. Also expand grants a bit. Bug: T191740 Change-Id: I4e3125a708277474f416903928397db7f8fb850d
2018-04-08 17:46:18 +00:00
},
"viewrestrictedlogs": {
add grant to view private abusefilter log entries Bug: T191703 Change-Id: I56233786ddaa6c44e6778b56070cf9b13df20dcc
2018-04-07 19:45:28 +00:00
"abusefilter-hidden-log": true,
Rearrange config to provide better experience In order to bundle AbuseFilter, we have to provide an optimal configuration for sysadmins. This patch aims to provide such configuration, and of course it's open to changes. Changed values: *Grant abusefilter-view-private to admins. This is mostly for redundancy-safety (they already have -modify) *Grant modify-restricted to admins (see T200032) *Disable the 'degroup' action. This is really dangerous, not ideal to be enabled by default. *Grant the abusefilter-revert right to sysops. This is similar to assigning the modify-restricted right in its rationale. *Add abusefilter-log-private to viewrestrictedlogs grant. This right should go together with abusefilter-view-private. (T226987) *Remove abusefilter-revert from the rollback grant, as that right is for reverting AF actions and has nothing to do with rollbacks. This mostly copies the config of WMF production: degrouping is already disabled there, and modify-restricted should be assigned to sysops on WMF wikis as well. The assignment of the abusefilter-view-private and abusefiliter-revert rights is handled in I09cb462312c5bbc71ee3a8f0fbd91357908130d4 (parent patch) to keep the status quo. NOTE: this patch should be *deployed* together with the config patch to avoid discontinuities. Thus, please ONLY provide a virtual +2 using a +1, and I'll coordinate the +2 with a deployer. Bug: T191740 Bug: T200032 Bug: T226987 Depends-On: I09cb462312c5bbc71ee3a8f0fbd91357908130d4 Change-Id: I58f215b8aa3444602532098a3c9dfd25409f29eb
2018-10-20 10:24:53 +00:00
"abusefilter-log-private": true,
add grant to view private abusefilter log entries Bug: T191703 Change-Id: I56233786ddaa6c44e6778b56070cf9b13df20dcc
2018-04-07 19:45:28 +00:00
"abusefilter-view-private": true
Add default rights config Add a conservative default configuration so that admins can use abuse filters without any need for manual setup, and users can see what's happening. Also expand grants a bit. Bug: T191740 Change-Id: I4e3125a708277474f416903928397db7f8fb850d
2018-04-08 17:46:18 +00:00
}
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"SpecialPages": {
Use LinkBatchFactory in Special:AbuseLog Change-Id: I2ccf9cd36475a65e61ad0e80ec159f841849089f
2020-08-07 21:48:47 +00:00
"AbuseLog": {
"class": "SpecialAbuseLog",
"services": [
"LinkBatchFactory"
]
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"AbuseFilter": "SpecialAbuseFilter"
},
"LogTypes": [
Log accessing private information in abuse filter logs Bug: T152934 Change-Id: I8049df3b2b9343a6877e9a306d2781d3f27ec657
2016-12-12 16:30:06 +00:00
"abusefilter",
"abusefilterprivatedetails"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
],
"LogNames": {
Log accessing private information in abuse filter logs Bug: T152934 Change-Id: I8049df3b2b9343a6877e9a306d2781d3f27ec657
2016-12-12 16:30:06 +00:00
"abusefilter": "abusefilter-log-name",
"abusefilterprivatedetails": "abusefilterprivatedetails-log-name"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"LogHeaders": {
"abusefilter": "abusefilter-log-header"
},
"LogActionsHandlers": {
Migrate abusefilter/modify log Bug: T32553 Change-Id: I7e33d1064329124755c77ffe6efbd5d572f43cb9
2016-06-04 13:33:32 +00:00
"abusefilter/hit": "AbuseLogHitFormatter",
Actually mark abusefilter creations as such in the AbuseFilter log Bug: T178283 Co-Authored-By: Matěj Suchánek <matejsuchanek97@gmail.com> Change-Id: I89776eff2fc420b1fe3e2c3b88671749fadb57b4
2017-10-16 11:19:30 +00:00
"abusefilter/modify": "AbuseFilterModifyLogFormatter",
Log accessing private information in abuse filter logs Bug: T152934 Change-Id: I8049df3b2b9343a6877e9a306d2781d3f27ec657
2016-12-12 16:30:06 +00:00
"abusefilter/create": "AbuseFilterModifyLogFormatter",
Migrate AbuseFilter suppress log Also make entries in Special:Log/suppress filterable. Change-Id: Ic23e724997e4748c8d0da8138aa73d31b17b7064
2017-02-15 18:12:31 +00:00
"abusefilterprivatedetails/access": "LogFormatter",
"suppress/hide-afl": "AbuseFilterSuppressLogFormatter",
Overhaul Blockautopromote action As for all mostly unused consequences, blockautopromote has a couple of major problems: first, it blocked the status for a random time between 3 and 7 days, which to me makes no sense at all (is it some sort of casino?), and this patch fixes it to 5 days. Second, nothing was logged, not the blocking nor the unblocking. Here I'm adding a LogHandler for two new sub-actions of 'rights' to keep track of both action. Bug: T49412 Change-Id: If48a48f5b8baaf9e77c0826466f5d03bb7f691d0
2018-07-16 12:10:36 +00:00
"suppress/unhide-afl": "AbuseFilterSuppressLogFormatter",
"rights/blockautopromote": "AbuseFilterRightsLogFormatter",
"rights/restoreautopromote": "AbuseFilterRightsLogFormatter"
Actually mark abusefilter creations as such in the AbuseFilter log Bug: T178283 Co-Authored-By: Matěj Suchánek <matejsuchanek97@gmail.com> Change-Id: I89776eff2fc420b1fe3e2c3b88671749fadb57b4
2017-10-16 11:19:30 +00:00
},
"ActionFilteredLogs": {
"abusefilter": {
"modify": [
"modify"
],
"create": [
"create"
]
}
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
Log accessing private information in abuse filter logs Bug: T152934 Change-Id: I8049df3b2b9343a6877e9a306d2781d3f27ec657
2016-12-12 16:30:06 +00:00
"LogRestrictions": {
Restrict viewing Special:Log/AbuseFilter, and remove from recent changes Only allow users with `abusefilter-view` to see abuse filter log entries. Note that this is different from the abuse log itself. Bug: T34959 Change-Id: I587c2eb9bdc2e5ca2652aa338440cdc5b6eb9235
2019-11-10 10:33:51 +00:00
"abusefilter": "abusefilter-view",
Use "privatedetails" instead of "private" where needed To keep a clear distinction between "private details" (i.e. user's ip) and "private filters" (i.e. not publicly viewable). This patch renames rights, i18n keys and methods names. The patch for renaming globals and rights in WMF config is I7e6b3d4453403edb6aa602587374b4ff5b6d625f. Bug: T211004 Change-Id: I613dbadb8f75c8c4116a362607563a436a73d321
2019-01-07 15:23:21 +00:00
"abusefilterprivatedetails": "abusefilter-privatedetails-log"
Log accessing private information in abuse filter logs Bug: T152934 Change-Id: I8049df3b2b9343a6877e9a306d2781d3f27ec657
2016-12-12 16:30:06 +00:00
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"APIModules": {
"abusefilterchecksyntax": "ApiAbuseFilterCheckSyntax",
"abusefilterevalexpression": "ApiAbuseFilterEvalExpression",
"abusefilterunblockautopromote": "ApiAbuseFilterUnblockAutopromote",
Add a new API module to retrieve private details from AbuseLog Follow-up of Iaca492371f48fecf543268c179a651841ed12c3f. This patch adds the new module, plus some technical changes to private details-related methods and globals. Bug: T210329 Depends-On: I613dbadb8f75c8c4116a362607563a436a73d321 Change-Id: I3c45b74c36c191083df184ed57416067a75f6591
2018-12-04 09:37:48 +00:00
"abusefiltercheckmatch": "ApiAbuseFilterCheckMatch",
"abuselogprivatedetails": "ApiAbuseLogPrivateDetails"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"APIListModules": {
"abuselog": "ApiQueryAbuseLog",
"abusefilters": "ApiQueryAbuseFilters"
},
"MessagesDirs": {
"AbuseFilter": [
Move all apihelp translatable messages to separate files Should be merged along with Ib66f4614285411e5fd971dc0cb4291ea8113418c Bug: T189982 Change-Id: Id9beb08ee34e6861543cf59d80abfac616bf9238
2018-03-19 16:07:25 +00:00
"i18n",
"i18n/api"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
]
},
"ExtensionMessagesFiles": {
"AbuseFilterAliases": "AbuseFilter.alias.php"
},
Move variable generators to new classes RunVariableGenerator is for generating variables based on the current action; RowVariableGenerator is for RC entries; VariableGenerator is the generic one. This patch only moves the methods to the new classes, to keep the diff easier to read, and facilitate conflict resolution. These classes will then be revamped in I366d598b69ad866496b7cb0059e0835c02e54041. Note that these classes are now namespaced. One method, AbuseFilter::getEditVars, was renamed to AbuseFilterVariableGenerator::generateEditVars, because it would otherwise conflict with an incompatible method in RunVariableGenerator. Change-Id: Iff412e5492873d4fae55402939a51609e64d55a8
2020-01-11 17:05:30 +00:00
"AutoloadNamespaces": {
"MediaWiki\\Extension\\AbuseFilter\\VariableGenerator\\": "includes/VariableGenerator/"
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"AutoloadClasses": {
Rename files to match class name Change-Id: Ia19bfec6c2289912699b6c90261afda311afb56e
2018-03-30 00:50:44 +00:00
"AbuseFilter": "includes/AbuseFilter.php",
Move various classes to their own files Change-Id: I5d418b3fa27aa6e04b9a680922e5eab2439ffb20
2016-12-17 17:52:36 +00:00
"AbuseFilterCachingParser" : "includes/parser/AbuseFilterCachingParser.php",
"AbuseFilterParser": "includes/parser/AbuseFilterParser.php",
"AbuseFilterTokenizer": "includes/parser/AbuseFilterTokenizer.php",
Rename files to match class name Change-Id: Ia19bfec6c2289912699b6c90261afda311afb56e
2018-03-30 00:50:44 +00:00
"AbuseFilterHooks": "includes/AbuseFilterHooks.php",
Move various classes to their own files Change-Id: I5d418b3fa27aa6e04b9a680922e5eab2439ffb20
2016-12-17 17:52:36 +00:00
"AbuseFilterPreAuthenticationProvider": "includes/AbuseFilterPreAuthenticationProvider.php",
Add a new class for methods related to running filters Currently we strongly abuse (pardon the pun) the AbuseFilter class: its purpose should be to hold static functions intended as generic utility functions (e.g. to format messages, determine whether a filter is global etc.), but we actually use it for all methods related to running filters. This patch creates a new class, AbuseFilterRunner, containing all such methods, which have been made non-static. This leads to several improvements (also for related methods and the parser), and opens the way to further improve the code. Aside from making the code prettier, less global and easier to test, this patch could also produce a performance improvement, although I don't have tools to measure that. Also note that many public methods have been removed, and almost any of them has been made protected; a couple of them (the ones used from outside) are left for back-compat, and will be removed in the future. Change-Id: I2eab2e50356eeb5224446ee2d0df9c787ae95b80
2018-12-07 17:46:02 +00:00
"AbuseFilterRunner": "includes/AbuseFilterRunner.php",
Add a parent class for special pages This allows us to extract yet another static method from the AbuseFilter class. This class should be expanded in the future, and an example use case could be Ia5fd4f0b35fcabf045a7b49fa40fa85b72c92544. Depends-On: I7c0170167b508132cd16e566c654a6c98dd683e9 Change-Id: I1bb45e47c3b42c01388b99778ce833e4e44419e1
2019-02-08 17:45:25 +00:00
"AbuseFilterSpecialPage": "includes/special/AbuseFilterSpecialPage.php",
Normalize file layout Aka move all code into includes/. Change-Id: I21f7b80bb6df04abbed6bfccb94f92100dc8f071
2017-08-07 23:11:38 +00:00
"SpecialAbuseLog": "includes/special/SpecialAbuseLog.php",
Move classes to own files Makes MediaWiki.Files.OneClassPerFile.MultipleFound pass Change-Id: I3b08a69fe7990d6fe5f71cda51d6ac01f11aad2d
2017-12-16 00:26:25 +00:00
"AbuseLogPager": "includes/pagers/AbuseLogPager.php",
Normalize file layout Aka move all code into includes/. Change-Id: I21f7b80bb6df04abbed6bfccb94f92100dc8f071
2017-08-07 23:11:38 +00:00
"SpecialAbuseFilter": "includes/special/SpecialAbuseFilter.php",
Move various classes to their own files Change-Id: I5d418b3fa27aa6e04b9a680922e5eab2439ffb20
2016-12-17 17:52:36 +00:00
"AbuseLogHitFormatter": "includes/AbuseLogHitFormatter.php",
Migrate abusefilter/modify log Bug: T32553 Change-Id: I7e33d1064329124755c77ffe6efbd5d572f43cb9
2016-06-04 13:33:32 +00:00
"AbuseFilterModifyLogFormatter": "includes/AbuseFilterModifyLogFormatter.php",
Migrate AbuseFilter suppress log Also make entries in Special:Log/suppress filterable. Change-Id: Ic23e724997e4748c8d0da8138aa73d31b17b7064
2017-02-15 18:12:31 +00:00
"AbuseFilterSuppressLogFormatter": "includes/AbuseFilterSuppressLogFormatter.php",
Overhaul Blockautopromote action As for all mostly unused consequences, blockautopromote has a couple of major problems: first, it blocked the status for a random time between 3 and 7 days, which to me makes no sense at all (is it some sort of casino?), and this patch fixes it to 5 days. Second, nothing was logged, not the blocking nor the unblocking. Here I'm adding a LogHandler for two new sub-actions of 'rights' to keep track of both action. Bug: T49412 Change-Id: If48a48f5b8baaf9e77c0826466f5d03bb7f691d0
2018-07-16 12:10:36 +00:00
"AbuseFilterRightsLogFormatter": "includes/AbuseFilterRightsLogFormatter.php",
Normalize file layout Aka move all code into includes/. Change-Id: I21f7b80bb6df04abbed6bfccb94f92100dc8f071
2017-08-07 23:11:38 +00:00
"AbuseFilterViewList": "includes/Views/AbuseFilterViewList.php",
Move classes to own files Makes MediaWiki.Files.OneClassPerFile.MultipleFound pass Change-Id: I3b08a69fe7990d6fe5f71cda51d6ac01f11aad2d
2017-12-16 00:26:25 +00:00
"AbuseFilterPager": "includes/pagers/AbuseFilterPager.php",
"GlobalAbuseFilterPager": "includes/pagers/GlobalAbuseFilterPager.php",
Normalize file layout Aka move all code into includes/. Change-Id: I21f7b80bb6df04abbed6bfccb94f92100dc8f071
2017-08-07 23:11:38 +00:00
"AbuseFilterView": "includes/Views/AbuseFilterView.php",
"AbuseFilterViewEdit": "includes/Views/AbuseFilterViewEdit.php",
"AbuseFilterViewTools": "includes/Views/AbuseFilterViewTools.php",
"AbuseFilterViewHistory": "includes/Views/AbuseFilterViewHistory.php",
Move classes to own files Makes MediaWiki.Files.OneClassPerFile.MultipleFound pass Change-Id: I3b08a69fe7990d6fe5f71cda51d6ac01f11aad2d
2017-12-16 00:26:25 +00:00
"AbuseFilterHistoryPager": "includes/pagers/AbuseFilterHistoryPager.php",
Normalize file layout Aka move all code into includes/. Change-Id: I21f7b80bb6df04abbed6bfccb94f92100dc8f071
2017-08-07 23:11:38 +00:00
"AbuseFilterViewRevert": "includes/Views/AbuseFilterViewRevert.php",
"AbuseFilterViewTestBatch": "includes/Views/AbuseFilterViewTestBatch.php",
"AbuseFilterViewExamine": "includes/Views/AbuseFilterViewExamine.php",
Move classes to own files Makes MediaWiki.Files.OneClassPerFile.MultipleFound pass Change-Id: I3b08a69fe7990d6fe5f71cda51d6ac01f11aad2d
2017-12-16 00:26:25 +00:00
"AbuseFilterExaminePager": "includes/pagers/AbuseFilterExaminePager.php",
"AbuseFilterChangesList": "includes/AbuseFilterChangesList.php",
Normalize file layout Aka move all code into includes/. Change-Id: I21f7b80bb6df04abbed6bfccb94f92100dc8f071
2017-08-07 23:11:38 +00:00
"AbuseFilterViewDiff": "includes/Views/AbuseFilterViewDiff.php",
Move classes to own files Makes MediaWiki.Files.OneClassPerFile.MultipleFound pass Change-Id: I3b08a69fe7990d6fe5f71cda51d6ac01f11aad2d
2017-12-16 00:26:25 +00:00
"TableDiffFormatterFullContext": "includes/TableDiffFormatterFullContext.php",
Normalize file layout Aka move all code into includes/. Change-Id: I21f7b80bb6df04abbed6bfccb94f92100dc8f071
2017-08-07 23:11:38 +00:00
"AbuseFilterViewImport": "includes/Views/AbuseFilterViewImport.php",
Move AbuseFilterVariableHolder up to /includes This class is not for parsing logic or tree nodes Change-Id: I07a499cc972c30fc249ec4de3250900a3b703443
2016-12-19 01:13:06 +00:00
"AbuseFilterVariableHolder": "includes/AbuseFilterVariableHolder.php",
Move various classes to their own files Change-Id: I5d418b3fa27aa6e04b9a680922e5eab2439ffb20
2016-12-17 17:52:36 +00:00
"AFComputedVariable": "includes/AFComputedVariable.php",
"AFPData": "includes/parser/AFPData.php",
"AFPException": "includes/parser/AFPException.php",
"AFPParserState": "includes/parser/AFPParserState.php",
"AFPToken": "includes/parser/AFPToken.php",
Add a base class for parser transition Change-Id: I31282b8632c332b6d46a6bb4a42f57ac0d005b5f
2019-11-30 12:13:07 +00:00
"AFPTransitionBase": "includes/parser/AFPTransitionBase.php",
Move various classes to their own files Change-Id: I5d418b3fa27aa6e04b9a680922e5eab2439ffb20
2016-12-17 17:52:36 +00:00
"AFPTreeNode": "includes/parser/AFPTreeNode.php",
Add a new class for the CachingParser's AST This allows a little bit more of abstraction: we can store other data in the tree, without having to store it in a specific node (e.g. the variables map, which is still unused). It also adds a few typehints, and specializes the return value of eval'ing the AST: previously, it was the one of evalNode, which wasn't guaranteed to be an AFPData. Now we have this guarantee. Last but not least, we can now measure runtime metrics for evalTree, which doesn't recurse. Bonus: fix a check in the old parser, which used the wrong variable when reporting outofbounds errors. Change-Id: Iff806793b1d968e9bb6220f1459f3d0ac587c7da
2019-08-24 09:48:20 +00:00
"AFPSyntaxTree": "includes/parser/AFPSyntaxTree.php",
Move various classes to their own files Change-Id: I5d418b3fa27aa6e04b9a680922e5eab2439ffb20
2016-12-17 17:52:36 +00:00
"AFPTreeParser": "includes/parser/AFPTreeParser.php",
"AFPUserVisibleException": "includes/parser/AFPUserVisibleException.php",
Normalize file layout Aka move all code into includes/. Change-Id: I21f7b80bb6df04abbed6bfccb94f92100dc8f071
2017-08-07 23:11:38 +00:00
"ApiQueryAbuseLog": "includes/api/ApiQueryAbuseLog.php",
"ApiQueryAbuseFilters": "includes/api/ApiQueryAbuseFilters.php",
"ApiAbuseFilterCheckSyntax": "includes/api/ApiAbuseFilterCheckSyntax.php",
"ApiAbuseFilterEvalExpression": "includes/api/ApiAbuseFilterEvalExpression.php",
"ApiAbuseFilterUnblockAutopromote": "includes/api/ApiAbuseFilterUnblockAutopromote.php",
Change throttle selector to restore old functionality, overall improvement Long (sigh) explanation in T203587#4569698. Also, simplified the way TagMultiselect are generated, this one and the one for change tags. This new selector is back-compat both with the old textarea and the OOUI checkboxMultiselect; actually, this one is //fully// compatible with the old textarea. Add validation for throttle parameters and unit tests for validation (split from I976c95658cddb2585910b6f8a5f047aadc4e4d47). Added a trim when retrieving throttle identifier to allow syntax like 'ip, user'. Improved the message shown on history. Re-added the maintenance script to clean DB. As I wrote in the task, a review by two other people would be great, at least for the maintenance script (it could potentially break the DB). Bug: T203587 Bug: T203336 Bug: T203584 Bug: T203585 Depends-On: I3b2e763bd8835207dc5df1db43d3e1881e6961c3 Change-Id: I7831dbb0bab55807392ac1f7915d6cb0cb713593
2018-09-09 10:14:31 +00:00
"ApiAbuseFilterCheckMatch": "includes/api/ApiAbuseFilterCheckMatch.php",
Add a new API module to retrieve private details from AbuseLog Follow-up of Iaca492371f48fecf543268c179a651841ed12c3f. This patch adds the new module, plus some technical changes to private details-related methods and globals. Bug: T210329 Depends-On: I613dbadb8f75c8c4116a362607563a436a73d321 Change-Id: I3c45b74c36c191083df184ed57416067a75f6591
2018-12-04 09:37:48 +00:00
"ApiAbuseLogPrivateDetails": "includes/api/ApiAbuseLogPrivateDetails.php",
Add tests for global filters Another crucial part to have covered. Also clarify that AbuseFilterCentralDB can be of the form "dbname-prefix". Remove a filter used for profiling and replace it with a global one: we're still fine, and the list is kept shorter. Bug: T201193 Depends-On: I5ee7ba44a6cd82a5ddb24fb4127af04d96e647f4 Change-Id: If6b91711534c0d60e1aa27bd5748c3023e29f376
2018-08-25 12:44:01 +00:00
"NormalizeThrottleParameters": "maintenance/normalizeThrottleParameters.php",
Add a maintenance script to clean afl_var_dump This script aims to fix every problem reported in T213006. Subsequent patches will add new code and drop the back-compat one. Bug: T213006 Bug: T187153 Bug: T204236 Bug: T187731 Bug: T204235 Bug: T214193 Bug: T214196 Bug: T34478 Depends-On: I5b29ff556eca45fe59d15e2e3df4d06f1f6b3934 Change-Id: I22cf698c5be77506727cbd227c67e037a5d89b5c
2019-01-06 13:52:06 +00:00
"FixOldLogEntries": "maintenance/fixOldLogEntries.php",
"UpdateVarDumps": "maintenance/updateVarDumps.php"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
Move test-only classes to new TestAutoloadClasses declaration Bug: T196090 Depends-On: I88cf69663362fd599c20649b1df641907a02678d Change-Id: I5e3ef040628c4ff629a8aabc56a3b8ba259b7e78
2019-12-10 19:40:18 +00:00
"TestAutoloadClasses": {
"AbuseFilterConsequencesTest": "tests/phpunit/AbuseFilterConsequencesTest.php",
"AbuseFilterParserTestCase": "tests/phpunit/unit/AbuseFilterParserTestCase.php"
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"ResourceModules": {
"ext.abuseFilter": {
"styles": "ext.abuseFilter.css"
},
"ext.abuseFilter.edit": {
"scripts": "ext.abuseFilter.edit.js",
"messages": [
"abusefilter-edit-syntaxok",
"abusefilter-edit-syntaxerr",
"abusefilter-http-error",
Change throttle selector to restore old functionality, overall improvement Long (sigh) explanation in T203587#4569698. Also, simplified the way TagMultiselect are generated, this one and the one for change tags. This new selector is back-compat both with the old textarea and the OOUI checkboxMultiselect; actually, this one is //fully// compatible with the old textarea. Add validation for throttle parameters and unit tests for validation (split from I976c95658cddb2585910b6f8a5f047aadc4e4d47). Added a trim when retrieving throttle identifier to allow syntax like 'ip, user'. Improved the message shown on history. Re-added the maintenance script to clean DB. As I wrote in the task, a review by two other people would be great, at least for the maintenance script (it could potentially break the DB). Bug: T203587 Bug: T203336 Bug: T203584 Bug: T203585 Depends-On: I3b2e763bd8835207dc5df1db43d3e1881e6961c3 Change-Id: I7831dbb0bab55807392ac1f7915d6cb0cb713593
2018-09-09 10:14:31 +00:00
"abusefilter-edit-throttle-placeholder",
"abusefilter-edit-tag-placeholder",
Warn the user if they try to leave the page with unsaved changes While editing filters, sometimes it happen that you make some change, forget about it and then reload/close the page, and no warnings will be issued. This patch makes use of the core module used for normal page editing to display a warning if trying to leave a filter editing page with any unsaved change (both to the filter pattern or other form elements). Change-Id: I78d79215565d5c82028b1a2a4276497ccbffdea2
2018-12-04 12:06:46 +00:00
"abusefilter-edit-warn-leave",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"unknown-error"
],
"dependencies": [
"mediawiki.util",
"mediawiki.api",
Warn the user if they try to leave the page with unsaved changes While editing filters, sometimes it happen that you make some change, forget about it and then reload/close the page, and no warnings will be issued. This patch makes use of the core module used for normal page editing to display a warning if trying to leave a filter editing page with any unsaved change (both to the filter pattern or other form elements). Change-Id: I78d79215565d5c82028b1a2a4276497ccbffdea2
2018-12-04 12:06:46 +00:00
"mediawiki.confirmCloseWindow",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"jquery.textSelection",
Switch editing interface to OOUI & improve NoJS usability This settles almost everything, leaving the tags part ready to be further improved in the follow-ups. Also, replaced some fields with totally different ones, improved the warn preview area and improved a bit nojs experience by hiding unusable buttons. Bug: T132284 Bug: T154749 Change-Id: I7a5caa862a32f9792140c6a4d9708a2d20472672
2018-03-23 09:13:41 +00:00
"jquery.spinner",
"oojs-ui-core",
"oojs-ui-widgets"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
]
},
"ext.abuseFilter.tools": {
"scripts": "ext.abuseFilter.tools.js",
"messages": [
"abusefilter-reautoconfirm-notallowed",
"abusefilter-reautoconfirm-none",
"abusefilter-reautoconfirm-done",
"abusefilter-http-error",
Improve var dumping in /details, /examine and /tools Using var_export for better visual effect, especially for arrays. The result from /tools is much clearer and the 'wrong syntax' message is a bit more explicative than before. Bug: T190653 Bug: T239972 Change-Id: I79a17305c7f19f7900f896f895e9365bb5f2fd58
2018-03-26 18:41:20 +00:00
"abusefilter-tools-syntax-error",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"unknown-error"
],
"dependencies": [
"mediawiki.api",
Migrate 'user.tokens' dependency to 'user.options' The 'user.tokens' module is a deprecated alias to 'user.options' since MW 1.35. Bug: T235457 Change-Id: I45e8e35edf4e6f901c2045d2592326e531607726
2020-03-27 16:21:46 +00:00
"user.options",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"jquery.spinner"
]
},
"ext.abuseFilter.examine": {
"scripts": "ext.abuseFilter.examine.js",
"messages": [
"abusefilter-examine-match",
"abusefilter-examine-nomatch",
"abusefilter-examine-syntaxerror",
"abusefilter-examine-notfound",
Allow users with abusefilter-view-private to use testing interface Now the required need will be abusefilter-modify OR abusefilter-view-private for /tools, /test and /examine. Bug: T193903 Change-Id: I3f1a91a2cc1df2272e5d4099cefd7c649a0683d5
2018-05-04 19:56:45 +00:00
"abusefilter-mustviewprivateoredit",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"abusefilter-http-error",
"unknown-error"
],
"dependencies": [
"jquery.spinner",
"mediawiki.api"
]
Revert "Revert "Switch editor to Ace and provide syntax highlight"" Make Ace use a fixed size in em. This reverts commit 272775ff81f230659b678d4c514f7a8ef817d9f7. Change-Id: I9b439b20df91eb367bcef4b6f33ff087aded0b62
2018-03-30 06:55:03 +00:00
},
"ext.abuseFilter.ace": {
"scripts": "mode-abusefilter.js",
"dependencies": "ext.codeEditor.ace"
Bring in VE support from VE extension Change-Id: Ib1354f0404209a15194895026ff9d179d16b1900
2018-11-29 18:17:12 +00:00
},
"ext.abuseFilter.visualEditor": {
Add mobile target to VE plugin modules Bug: T213774 Change-Id: Idb4dd58b441d24fae7012b79fc049fbd02029c4c
2019-01-15 00:05:20 +00:00
"scripts": "ve-abusefilter/ve.init.mw.AbuseFilterSaveErrorHandler.js",
"targets": [ "desktop", "mobile" ]
Bring in VE support from VE extension Change-Id: Ib1354f0404209a15194895026ff9d179d16b1900
2018-11-29 18:17:12 +00:00
}
},
"attributes": {
"VisualEditor": {
"PluginModules": [
"ext.abuseFilter.visualEditor"
]
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
}
},
"ResourceFileModulePaths": {
"localBasePath": "modules",
"remoteExtPath": "AbuseFilter/modules"
},
Change some globals to work better with extension registration Rename $wgAbuseFilterAvailableActions / $wgAbuseFilterRestrictedActions to $wgAbuseFilterActions / $wgAbuseFilterRestrictions and make them an associative array instead of a plain one, as that works more sanely with extension registration. (The renaming helps to give more useful errors to sites using the old config.) Change-Id: I790d39c2849922d7daf7479f298cd90cf30af129
2016-06-03 18:01:56 +00:00
"callback": "AbuseFilterHooks::onRegistration",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"Hooks": {
"EditFilterMergedContent": "AbuseFilterHooks::onEditFilterMergedContent",
"GetAutoPromoteGroups": "AbuseFilterHooks::onGetAutoPromoteGroups",
Use the updated TitleMove hook to filter move actions For several reasons: *We're not really checking permissions (and the hook previously used is meant to be used in such case) *We'll show a cleaner error message (i.e. without the "You do not have permission..." part) *Filtering will happen closer to the actual move Bug: T208907 Depends-On: I4733724075b7514e9db59e7be772d9409aa9da87 Change-Id: If88f736a446247f8b4b13c055c641d56f544d1ea
2018-11-09 15:05:11 +00:00
"TitleMove": "AbuseFilterHooks::onTitleMove",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"ArticleDelete": "AbuseFilterHooks::onArticleDelete",
"RecentChange_save": "AbuseFilterHooks::onRecentChangeSave",
"ListDefinedTags": "AbuseFilterHooks::onListDefinedTags",
"ChangeTagsListActive": "AbuseFilterHooks::onChangeTagsListActive",
"LoadExtensionSchemaUpdates": "AbuseFilterHooks::onLoadExtensionSchemaUpdates",
"ContributionsToolLinks": "AbuseFilterHooks::onContributionsToolLinks",
Use HistoryPageToolLinks hook to add a log link to history pages Add an AbuseFilter log link to the subtitle of history pages. Bug: T28934 Co-authored-by: Matěj Suchánek Depends-On: I2e0e9e92d3fc303135b0eb9acf06b5fd120178a5 Depends-On: I58a3039b3755648bb0c8aaf87db48ace96ce9344 Change-Id: Ib89c48f2b8f3121ead184844844acee436e2fdd6
2014-03-25 15:57:01 +00:00
"HistoryPageToolLinks": "AbuseFilterHooks::onHistoryPageToolLinks",
Add links to AbuseFilter logs on Special:Undelete Depends-On: I671a0479e877e6c37606b688064cb9c893717709 Bug: T231055 Change-Id: Iebf832c513c6a4e954db0ba2633dd8ba6f27b412
2019-08-22 23:19:42 +00:00
"UndeletePageToolLinks": "AbuseFilterHooks::onUndeletePageToolLinks",
Provide page text and edit summary when filtering file uploads This allows filters using `action='upload'` to use the variables `summary`, `new_wikitext` and several others that previously were only provided when editing pages (`action='edit'`). This is achieved using the new UploadVerifyUpload hook, introduced in MediaWiki core in change Ie68801b307de8456e1753ba54a29c34c8063bc36. `action='upload'` is now only used when publishing an upload, and not for uploads to stash. A new `action='stashupload'` is introduced, which is used for all uploads, including uploads to stash. This behaves like `action='upload'` used to, and only provides file metadata variables. Filter authors should use `action='stashupload'` when a file can be checked based only on the file contents, and `action='upload'` only when the wikitext edit needs to be examined too. Bug: T87381 Bug: T89252 Bug: T139848 Change-Id: I9654f82ecda82e4917fd0ac6b364b947a1434c73
2016-06-17 15:23:42 +00:00
"UploadVerifyUpload": "AbuseFilterHooks::onUploadVerifyUpload",
Only run filters once for direct uploads (without stash) Uses the new UploadStashFile hook. Bug: T140522 Depends-On: I2f574b355cd33b2e9fa7ff8e1793503b257cce65 Change-Id: Ic7c2dbc54c6ad300d26172796ee21027a8c372ee
2016-08-03 14:30:18 +00:00
"UploadStashFile": "AbuseFilterHooks::onUploadStashFile",
Update hooks to use `PageSaveComplete` Extension requires MW 1.35+, always available Bug: T250566 Change-Id: I60cf3cc42db989d8ccb0d06d3cf9eae8a85784ac
2020-06-16 04:12:38 +00:00
"PageSaveComplete": "AbuseFilterHooks::onPageSaveComplete",
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"UserMergeAccountFields": "AbuseFilterHooks::onUserMergeAccountFields",
Add tests for global filters Another crucial part to have covered. Also clarify that AbuseFilterCentralDB can be of the form "dbname-prefix". Remove a filter used for profiling and replace it with a global one: we're still fine, and the list is kept shorter. Bug: T201193 Depends-On: I5ee7ba44a6cd82a5ddb24fb4127af04d96e647f4 Change-Id: If6b91711534c0d60e1aa27bd5748c3023e29f376
2018-08-25 12:44:01 +00:00
"ParserOutputStashForEdit": "AbuseFilterHooks::onParserOutputStashForEdit",
"UnitTestsAfterDatabaseSetup": "AbuseFilterHooks::onUnitTestsAfterDatabaseSetup",
"UnitTestsBeforeDatabaseTeardown": "AbuseFilterHooks::onUnitTestsBeforeDatabaseTeardown"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"config": {
Change some globals to work better with extension registration Rename $wgAbuseFilterAvailableActions / $wgAbuseFilterRestrictedActions to $wgAbuseFilterActions / $wgAbuseFilterRestrictions and make them an associative array instead of a plain one, as that works more sanely with extension registration. (The renaming helps to give more useful errors to sites using the old config.) Change-Id: I790d39c2849922d7daf7479f298cd90cf30af129
2016-06-03 18:01:56 +00:00
"AbuseFilterActions": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"throttle": true,
"warn": true,
"disallow": true,
"blockautopromote": true,
"block": true,
"rangeblock": false,
Rearrange config to provide better experience In order to bundle AbuseFilter, we have to provide an optimal configuration for sysadmins. This patch aims to provide such configuration, and of course it's open to changes. Changed values: *Grant abusefilter-view-private to admins. This is mostly for redundancy-safety (they already have -modify) *Grant modify-restricted to admins (see T200032) *Disable the 'degroup' action. This is really dangerous, not ideal to be enabled by default. *Grant the abusefilter-revert right to sysops. This is similar to assigning the modify-restricted right in its rationale. *Add abusefilter-log-private to viewrestrictedlogs grant. This right should go together with abusefilter-view-private. (T226987) *Remove abusefilter-revert from the rollback grant, as that right is for reverting AF actions and has nothing to do with rollbacks. This mostly copies the config of WMF production: degrouping is already disabled there, and modify-restricted should be assigned to sysops on WMF wikis as well. The assignment of the abusefilter-view-private and abusefiliter-revert rights is handled in I09cb462312c5bbc71ee3a8f0fbd91357908130d4 (parent patch) to keep the status quo. NOTE: this patch should be *deployed* together with the config patch to avoid discontinuities. Thus, please ONLY provide a virtual +2 using a +1, and I'll coordinate the +2 with a deployer. Bug: T191740 Bug: T200032 Bug: T226987 Depends-On: I09cb462312c5bbc71ee3a8f0fbd91357908130d4 Change-Id: I58f215b8aa3444602532098a3c9dfd25409f29eb
2018-10-20 10:24:53 +00:00
"degroup": false,
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"tag": true
},
"description": "Array of enabled actions in the form [action name => is enabled?]. At the end of setup, false values will be filtered out"
},
"AbuseFilterConditionLimit": {
"value": 1000,
"description": "The maximum number of 'conditions' that can be used each time the filters are run against a change. (More complex filters require more 'conditions')."
},
"AbuseFilterParserClass": {
"value": "AbuseFilterParser",
Move parser tests to /unit IMHO these can be considered unit tests; they were already fast, but now they're executed in an instant. This requires several changes: 1 - delay retrieving messages in AFPUserVisibleException, to avoid having to deal with i18n whenever we want to test exceptions; 2 - Use some DI for Parser and Tokenizer. Equivset-dependend tests are also moved to a new class, thus helping to fix the AF part of T189560. Change-Id: If4585bf9bb696857005cf40a0d6985c36ac7e7a8
2019-08-21 10:04:10 +00:00
"description": "Class of the parser to use. The only possible values are 'AbuseFilterParser' and 'AbuseFilterCachingParser' (experimental). The code should only use the wrapper AbuseFilter::getDefaultParser."
Change some globals to work better with extension registration Rename $wgAbuseFilterAvailableActions / $wgAbuseFilterRestrictedActions to $wgAbuseFilterActions / $wgAbuseFilterRestrictions and make them an associative array instead of a plain one, as that works more sanely with extension registration. (The renaming helps to give more useful errors to sites using the old config.) Change-Id: I790d39c2849922d7daf7479f298cd90cf30af129
2016-06-03 18:01:56 +00:00
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"AbuseFilterEmergencyDisableThreshold": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"default": 0.05
},
Fix a typo in EmergencyDisable globals description And specify what we mean with "dangerous actions". Change-Id: Ida5827978b257cfdf61786c7e19c11a1dc74c664
2019-02-16 13:43:29 +00:00
"description": "Disable potentially dangerous actions (AbuseFilterRestrictions) of a filter if it matches more than X actions, constituting more than Y% (e.g. 0.05 = 5%) of the last Z actions, and the filter has been modified in the last S seconds. X is AbuseFilterEmergencyDisableCount, Y is AbuseFilterEmergencyDisableThreshold, S is AbuseFilterEmergencyDisableAge and Z is a number between 1 and AbuseFilterProfileActionsCap."
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"AbuseFilterEmergencyDisableCount": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"default": 2
},
"description": "See description for AbuseFilterEmergencyDisableThreshold"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"AbuseFilterEmergencyDisableAge": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"default": 86400
},
"description": "See description for AbuseFilterEmergencyDisableThreshold"
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
Change some globals to work better with extension registration Rename $wgAbuseFilterAvailableActions / $wgAbuseFilterRestrictedActions to $wgAbuseFilterActions / $wgAbuseFilterRestrictions and make them an associative array instead of a plain one, as that works more sanely with extension registration. (The renaming helps to give more useful errors to sites using the old config.) Change-Id: I790d39c2849922d7daf7479f298cd90cf30af129
2016-06-03 18:01:56 +00:00
"AbuseFilterRestrictions": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"throttle": false,
"warn": false,
"disallow": false,
"blockautopromote": true,
"block": true,
"rangeblock": true,
"degroup": true,
"tag": false
},
"description": "Do users need 'abusefilter-modify-restricted' user right as well as 'abusefilter-modify' in order to create or modify filters which carry out this action? Array like [action name => is restricted?]"
},
"AbuseFilterNotifications": {
"value": false,
"description": "Allows to configure the extension to send hit notifications to Special:RecentChanges or UDP. Available options: rc, udp, rcandudp"
},
"AbuseFilterNotificationsPrivate": {
"value": false,
"description": "Enable notifications for private filters"
},
"AbuseFilterCentralDB": {
"value": null,
Add tests for global filters Another crucial part to have covered. Also clarify that AbuseFilterCentralDB can be of the form "dbname-prefix". Remove a filter used for profiling and replace it with a global one: we're still fine, and the list is kept shorter. Bug: T201193 Depends-On: I5ee7ba44a6cd82a5ddb24fb4127af04d96e647f4 Change-Id: If6b91711534c0d60e1aa27bd5748c3023e29f376
2018-08-25 12:44:01 +00:00
"description": "Name of a database where global abuse filters will be stored in. To use a DB with prefixed tables, set this to \"{$databaseName}-{$prefix}\"."
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
},
"AbuseFilterIsCentral": {
"value": false,
"description": "Set this variable to true for the wiki where global AbuseFilters are stored in"
},
"AbuseFilterDisallowGlobalLocalBlocks": {
"value": false,
"description": "Disallow centralised filters from taking actions that locally block, remove from groups, or revoke permissions"
},
"AbuseFilterBlockDuration": {
"value": "indefinite",
"description": "Old standard block duration for logged in users. Kept for backward compatibility after T32024."
},
"AbuseFilterAnonBlockDuration": {
"value": null,
"description": "Old standard block duration for anonymous users, $wgAbuseFilterBlockDuration will be used if null. Kept for backward compatibility after T32024."
},
"AbuseFilterCustomActionsHandlers": {
"value": [],
"description": "Callback functions for custom actions"
},
"AbuseFilterValidGroups": {
"value": [ "default" ],
"description": "The list of 'groups' filters can be divided into – used for applying edit filters to certain types of actions. By default there is only one group."
Change some globals to work better with extension registration Rename $wgAbuseFilterAvailableActions / $wgAbuseFilterRestrictedActions to $wgAbuseFilterActions / $wgAbuseFilterRestrictions and make them an associative array instead of a plain one, as that works more sanely with extension registration. (The renaming helps to give more useful errors to sites using the old config.) Change-Id: I790d39c2849922d7daf7479f298cd90cf30af129
2016-06-03 18:01:56 +00:00
},
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
"AbuseFilterDefaultWarningMessage": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"default": "abusefilter-warning"
},
"description": "Default warning messages, per filter group"
},
Allow selecting custom disallow message You can now select a custom message to be displayed for disallowing a edit the same way as for warn mode. This can be the same or a totally different message. This also solves the usecase, when a edit filter is set to warn AND disallow, to be able to show the user a custom message, but the generic is shown on the second try (disallow). Now it can be only set to disallow. Bug: T27086 Change-Id: Ic1de03a6944c43a346fa317ee0a217551f0d284a
2014-10-04 14:42:46 +00:00
"AbuseFilterDefaultDisallowMessage": {
"value": {
"default": "abusefilter-disallowed"
},
Remove incorrect merge_strategy definitions Those merge strategies aren't needed because array_plus is for when the keys of the array are integers, not necessarily the values. Change-Id: I164723c4cc6b12cd6e4ce0d49c74d93eda5d871d
2020-05-12 19:48:36 +00:00
"description": "Default disallow messages, per filter group"
Allow selecting custom disallow message You can now select a custom message to be displayed for disallowing a edit the same way as for warn mode. This can be the same or a totally different message. This also solves the usecase, when a edit filter is set to warn AND disallow, to be able to show the user a custom message, but the generic is shown on the second try (disallow). Now it can be only set to disallow. Bug: T27086 Change-Id: Ic1de03a6944c43a346fa317ee0a217551f0d284a
2014-10-04 14:42:46 +00:00
},
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"AbuseFilterLogIPMaxAge": {
"value": 7776000,
"description": "Age used as cutoff when purging old IP log data, defaults to 3 months. Used by maintenance script purgeOldLogIPData.php"
},
"AbuseFilterSlowFilterRuntimeLimit": {
"value": 500,
"description": "Runtime in milliseconds before a filter is considered slow."
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
Move actions limit to a global variable This opens the door to further customization and allows every wiki to set its own value. Bug: T132925 Change-Id: I63985f2809c3253b07b33caef30fcd8d4c62dfd4
2018-04-04 18:29:50 +00:00
"AbuseFilterProfileActionsCap": {
"value": 10000,
"description": "Number of action that determines when to reset profiling stats."
},
Overhaul Blockautopromote action As for all mostly unused consequences, blockautopromote has a couple of major problems: first, it blocked the status for a random time between 3 and 7 days, which to me makes no sense at all (is it some sort of casino?), and this patch fixes it to 5 days. Second, nothing was logged, not the blocking nor the unblocking. Here I'm adding a LogHandler for two new sub-actions of 'rights' to keep track of both action. Bug: T49412 Change-Id: If48a48f5b8baaf9e77c0826466f5d03bb7f691d0
2018-07-16 12:10:36 +00:00
"AbuseFilterRangeBlockSize": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": {
"IPv4": 16,
"IPv6": 19
},
"description": "Size of the range blocked by 'rangeblock' action."
},
Use "privatedetails" instead of "private" where needed To keep a clear distinction between "private details" (i.e. user's ip) and "private filters" (i.e. not publicly viewable). This patch renames rights, i18n keys and methods names. The patch for renaming globals and rights in WMF config is I7e6b3d4453403edb6aa602587374b4ff5b6d625f. Bug: T211004 Change-Id: I613dbadb8f75c8c4116a362607563a436a73d321
2019-01-07 15:23:21 +00:00
"AbuseFilterLogPrivateDetailsAccess": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": false,
Fix extension doc for AbuseFilterPrivateLog This variable is actually here to determine whether accessing private info should be logged, not if it's possible to access such info. In fact, you can still do it if this variable is set to false. Change-Id: Ieba191bff4ea56eb166bbbd03cb7b1a05ca42c52
2018-07-16 13:32:38 +00:00
"description": "Whether accessing private information from a filter log entry is logged."
Log accessing private information in abuse filter logs Bug: T152934 Change-Id: I8049df3b2b9343a6877e9a306d2781d3f27ec657
2016-12-12 16:30:06 +00:00
},
Use "privatedetails" instead of "private" where needed To keep a clear distinction between "private details" (i.e. user's ip) and "private filters" (i.e. not publicly viewable). This patch renames rights, i18n keys and methods names. The patch for renaming globals and rights in WMF config is I7e6b3d4453403edb6aa602587374b4ff5b6d625f. Bug: T211004 Change-Id: I613dbadb8f75c8c4116a362607563a436a73d321
2019-01-07 15:23:21 +00:00
"AbuseFilterPrivateDetailsForceReason": {
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"value": false,
"description": "Whether users are forced to provide a reason for accessing private information from a filter log entry."
},
"AbuseFilterLogIP": {
"value": true,
"description": "Whether to include IP in the abuse_filter_log"
}
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
},
"load_composer_autoloader": true,
Move documentation to extension.json This way we'll be able to go on with I0e95e9b15e3733d85bdfac2a4d27a4d5ba7db928 and dependencies. Change-Id: I16aa7c839a71ecae0554ef43fa12423e76118fe0
2018-04-02 15:47:04 +00:00
"manifest_version": 2
Add extension.json, empty php entry point For ease of review this is the same as Icff39f3f79f7ffe86214cfa216b53f3d882e1968 and the necessary changes are done in the child patch. Should not be merged without that. Bug: T87876 Change-Id: Iefd8d34619bbfb7602c4fea869f3f89fdeb9057b Co-Authored-By: Paladox <thomasmulhall410@yahoo.com>
2016-05-15 11:12:40 +00:00
}
Reference in a new issue Copy permalink