wikimedia/mediawiki-extensions-AJAXPoll
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AJAXPoll synced 2024-09-23 10:20:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

LoadExtensionSchemaUpdates: Remove unused path from 'runMaintenance' action

Browse source 
MediaWiki has never used this path for running the maintenance
scripts, only the class name provided in the other parameter.
Providing the parameter is no longer needed in MediaWiki 1.43.

Also, remove outdated pitfall warning, it was fixed by marking
the method as protected in MediaWiki 1.35 (Ie73e6143bb).

Bug: T367918
Change-Id: I1818cf882e820bca9d7ec22b9bd30a86b81970f5
This commit is contained in:
Bartosz Dziewoński 2024-06-19 19:48:56 +02:00
parent 0d654585ae
commit bab4d43206
2 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
extension.json
View file

@ -11,7 +11,7 @@
"type": "parserhook",
"license-name": "GFDL-1.2",
"requires": {
"MediaWiki": ">= 1.35.3"
"MediaWiki": ">= 1.43"
},
"GroupPermissions": {
"*": {

5
includes/AJAXPoll.php
View file

@ -664,14 +664,9 @@ During the last 48 hours, {$tab2->votes} votes have been given.";
// adding a new, UNIQUE INDEX on a new AUTO_INCREMENT field (which the
// script also creates) and, of course, finally the new column is populated
// with data.
// PITFALL WARNING! Do NOT change this to $updater->runMaintenance,
// THEY ARE NOT THE SAME THING and this MUST be using addExtensionUpdate
// instead for the code to work as desired!
// HT Skizzerz
$updater->addExtensionUpdate( [
'runMaintenance',
'MigrateOldAJAXPollUserColumnsToActor',
'../maintenance/migrateOldAJAXPollUserColumnsToActor.php'
] );
// 3) drop the now unused column