wikimedia/mediawiki-extensions-AJAXPoll
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AJAXPoll synced 2024-11-23 22:46:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Remove Database#(start|end)Atomic method calls to prevent deadlocks"

Browse source
This commit is contained in:
jenkins-bot 2021-07-25 10:01:59 +00:00 committed by Gerrit Code Review
parent 13fe35f759 86bf2319be
commit a14c460c51
1 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
includes/AJAXPoll.php
View file

@ -53,7 +53,6 @@ class AJAXPoll {
$lines = explode( "\n", trim( $input ) ); $lines = explode( "\n", trim( $input ) );
$dbw = wfGetDB( DB_MASTER ); $dbw = wfGetDB( DB_MASTER );
$dbw->startAtomic( __METHOD__ );
/** /**
* Register poll in the database * Register poll in the database
@ -111,8 +110,6 @@ class AJAXPoll {
} }
} }
$dbw->endAtomic( __METHOD__ );
switch ( $lines[0] ) { switch ( $lines[0] ) {
case 'STATS': case 'STATS':
$ret = self::buildStats(); $ret = self::buildStats();
@ -197,7 +194,6 @@ During the last 48 hours, $tab2[0] votes have been given.";
} }
$dbw = wfGetDB( DB_MASTER ); $dbw = wfGetDB( DB_MASTER );
$dbw->startAtomic( __METHOD__ );
if ( $answer != 0 ) { if ( $answer != 0 ) {
$answer = ++$answer; $answer = ++$answer;
@ -222,8 +218,6 @@ During the last 48 hours, $tab2[0] votes have been given.";
$pollContainerText = self::revokeVote( $dbw, $id, $user ); $pollContainerText = self::revokeVote( $dbw, $id, $user );
} }
$dbw->endAtomic( __METHOD__ );
return self::buildHTML( $id, $user, false, '', $pollContainerText ); return self::buildHTML( $id, $user, false, '', $pollContainerText );
} }