Inez Korczynski
98cdff0851
VE-2064: There is no need to "alias" that variable
2015-11-23 19:55:03 +00:00
Paul Oslund
6e54a6d3a2
VE-2064: Extract method to load non-portable infoxes
2015-11-20 20:10:03 +00:00
Inez Korczynski
7d1f542f6c
MAIN-5838: Check if $arguments is an array before handling it in array way ;)
2015-11-14 00:05:41 +00:00
Inez Korczynski
8a2ddb554b
VE-2041: Added comment regarding commented out code
2015-11-12 21:23:38 +00:00
Inez Korczynski
025b4e387b
VE-2041: Fix infobox API to actually return proper response.
...
This is still work in progress - weighing pros and cons of two different approaches to this problem.
2015-11-12 02:16:01 +00:00
Diana
15a00b4d4e
sanitize horizontal group items as well
2015-11-05 17:57:53 +00:00
Diana
91804e99c3
add test for sole image in label
2015-11-05 13:29:42 +00:00
Diana
49feb54689
change method name to sanitizeInfoboxFields and refactor
2015-11-05 13:21:20 +00:00
Diana
7e9836085a
adjust hero image template
2015-11-03 16:31:31 +00:00
dianafa
649895d4cf
change variable names and add missing PHPdocs
2015-11-03 17:19:29 +01:00
dianafa
2214b5c81f
add logging each striping to Kibana
2015-11-03 16:58:25 +01:00
dianafa
79a0bf14fa
DAT-3329 add more tests and clean identation
2015-11-03 16:36:52 +01:00
dianafa
653a64942d
change function invocation in RenderService
2015-11-03 16:13:45 +01:00
dianafa
3f2d287e8a
do not strip links
2015-11-03 16:12:44 +01:00
dianafa
569ef4ae4c
add tests
2015-11-03 16:11:08 +01:00
dianafa
2a0c5ef3d0
sanitize labels as well
2015-11-03 14:45:27 +01:00
Inez Korczyński
6b78b8a3ae
Merge pull request #8943 from Wikia/PI-Collapsible-Groups
...
Collapsible Groups for Portable Infoboxes
2015-10-30 10:46:00 -07:00
Inez Korczynski
70d18e11ea
VE-2003: Remove unncecessary empty lines
2015-10-28 17:57:00 +00:00
Inez Korczynski
d46955d8ee
VE-2003: Created unit tests to "collapse" attribute of PI groups
2015-10-28 17:55:03 +00:00
Nikodem Hynek
ef9c31ccc0
Merge pull request #8899 from Wikia/DAT-3402
...
DAT-3402 move links placeholder replacement after markers are resolved
2015-10-28 10:58:52 +01:00
Inez Korczynski
ad224dab1e
VE-2006: Change order of CSS so overwrites for collapsable groups happens after stack layout
2015-10-28 06:56:50 +00:00
Inez Korczyński
9f09c5df1a
Merge pull request #8904 from Wikia/VE-1996
...
VE-1996: Create JS to toggle pi-collapse-closed class
2015-10-27 23:44:59 -07:00
Paul Oslund
8f020f6bd5
VE-1997: Use mixin for chevron rotation
2015-10-27 23:16:24 +00:00
Paul Oslund
cae6efafca
VE-1997: Add chevron to pi-collapse header
2015-10-27 22:16:27 +00:00
Inez Korczynski
f901a1642e
VE-2004: Silencing loadHTML warning
...
I carefully researched the topic and it seems that there is no way to instruct DOMDocument to accept "lower" quality HTML. Specifically in HTML <div> or <figure> (block elements) are not allowed inside <p> (which accepts only inline elements) - hence it's complaining about.
Based on comments from stackoverflow it seems that such practice (silencing it) is commong practice in this situation.
2015-10-27 20:02:58 +00:00
Paul Oslund
af4026b386
VE-1996: Create JS to toggle pi-collapse-closed class
2015-10-27 16:52:42 +00:00
Paul Oslund
777bd44356
VE-1995: Hide items in collapsed group
2015-10-27 16:44:05 +00:00
idradm
c73cfab57b
DAT-3402 move links placeholder replacement after markers are resolved
2015-10-27 14:09:42 +01:00
Inez Korczynski
2faa1bd633
VE-1994: Fix unit tests
2015-10-26 22:06:10 +00:00
Inez Korczynski
3d05ec1758
VE-1994: Add appropriately pi-collapse and pi-collapse-[open|closed] CSS classes to PI groups wrappers
2015-10-26 21:59:34 +00:00
Inez Korczynski
2424103f76
VE-2000: Modify regex to match all markers (hexadecimal instead of decimal only)
2015-10-23 21:24:26 +00:00
Inez Korczyński
ed23fc1a8e
Merge pull request #8866 from Wikia/VE-1993
...
VE-1993: Render videos in media collection tabs
2015-10-22 16:03:31 -07:00
Paul Oslund
99dd3f4e4c
VE-1993: Render videos in media collection tabs
2015-10-22 21:21:19 +00:00
Inez Korczynski
d280c32dfc
VE-1990: Added support for video in PIMC
2015-10-22 20:56:32 +00:00
Paul Oslund
9c32432469
Merge pull request #8844 from Wikia/VE-1985
...
VE-1985: Added support for video passed to tabber
2015-10-22 12:26:19 -06:00
Inez Korczyński
9733548c0d
Merge pull request #8840 from Wikia/VE-1961
...
VE 1961: Render image collection tabs in infobox
2015-10-22 11:23:43 -07:00
Paul Oslund
2faedf0c23
VE-1961: Center image collection tabs
2015-10-22 17:38:39 +00:00
Paul Oslund
a5e2f37cb6
VE-1961: Update tab border logic
2015-10-22 17:25:40 +00:00
Paul Oslund
f84b29a461
VE-1961: Display caption as tab title if available
2015-10-21 20:29:39 +00:00
Paul Oslund
f9055fe97c
VE-1961: Handle multiple image collections in infobox
2015-10-21 02:55:23 +00:00
Paul Oslund
6eba90ee7e
VE-1961: Launch gallery when clicking image in collection
2015-10-21 02:26:34 +00:00
Inez Korczynski
b2e7b644f4
VE-1985: Added support for video passed to tabber
2015-10-21 00:48:37 +00:00
Inez Korczynski
394db2a0ba
Merge branch 'PI-Media-Collections-MVP' into VE-1982
2015-10-21 00:38:23 +00:00
Inez Korczynski
ec856513e8
VE-1982: Removed not needed global
2015-10-21 00:04:29 +00:00
Inez Korczynski
720900abb5
VE-1982: Added missing global
2015-10-21 00:03:06 +00:00
Paul Oslund
d097426242
VE-1960: Template for mobile image collections
2015-10-20 23:09:23 +00:00
Inez Korczynski
8fc355ecea
VE-1982: Basic unit test coverage for backward compatibility added to <image>
2015-10-20 22:42:36 +00:00
Inez Korczynski
b93c9607a2
VE-1982: Make sourceProvider content more readable and easier to understand
2015-10-20 21:30:07 +00:00
Inez Korczynski
f693207998
VE-1982: Make dataProvider content more readable and easier to understand
2015-10-20 21:28:27 +00:00
Paul Oslund
aec55fabd4
VE-1961: Add ellipsis to long tabs
2015-10-20 19:52:33 +00:00