Commit graph

225 commits

Author SHA1 Message Date
Inez Korczyński 6b78b8a3ae Merge pull request #8943 from Wikia/PI-Collapsible-Groups
Collapsible Groups for Portable Infoboxes
2015-10-30 10:46:00 -07:00
Nikodem Hynek ef9c31ccc0 Merge pull request #8899 from Wikia/DAT-3402
DAT-3402 move links placeholder replacement after markers are resolved
2015-10-28 10:58:52 +01:00
Inez Korczynski f901a1642e VE-2004: Silencing loadHTML warning
I carefully researched the topic and it seems that there is no way to instruct DOMDocument to accept "lower" quality HTML. Specifically in HTML <div> or <figure> (block elements) are not allowed inside <p> (which accepts only inline elements) - hence it's complaining about.

Based on comments from stackoverflow it seems that such practice (silencing it) is commong practice in this situation.
2015-10-27 20:02:58 +00:00
idradm c73cfab57b DAT-3402 move links placeholder replacement after markers are resolved 2015-10-27 14:09:42 +01:00
Inez Korczynski 3d05ec1758 VE-1994: Add appropriately pi-collapse and pi-collapse-[open|closed] CSS classes to PI groups wrappers 2015-10-26 21:59:34 +00:00
Inez Korczynski 2424103f76 VE-2000: Modify regex to match all markers (hexadecimal instead of decimal only) 2015-10-23 21:24:26 +00:00
Inez Korczynski d280c32dfc VE-1990: Added support for video in PIMC 2015-10-22 20:56:32 +00:00
Inez Korczynski b2e7b644f4 VE-1985: Added support for video passed to tabber 2015-10-21 00:48:37 +00:00
Inez Korczynski 394db2a0ba Merge branch 'PI-Media-Collections-MVP' into VE-1982 2015-10-21 00:38:23 +00:00
Inez Korczynski ec856513e8 VE-1982: Removed not needed global 2015-10-21 00:04:29 +00:00
Inez Korczynski 720900abb5 VE-1982: Added missing global 2015-10-21 00:03:06 +00:00
Paul Oslund d097426242 VE-1960: Template for mobile image collections 2015-10-20 23:09:23 +00:00
Inez Korczynski 8fc355ecea VE-1982: Basic unit test coverage for backward compatibility added to <image> 2015-10-20 22:42:36 +00:00
Inez Korczynski c9da5425a7 VE-1979: Added support for <gallery> tag passed to <image> 2015-10-20 01:19:49 +00:00
Inez Korczynski 6c4359a9d4 VE-1975: Added support for mobile (ArticleAsJson) and usage of XML parsing
Special handling for mobile is needed because article for mobile is delivered within ArticleAsJson which makes a lot of transformation during the parsing process (instead of for instance postprocessing).
Parsing HTML with XML parser seems to be giving better results than using just regexes and also it gives as ability to handle nested tabbers in a future in a better way.
2015-10-19 23:56:20 +00:00
Inez Korczynski a692e008b3 VE-1975: Modified NodeImage to return array of images instead of one image
Added support for <tabber>
Hero image still works correct
2015-10-16 01:15:52 +00:00
dianafa 4536458992 move hook to render service 2015-09-28 17:46:40 +02:00
Nikodem 9767ef0d50 Merge pull request #8366 from Wikia/DAT-3194
Dat 3194 - for videos in infobox use link to file page instead of link to original image
2015-09-09 17:24:39 +02:00
Rafal Leszczynski a027e8a2c9 get title from file 2015-09-09 13:23:34 +02:00
Rafal Leszczynski bb7421acb7 treat 0 as valid value inside <format> tag 2015-09-08 11:29:49 +02:00
Rafal Leszczynski d9db65a08f use filepage url instead of image url for videos inside portable infobox 2015-09-07 17:38:17 +02:00
Nikodem e0739c6942 Merge pull request #8351 from Wikia/DAT-3210
DAT-3210 make caption field show the caption not the alt
2015-09-07 16:07:46 +02:00
Diana 625fdf9f7c make caption field show the caption not the alt 2015-09-07 11:42:47 +00:00
idradm 2aa83e9e57 DAT-3197 wrap content tags contents in CDATA before parsing 2015-09-07 12:22:56 +02:00
Sebastian Marzjan b699619caf DAT-3105 Fix saving invalid titles to imagelinks table in PortableInfoboxes
* Use Title::makeTitleSafe instead of Title::newFromTitle
* Add image only if title is valid
2015-08-31 13:53:06 +02:00
Diana c19c4c861c add array values to Node.php 2015-08-25 11:00:04 +00:00
Rafal Leszczynski bc22980d2a Merge branch 'dev' into DAT-3025 2015-07-27 11:39:40 +02:00
Rafal Leszczynski ba0a923fd9 add video functionality to image tag 2015-07-21 16:29:14 +02:00
Diana 6425ac0299 move sanitizeInfoboxTitle to renderService 2015-07-20 13:00:35 +00:00
Diana 3bea79bbe9 add NodeTitle test 2015-07-20 12:02:10 +00:00
Diana 92042b5c1b remove all HTML tags from inforbox title 2015-07-20 11:31:53 +00:00
idradm f3c4062db7 DAT-2933 support html entities in infobox templates 2015-07-06 18:15:29 +02:00
idradm 363ba672c4 DAT-2941 make the show attribute check case insensitive 2015-07-03 12:17:53 +02:00
idradm cf22faa0e1 DAT-2941 rename consts for lower code complexity 2015-07-03 12:17:40 +02:00
idradm 1de7ff5275 DAT-2941 revert const name change 2015-07-03 12:17:17 +02:00
Sebastian Marzjan 86bfcc7592 Cherry-picking 9eb06cc 2015-07-03 12:16:18 +02:00
Rodrigo Molinero Gomez 7360054705 Merge pull request #7698 from Wikia/DAT-2944
DAT-2944 remove source for label tag functionality
2015-07-02 16:38:03 +02:00
idradm 26269c9150 DAT-2940 rename footer tag to navigation 2015-07-01 16:19:31 +02:00
idradm 766f39f75d DAT-2944 remove source for label tag functionality 2015-07-01 10:55:58 +02:00
Rafal Leszczynski f197b3e2ea Merge pull request #7600 from Wikia/DAT-2818
DAT-2818 Infoboxes field mutators
2015-06-26 11:28:37 +02:00
idradm 48072ab3f0 DAT-2917 fix double preprocess breaking inclusion functionality 2015-06-24 14:09:58 +02:00
Diana c63327e68b remove unused const var 2015-06-23 17:35:10 +02:00
Diana 3816c0c88d refactor extractSourceFromNode 2015-06-23 12:25:37 +00:00
Diana 42900d2ffd refactor getValueWithDefault() 2015-06-23 11:10:37 +00:00
Diana c46246cd47 add tests for getSource 2015-06-23 11:05:25 +00:00
Diana cfdc27f665 remove empty line 2015-06-22 15:51:59 +00:00
Diana da9648461e small testing 2015-06-22 15:38:47 +00:00
Diana 4a183481c3 works 2015-06-22 13:53:01 +00:00
Sebastian Marzjan 17e82774c9 Address code review remarks 2015-06-19 15:50:25 +02:00
Sebastian Marzjan 1c0b69edee DAT-2895 Fetch gallery data if available for image tag in new infoboxes 2015-06-19 15:36:16 +02:00
idradm 3e8a665242 Merge remote-tracking branch 'origin/dev' into DAT-2839
# Conflicts:
#	extensions/wikia/PortableInfobox/PortableInfobox.setup.php
#	extensions/wikia/PortableInfobox/controllers/PortableInfoboxParserTagController.class.php
#	extensions/wikia/PortableInfobox/services/Parser/XmlParser.php
#	extensions/wikia/PortableInfobox/styles/PortableInfobox.scss
2015-06-19 14:43:40 +02:00
idradm 81e1754a02 DAT-2875 variables matcher fixed, suitable tests added 2015-06-16 10:52:18 +02:00
idradm b9d4925f52 groups leyout refactor 2015-06-15 14:58:48 +02:00
idradm cae634dfb1 Merge remote-tracking branch 'origin/dev' into DAT-2875-refactor
# Conflicts:
#	extensions/wikia/PortableInfobox/controllers/PortableInfoboxParserTagController.class.php
#	extensions/wikia/PortableInfobox/services/Parser/Nodes/NodeGroup.php
#	extensions/wikia/PortableInfobox/tests/ParserNodesTest.php
2015-06-15 14:57:57 +02:00
idradm 96c1c691b7 DAT-2891 block elements will now be parsed correctly, test added 2015-06-15 12:43:13 +02:00
idradm 70a5a7511c DAT-2875 missing ref element fix 2015-06-12 16:47:37 +02:00
idradm 6d15673e5e DAT-2875 comment added 2015-06-12 15:51:25 +02:00
idradm 197c040d8e DAT-2875 removed isempty and source from render data fields, more tests added, formatting clean up 2015-06-12 15:43:37 +02:00
Rafal Leszczynski f569991469 Merge pull request #7488 from Wikia/DAT-2857
DAT-2857 Horizontal group
2015-06-12 15:23:44 +02:00
Diana f279f1477c call static prop 2015-06-12 01:00:52 +00:00
Diana 3418836533 remove redundant var 2015-06-12 00:11:23 +00:00
Diana 098b1f9b89 fix tests 2015-06-11 17:53:34 +00:00
dianafa 753e320027 merge with dev 2015-06-11 19:36:28 +02:00
idradm e2a0a2273e Merge branch 'dev' into DAT-2875-refactor
# Conflicts:
#	extensions/wikia/PortableInfobox/services/Parser/Nodes/Node.php
#	extensions/wikia/PortableInfobox/services/Parser/Nodes/NodeData.php
#	extensions/wikia/PortableInfobox/tests/ParserNodesTest.php
2015-06-11 19:12:55 +02:00
Diana 20289950d1 getXmlAttributeFromSupported 2015-06-11 13:36:57 +00:00
idradm 29f713997c DAT-2875 test refactoring 2015-06-11 14:51:54 +02:00
idradm d766b3a003 DAT-2875 source variables name for image node fix, get source for group nodes refactored 2015-06-11 11:48:32 +02:00
idradm ea4aa94511 DAT-2875 nodes refactor 2015-06-11 11:34:28 +02:00
Diana 368d233930 working group layout 2015-06-10 16:07:28 +00:00
idradm 29d977c0af Merge branch 'release-302-dat-2861' into release-303-dat-2861 2015-06-10 17:29:32 +02:00
idradm 495bf0acbc DAT-2876 remove not replaced markers 2015-06-10 17:26:33 +02:00
dianafa 76b4b3fbb7 change theme to layout 2015-06-10 17:24:49 +02:00
idradm 1abbaab514 DAT-2875 nodes refactoring, xmlParser will be used only for parsing 2015-06-10 17:19:40 +02:00
Rafal Leszczynski 9480964132 validate infobox tag attributes 2015-06-10 14:51:07 +02:00
idradm ed16bffd63 Merge branch 'release-302-dat-2861' into DAT-2875-refactor 2015-06-10 14:44:59 +02:00
idradm 0396b38175 DAT-2876 switch to internal parsing to prevent hooks errors 2015-06-10 13:55:14 +02:00
idradm 7cbfad1d19 Revert "Merge pull request #7403 from Wikia/DAT-2866"
This reverts commit 131da376095f39b374eaa1d83c2ee734245ca3b8, reversing
changes made to 934ca821fd99f61c53d005568c07f2f9b9afd37d.
2015-06-10 13:47:28 +02:00
Rafal Leszczynski a421a3ed21 Merge branch 'dev' into DAT-2839 2015-06-10 11:42:15 +02:00
idradm 2ad9f22551 nodes refactoring, nodes factory introduced 2015-06-10 11:28:33 +02:00
Rafal Leszczynski 51e869edaa Merge pull request #7437 from Wikia/DAT-2816
DAT-2816 introduce source attribute for label tag, tests refactor
2015-06-09 16:55:58 +02:00
idradm 8d53872cbf DAT-2816 docs comments changed 2015-06-09 15:09:01 +02:00
Adam Robak 40c2fc00b8 Merge pull request #7374 from Wikia/DAT-2861
DAT-2861 add images to parser output on resolving, use same parser in…
2015-06-09 11:48:09 +02:00
idradm a6d3f2fd07 DAT-2816 code refactor, double label or default tag test added 2015-06-09 10:41:45 +02:00
dianafa cb72c284ef getXmlAttr theme 2015-06-09 10:16:47 +02:00
idradm 6655e1fc30 DAT-2816 introduce source attribute for label tag, tests refactor 2015-06-08 15:56:08 +02:00
idradm 471bdf7b8d Merge branch 'DAT-2861' into release-302-dat-2861 2015-06-08 11:35:34 +02:00
Sebastian Marzjan 07dfc765d2 Merge pull request #7364 from Wikia/DAT-2845
DAT-2845 add infobox parser api
2015-06-08 10:00:38 +02:00
idradm 9c55ef194b DAT-2861 images with whitespace in names will be linked correctly now 2015-06-03 16:53:31 +02:00
idradm 4e6298f881 DAT-2866 citation error wont be showing up when partial parse is run 2015-06-03 13:40:26 +02:00
Adam Robak e476e7c07f DAT-2861 save also non existing images 2015-06-01 16:11:36 +02:00
Adam Robak be69f7146e DAT-2861 add images to parser output on resolving, use same parser instance for all parsing 2015-06-01 15:37:56 +02:00
rafal.kalinski 70482ae609 Merge remote-tracking branch 'origin/dev' into SOC-812 2015-05-29 18:47:59 +00:00
jacek 44cbb9cc95 initial commit 2015-05-29 16:37:35 +02:00
Adam Robak 7978ed0b96 DAT-2845 add infobox parser api 2015-05-29 15:05:08 +02:00
Diana 47994ffdb3 merge with dev 2015-05-26 10:57:00 +00:00
Diana 2085bc69a7 Revert "merge with dev"
This reverts commit b369971b4cc0d219803eb94382f02f154ac430a6.
2015-05-26 10:53:38 +00:00
Diana 01ccae3e79 merge with dev 2015-05-26 10:51:41 +00:00
rafal.kalinski 007c60fa22 Merge remote-tracking branch 'origin/dev' into SOC-812 2015-05-25 23:52:33 +00:00
jacek 7fa5668c65 comments 2015-05-25 23:48:21 +00:00
jacek 4ac663f665 simplify 2015-05-25 23:48:20 +00:00