Commit graph

77 commits

Author SHA1 Message Date
Luqgreg ad17140243 Fix unit tests 2018-08-08 11:42:22 +02:00
Luqgreg 8ccae693d5 Bring back and fix PortableInfoboxDataBag 2018-08-07 16:06:52 +02:00
Luqgreg 52197e5c22 Add single video support 2018-08-07 14:13:14 +02:00
Luqgreg 2eb4f15922 WikiaFileHelper and NodeImage cleanup 2018-08-04 19:12:35 +02:00
Luqgreg ab58f034c9 Remove unnecessary PortableInfoboxDataBag 2018-08-04 18:38:43 +02:00
Luqgreg c828b877f8 Fix extracting images from gallery 2018-08-04 18:29:53 +02:00
Luqgreg 7717b0699e Fix image collection template and extracting images from tabber 2018-08-03 14:24:42 +02:00
Luqgreg 34a11ba554 Merge branch 'master' into gallery_support 2018-08-03 13:37:55 +02:00
Luqgreg 4673bb1743 Remove render service for mobile devices 2018-08-01 18:06:09 +02:00
Luqgreg 83a21ba486 Fix getMarkers regex 2018-07-28 15:59:24 +02:00
Jakub Olek 3a30c73c16 XW-4045 | Remvove a tags that href starts with javascript from nodeimage 2017-10-03 10:52:40 +02:00
idradm e6f2637ca4 XW-2771 | make sure the data is present 2017-02-22 16:56:13 +01:00
idradm 47adca6ea1 Restore "Merge pull request #12220 from Wikia/XW-2448"
This reverts commit 50d81602c84b9474e070d6c1a8e2995cd9b8d91b.

# Conflicts:
#	extensions/wikia/PortableInfobox/services/PortableInfoboxRenderService.class.php
2017-01-25 12:18:20 +01:00
macbre 66c995a659 Revert "Merge pull request #12220 from Wikia/XW-2448"
It causes https://wikia-inc.atlassian.net/browse/SUS-1483

Notice: Array to string conversion in /usr/wikia/source/app/includes/parser/StripState.php on line 98

"Array" string is displayed on blog posts listing.

This reverts commit 37d1519605836c8144ea36c9951577e65ce71d9e, reversing
changes made to 0eb38a5cb2fced6e7f3dd1853150ab950d7dffe8.

Conflicts:
	extensions/wikia/PortableInfobox/services/PortableInfoboxRenderService.class.php
2017-01-17 12:31:06 +01:00
Mateusz Rybarski d53e54d83e XW-2448: || instead of array_merge 2017-01-13 15:34:02 +01:00
Mateusz Rybarski a28b14ac94 XW-2448: checking if infobox contains tabber or gallery using markers 2017-01-13 15:18:05 +01:00
Mateusz Rybarski 1723811417 XW-2448: cleanup 2017-01-13 08:51:14 +01:00
Mateusz Rybarski 182de59c7b XW-2448: using foreach loops 2017-01-12 15:05:11 +01:00
Mateusz Rybarski ce18ff7649 XW-2448: get rid of regexps while processing gallery tag in PI 2017-01-12 14:55:30 +01:00
Igor Rogatty 5712de9f05 XW-2415 | save infobox metadata, not just labels 2016-12-09 14:01:49 +01:00
grunny 8186618eb9 (DAT-4494) Fix galleries and tabber in PortableInfoboxes 2016-06-16 16:59:48 +00:00
idradm 9ceba1d2d0 DAT-3942 make sure isVideo param is always set, update tests 2016-04-20 10:38:44 +02:00
dianafa 6406fb53d5 move helper to an independent place 2016-01-12 10:50:24 +01:00
dianafa ed73d4f525 move sanitizing to PortableInfoboxRenderService 2015-12-23 13:20:55 +01:00
dianafa 0de509246f add caption sanitization in getImageData 2015-12-23 11:20:39 +01:00
dianafa 6e8091ec4d move ImageFilenameSanitizer logic to FileNamespaceSanitizeHelper 2015-11-25 11:00:39 +01:00
Inez Korczynski f901a1642e VE-2004: Silencing loadHTML warning
I carefully researched the topic and it seems that there is no way to instruct DOMDocument to accept "lower" quality HTML. Specifically in HTML <div> or <figure> (block elements) are not allowed inside <p> (which accepts only inline elements) - hence it's complaining about.

Based on comments from stackoverflow it seems that such practice (silencing it) is commong practice in this situation.
2015-10-27 20:02:58 +00:00
Inez Korczynski 2424103f76 VE-2000: Modify regex to match all markers (hexadecimal instead of decimal only) 2015-10-23 21:24:26 +00:00
Inez Korczynski d280c32dfc VE-1990: Added support for video in PIMC 2015-10-22 20:56:32 +00:00
Inez Korczynski b2e7b644f4 VE-1985: Added support for video passed to tabber 2015-10-21 00:48:37 +00:00
Inez Korczynski 394db2a0ba Merge branch 'PI-Media-Collections-MVP' into VE-1982 2015-10-21 00:38:23 +00:00
Inez Korczynski ec856513e8 VE-1982: Removed not needed global 2015-10-21 00:04:29 +00:00
Inez Korczynski 720900abb5 VE-1982: Added missing global 2015-10-21 00:03:06 +00:00
Paul Oslund d097426242 VE-1960: Template for mobile image collections 2015-10-20 23:09:23 +00:00
Inez Korczynski 8fc355ecea VE-1982: Basic unit test coverage for backward compatibility added to <image> 2015-10-20 22:42:36 +00:00
Inez Korczynski c9da5425a7 VE-1979: Added support for <gallery> tag passed to <image> 2015-10-20 01:19:49 +00:00
Inez Korczynski 6c4359a9d4 VE-1975: Added support for mobile (ArticleAsJson) and usage of XML parsing
Special handling for mobile is needed because article for mobile is delivered within ArticleAsJson which makes a lot of transformation during the parsing process (instead of for instance postprocessing).
Parsing HTML with XML parser seems to be giving better results than using just regexes and also it gives as ability to handle nested tabbers in a future in a better way.
2015-10-19 23:56:20 +00:00
Inez Korczynski a692e008b3 VE-1975: Modified NodeImage to return array of images instead of one image
Added support for <tabber>
Hero image still works correct
2015-10-16 01:15:52 +00:00
dianafa 4536458992 move hook to render service 2015-09-28 17:46:40 +02:00
Rafal Leszczynski a027e8a2c9 get title from file 2015-09-09 13:23:34 +02:00
Rafal Leszczynski d9db65a08f use filepage url instead of image url for videos inside portable infobox 2015-09-07 17:38:17 +02:00
Diana 625fdf9f7c make caption field show the caption not the alt 2015-09-07 11:42:47 +00:00
Sebastian Marzjan b699619caf DAT-3105 Fix saving invalid titles to imagelinks table in PortableInfoboxes
* Use Title::makeTitleSafe instead of Title::newFromTitle
* Add image only if title is valid
2015-08-31 13:53:06 +02:00
Rafal Leszczynski ba0a923fd9 add video functionality to image tag 2015-07-21 16:29:14 +02:00
Sebastian Marzjan 17e82774c9 Address code review remarks 2015-06-19 15:50:25 +02:00
Sebastian Marzjan 1c0b69edee DAT-2895 Fetch gallery data if available for image tag in new infoboxes 2015-06-19 15:36:16 +02:00
idradm 197c040d8e DAT-2875 removed isempty and source from render data fields, more tests added, formatting clean up 2015-06-12 15:43:37 +02:00
idradm d766b3a003 DAT-2875 source variables name for image node fix, get source for group nodes refactored 2015-06-11 11:48:32 +02:00
idradm ea4aa94511 DAT-2875 nodes refactor 2015-06-11 11:34:28 +02:00
idradm 2ad9f22551 nodes refactoring, nodes factory introduced 2015-06-10 11:28:33 +02:00