Universal-Omega/PortableInfobox
1
0
Fork 0
mirror of https://github.com/Universal-Omega/PortableInfobox.git synced 2024-11-16 12:35:31 +00:00
Code Issues Packages Projects Releases Wiki Activity
802 commits 8 branches 4 tags 31 MiB
Commit graph

113 commits

Author SHA1 Message Date
grunny 36f77e2a8d Add comment explaining where the Mercury PI replacements occur 2016-06-20 18:24:38 +10:00
grunny c006c42035 (CE-3844) Refactor fix for PI and parser tag fix 
A security fix from MW core added quotes to the Parser's strip tag
markers in order to prevent an XSS vulnerability. When this was deployed
PIs and our Wikia tag extensions broke in Mercury because ArticlesAsJson
JSON encodes the parser output in the ParserAfterTidy, but then PI and
the tag extensions were manually replacing the Parser tag strip markers
on the already JSON encoded string within their own ParserAfterTidy methods
(which were always run after the ArticlesAsJson method). This meant that the
strip marker had the quote escaped with a backslash in the encoded string,
so the string replacements failed.

This change follows the previous quick and dirty fix by moving the replacements
in PI and the tag extensions to just before ArticlesAsJson encodes the output.
Which also removes the need from before the fix in #10701 to JSON encode the
parser output of the tags that will be replaced into the text.
 2016-06-17 20:57:12 +10:00
grunny 61bdc6e652 (DAT-4494) Only decode when it's the main JSON array 2016-06-17 04:14:47 +10:00
grunny ddd6c61e79 (DAT-4494) We don't need to json encode here anymore 2016-06-17 03:59:52 +10:00
grunny 899b127b00 (DAT-4494) Don't perform replacements on JSON encoded content 2016-06-16 17:39:06 +00:00
grunny 8186618eb9 (DAT-4494) Fix galleries and tabber in PortableInfoboxes 2016-06-16 16:59:48 +00:00
Igor Rogatty 3ef5a8e72b XW-1429 | remove whitespace after original marker and put a single space after new marker position 2016-05-09 15:14:02 +02:00
Igor Rogatty bc7f3efb35 XW-1429 | add unit tests for moveFirstMarkerToTop method 2016-05-09 14:50:37 +02:00
Igor Rogatty 464bd9ccee XW-1429 | move whitespace together with marker 2016-05-09 14:49:56 +02:00
Igor Rogatty 81830d7024 XW-1429 | use ArticleAsJsonBeforeEncode hook to move the first infobox marker 2016-05-09 13:56:28 +02:00
Igor Rogatty c5ff6c70df XW-1429 | move the first infobox to the top of article content 2016-05-09 12:46:23 +02:00
Lukasz Konieczny 56e5697cfd CE-3554: Fix typo 2016-04-07 10:24:18 +00:00
Lukasz Konieczny 6cc68eaa19 CE-3554: Add doc and comment 2016-04-07 09:29:26 +00:00
Lukasz Konieczny 1a92b184bb CE-3554: Add fallback for existing infobox page props data 2016-04-07 09:27:59 +00:00
Lukasz Konieczny 4f11b96e48 CE-3554: Changes after CR 2016-04-01 11:07:30 +00:00
Lukasz Konieczny a773ee1a49 CE-3554: Extract labels from infobox markup and save them in page props 2016-03-31 09:58:34 +00:00
idradm 20d6a46421 DAT-3707 create infobox builder extension 2016-02-12 11:38:47 +01:00
idradm 6e60746d0f DAT-3707 refactor save 2016-02-12 10:53:22 +01:00
idradm 41ef2d5266 DAT-3707 refactor save 2016-02-12 10:52:46 +01:00
idradm 5bbad66ec0 DAT-3707 remove unused entry point code 2016-02-12 10:05:16 +01:00
idradm 45aaaa5ecd make infobox builder viewport bigger 2016-02-11 10:34:09 +01:00
idradm 490ae75d53 DAT-3735 load builder only 2016-02-10 16:20:36 +01:00
idradm dbbfabceda change mercury route 2016-02-09 12:20:20 +01:00
idradm d4953f7680 Merge branch 'dev' into infobox-builder-feature-branch 
# Conflicts:
#	extensions/wikia/AdminDashboard/AdminDashboardLogic.class.php
#	extensions/wikia/AssetsManager/config.php
#	extensions/wikia/EditPageLayout/templates/EditPageLayout_EditPage.php
 2016-02-09 11:46:56 +01:00
Nikodem Hynek 37f07b8f11 Merge pull request #9659 from Wikia/DAT-3624 
DAT-3624 Fix for broken references in infobox image captions
 2016-02-05 15:25:10 +01:00
idradm b9af596dbc DAT-3622 always pass array to custom frame on api call 2016-02-04 16:52:51 +01:00
Sebastian Marzjan c5d17f315e DAT-3624 Rename 'Infobo' to 'Infobox' 2016-02-03 12:06:44 +01:00
Sebastian Marzjan dc561a4157 DAT-3614 Always pass an *ARRAY* of params to the infobox NodeFactory 2016-01-08 07:44:30 +01:00
idradm 5f42ce9742 make infoboxes use params same way as mediawiki, enable 0 param 2016-01-04 14:34:10 +01:00
Inez Korczynski 7d1f542f6c MAIN-5838: Check if $arguments is an array before handling it in array way ;) 2015-11-14 00:05:41 +00:00
Inez Korczynski 8a2ddb554b VE-2041: Added comment regarding commented out code 2015-11-12 21:23:38 +00:00
Inez Korczynski 025b4e387b VE-2041: Fix infobox API to actually return proper response. 
This is still work in progress - weighing pros and cons of two different approaches to this problem.
 2015-11-12 02:16:01 +00:00
dianafa e658aed5ca Merge branch 'dev' into infobox-builder-feature-branch 2015-10-05 18:39:29 +02:00
idradm 859a0ee81b DAT-3199 use page_props directly instead of through parserOutput, add memcache layer for infoboxes data provider service, introduce hook on backlinks purge 2015-09-22 17:48:38 +02:00
dianafa a92b88a672 DAT-3223 sort and add labels to template titles 2015-09-10 16:29:46 +02:00
Diana de2bc994b1 fix typo in action=edit 2015-09-09 16:57:30 +02:00
idradm ff1f403dae DAT-3153 use of more reliable methods for url spliting and joining 2015-09-07 15:00:00 +02:00
idradm 0212e1c147 DAT-3153 consistent quotes usage introduced 2015-09-07 12:49:46 +02:00
idradm d23f10c538 DAT-3153 fix misspell 2015-09-07 12:46:00 +02:00
idradm bfef593cc0 DAT-3153 map defaultValue to default, publish will work only in template namespace 2015-09-04 12:54:07 +02:00
Rafal Leszczynski c469601cb0 render i18n messages as text 2015-09-03 16:00:53 +02:00
Rafal Leszczynski a493d003b4 add check if title exist 2015-09-03 15:58:35 +02:00
Rafal Leszczynski 0284eedca6 add function description 2015-09-02 13:06:31 +02:00
Rafal Leszczynski be7681943c refactor infobox builder entry point on new template page 2015-09-02 13:04:50 +02:00
Rafal Leszczynski 638be69305 create portable infobox builder special page 2015-09-01 17:12:13 +02:00
Rafal Leszczynski 232d4abb3f remove templates from API response to infobox builder in mercury 2015-09-01 13:32:15 +02:00
idradm 69ee848c1b DAT-3153 infobox builder publish added 2015-08-31 17:42:38 +02:00
idradm b49bb7c1da DAT-3154 call to action on template edit added 2015-08-27 14:50:02 +02:00
idradm bc69cfa7f3 DAT-3154 add infoboxbuilder entrypoint in template edit page 2015-08-27 13:41:33 +02:00
idradm 9b020ee4fb DAT-3147 assets entry point added 2015-08-27 10:30:25 +02:00