Commit graph

367 commits

Author SHA1 Message Date
Mateusz Rybarski 9f96ab9f45 XW-2444: unittests for color validation 2016-12-28 10:12:21 +01:00
idradm 39d9302a93 refactor template engine logic to separate class 2016-12-27 15:58:01 +01:00
idradm 36b582a164 refactor render service to skin based services 2016-12-27 15:09:55 +01:00
Mateusz Rybarski 3a3894a1a3 XW-2444: fixing unittests for render service, cleanup 2016-12-27 14:35:48 +01:00
idradm ac52e392bc XW-2443 remove unnecessary assignment 2016-12-27 10:01:49 +01:00
idradm 8ce60507f0 XW-2443 refactor unit tests, add more cases 2016-12-27 10:00:26 +01:00
idradm 116427f924 XW-2443 use both static and variable based themes 2016-12-27 09:25:44 +01:00
Igor Rogatty f4e8e30306 XW-2415 | test getMetadata 2016-12-14 17:32:10 +01:00
Igor Rogatty 4705117c83 XW-2415 | test getSourcesMetadata method and fix an issue that was found 2016-12-14 15:46:17 +01:00
Igor Rogatty 7889cb59e4 XW-2415 | fix multiple warnings in tests 2016-12-14 15:20:10 +01:00
Igor Rogatty 380c2900b9 XW-2415 | fix unit tests 2016-12-14 13:54:53 +01:00
Weronika Rudnicka c9363473b2 XW-2307 | mocking getMediaType method in custom width logic test 2016-11-21 23:17:32 +01:00
Damian Jozwiak d4a9943eaf XW-2234 | Fix testRenderInfobox unit test 2016-11-03 15:40:21 +01:00
Damian Jozwiak 6e1a075cad XW-2234 | Fix testCustomWidthLogic unit test 2016-11-03 15:32:16 +01:00
macbre a444abc707 Revert "PortableInfoboxRenderServiceTest: temporarily skip testRenderInfobox"
This reverts commit 63ba16643458ce39f61050acc4259156cfb35305.
2016-06-27 12:19:13 +02:00
macbre 4f5e9462dc PortableInfoboxRenderServiceTest: temporarily skip testRenderInfobox 2016-06-24 10:23:45 +02:00
grunny e191fbd396 Fix unit tests 2016-06-17 03:52:32 +10:00
Igor Rogatty 27e695e569 XW-1225 | remove $wgEnableSeoFriendlyImagesForMobile and clean up 2016-05-18 14:44:36 +02:00
Igor Rogatty 3ef5a8e72b XW-1429 | remove whitespace after original marker and put a single space after new marker position 2016-05-09 15:14:02 +02:00
Igor Rogatty bc7f3efb35 XW-1429 | add unit tests for moveFirstMarkerToTop method 2016-05-09 14:50:37 +02:00
idradm 9ceba1d2d0 DAT-3942 make sure isVideo param is always set, update tests 2016-04-20 10:38:44 +02:00
Bogna Knychala 1dc864dd5a Merge remote-tracking branch 'origin/dev' into XW-1300 2016-04-08 13:13:17 +02:00
Igor Rogatty 81ca93b542 XW-1300 | use portable-infobox-hero-image component in tests 2016-04-07 15:14:26 +02:00
Igor Rogatty 7a2b770707 XW-1300 | add article-media-placeholder class to tests 2016-04-06 15:40:25 +02:00
Igor Rogatty 455e4b5e75 XW-1300 | support for image collections 2016-04-05 17:42:21 +02:00
Igor Rogatty 17a045e1aa XW-1300 | add tests for Mercury experimental markup 2016-04-04 15:50:36 +02:00
Lukasz Konieczny 06fad58042 CE-3554: Support more sources 2016-04-01 12:54:43 +00:00
Lukasz Konieczny 4f11b96e48 CE-3554: Changes after CR 2016-04-01 11:07:30 +00:00
Igor Rogatty 07cdefb0f5 XW-1300 | use mercury-component-attrs name and fix unit tests 2016-04-01 12:06:10 +02:00
Lukasz Konieczny 88030ff0d2 CE-3554: Add unit tests for extracting labels 2016-03-31 10:00:03 +00:00
idradm 25dd444a80 DAT-4018 add test for europa theme enabled 2016-03-29 12:57:07 +02:00
idradm cbc0a10a78 DAT-3934 add tests for custom width 2016-03-17 12:12:36 +01:00
idradm af041c9196 DAT-3934 provide a way to decide on image size while infobox rendering 2016-03-17 10:37:18 +01:00
Rafal Leszczynski 604e9da6df DAT-3937, remove special case for europa thumbnail width 2016-03-14 10:36:08 +01:00
Rafal Leszczynski 5c75f627a2 DAT-3937, set different image width for europa theme only 2016-03-14 08:57:58 +01:00
Rafal Leszczynski e355f58e04 DAT-3855, fix tests 2016-03-09 15:51:51 +01:00
Rafal Leszczynski 7a12be6310 DAT-3855, round image display dimensions 2016-03-09 10:45:31 +01:00
Rafal Leszczynski fbceb63dcc DAT-3855, fix broken test after thumbnail size change 2016-03-08 16:06:54 +01:00
marzjan a874af74af Update @covers annotation for PortableInfobox tests 2016-02-25 15:51:47 +00:00
idradm 20d6a46421 DAT-3707 create infobox builder extension 2016-02-12 11:38:47 +01:00
idradm d4953f7680 Merge branch 'dev' into infobox-builder-feature-branch
# Conflicts:
#	extensions/wikia/AdminDashboard/AdminDashboardLogic.class.php
#	extensions/wikia/AssetsManager/config.php
#	extensions/wikia/EditPageLayout/templates/EditPageLayout_EditPage.php
2016-02-09 11:46:56 +01:00
Sebastian Marzjan c5d17f315e DAT-3624 Rename 'Infobo' to 'Infobox' 2016-02-03 12:06:44 +01:00
Sebastian Marzjan 168bf09348 DAT-3621 Unified tests for hero image and regular caption
* Disable sanitization on Oasis
* Handle previously unsupported case of nested tag ( <b><a></a></b> )
* Unify test formatting
* Change list handling (yes, I am not proud of that)
2016-01-12 09:21:21 +01:00
Sebastian Marzjan 531fc700e6 Provide explicitly encoded XML to loadHTML (libxml issues ;-) ) 2016-01-08 08:24:09 +01:00
Sebastian Marzjan 2171b5c02c Merge pull request #9366 from Wikia/DAT-3331
make infoboxes use params same way as mediawiki, enable 0 param
2016-01-05 17:18:33 +01:00
Sebastian Marzjan 72392d0edd Normalize whitespace when processing infobox contents 2016-01-05 09:05:50 +01:00
idradm c477600b9d DAT-3331 update comment, reformat 2016-01-04 15:57:25 +01:00
idradm 5f42ce9742 make infoboxes use params same way as mediawiki, enable 0 param 2016-01-04 14:34:10 +01:00
Sebastian Marzjan 2fdebcdffb DAT-3465 Change approach to sanitization; use XML parsing 2015-12-30 11:00:10 +01:00
Sebastian Marzjan 0ce0b500fe Use the Builder for Sanitizers.
Cover the sanitizer build step in tests too
2015-12-28 12:04:36 +01:00
Sebastian Marzjan 8f437fb1e7 DAT-3465 Update the caption behavior 2015-12-28 10:21:32 +01:00
dianafa a4e03f9147 add sanitizer tests 2015-12-23 16:08:43 +01:00
dianafa 8afcb73d10 move sanitizers to a separate folder 2015-12-23 15:54:03 +01:00
dianafa ed73d4f525 move sanitizing to PortableInfoboxRenderService 2015-12-23 13:20:55 +01:00
Rafal Leszczynski f154200a97 DAT-3576, add test for thin portrait image edge case 2015-12-11 16:34:03 -08:00
marzjan 46fbb2b9c3 Make test cases make sense :) 2015-12-11 10:40:40 -08:00
Sebastian Marzjan f1896da8ab Add tests 2015-12-11 10:01:23 -08:00
dianafa 33af8b75e9 rename getAdjustedImageSize to getImageSizesForThumbnailer 2015-12-11 12:02:00 +01:00
dianafa cc54d4478d move logic to other place & add tests 2015-12-11 11:56:41 +01:00
Inez Korczynski b1efc457c3 VE-2069: Adjust tests to data that ImageNode is returning 2015-12-07 22:11:19 +00:00
dianafa 6e8091ec4d move ImageFilenameSanitizer logic to FileNamespaceSanitizeHelper 2015-11-25 11:00:39 +01:00
Diana 15a00b4d4e sanitize horizontal group items as well 2015-11-05 17:57:53 +00:00
Diana 91804e99c3 add test for sole image in label 2015-11-05 13:29:42 +00:00
Diana 49feb54689 change method name to sanitizeInfoboxFields and refactor 2015-11-05 13:21:20 +00:00
dianafa 649895d4cf change variable names and add missing PHPdocs 2015-11-03 17:19:29 +01:00
dianafa 79a0bf14fa DAT-3329 add more tests and clean identation 2015-11-03 16:36:52 +01:00
dianafa 569ef4ae4c add tests 2015-11-03 16:11:08 +01:00
Inez Korczynski 70d18e11ea VE-2003: Remove unncecessary empty lines 2015-10-28 17:57:00 +00:00
Inez Korczynski d46955d8ee VE-2003: Created unit tests to "collapse" attribute of PI groups 2015-10-28 17:55:03 +00:00
Inez Korczynski 2faa1bd633 VE-1994: Fix unit tests 2015-10-26 22:06:10 +00:00
Inez Korczynski 8fc355ecea VE-1982: Basic unit test coverage for backward compatibility added to <image> 2015-10-20 22:42:36 +00:00
Inez Korczynski b93c9607a2 VE-1982: Make sourceProvider content more readable and easier to understand 2015-10-20 21:30:07 +00:00
Inez Korczynski f693207998 VE-1982: Make dataProvider content more readable and easier to understand 2015-10-20 21:28:27 +00:00
Inez Korczynski a692e008b3 VE-1975: Modified NodeImage to return array of images instead of one image
Added support for <tabber>
Hero image still works correct
2015-10-16 01:15:52 +00:00
dianafa e658aed5ca Merge branch 'dev' into infobox-builder-feature-branch 2015-10-05 18:39:29 +02:00
Nikodem 97623fe9a5 Merge pull request #8614 from Wikia/DAT-3294
DAT-3294 add infobox-hero-image context handling
2015-09-30 12:45:48 +02:00
Diana 2565999c3d remove inaccuracy between image data and image data mocks 2015-09-28 16:15:49 +00:00
idradm c940d474d3 DAT-3199 unit test fix for changed default return value 2015-09-28 10:30:19 +02:00
idradm 88c886bf09 DAT-3199 add tests for template parsing 2015-09-24 13:48:51 +02:00
idradm 357efeee9c DAT-3199 test will extend WikiaBaseTest now, fix tests global scope pollution 2015-09-24 12:41:48 +02:00
idradm dbef0b9915 DAT-3199 unit tests fixed 2015-09-23 15:51:41 +02:00
Rafal Leszczynski 35fd8d87a4 Merge branch 'DAT-3153' into infobox-builder-feature-branch 2015-09-11 12:48:37 +02:00
Nikodem ce6aa2431f Merge pull request #8398 from Wikia/DAT-3073
DAT-3073 set max height for infobox images on desktop
2015-09-10 11:42:33 +02:00
Nikodem 9767ef0d50 Merge pull request #8366 from Wikia/DAT-3194
Dat 3194 - for videos in infobox use link to file page instead of link to original image
2015-09-09 17:24:39 +02:00
Diana b29d6099a0 add comment 2015-09-09 17:04:06 +02:00
dianafa 0c8e2545a9 addd tests 2015-09-09 14:54:26 +02:00
Rafal Leszczynski a027e8a2c9 get title from file 2015-09-09 13:23:34 +02:00
Sebastian Marzjan 351d0f94e5 DAT-3200 Adding support for urlencoded image names in infoboxes 2015-09-08 14:12:23 -07:00
Nikodem 95d6bc152b Merge pull request #8370 from Wikia/DAT-3127
DAT-3127 treat 0 as valid value inside <format> tag
2015-09-08 15:07:24 +02:00
Rafal Leszczynski bb7421acb7 treat 0 as valid value inside <format> tag 2015-09-08 11:29:49 +02:00
idradm c5adee4ff7 DAT-3207 tests update 2015-09-08 10:26:48 +02:00
idradm 97c8de1842 DAT-3207 add mw namespaces aliases to image filename sanitizer 2015-09-08 10:25:10 +02:00
Rafal Leszczynski 66b286c427 fix unit tests after changing URL generation for video item 2015-09-07 18:21:17 +02:00
Nikodem 5d68ec75c8 Merge pull request #8348 from Wikia/DAT-3197
DAT-3197 wrap content tags contents in CDATA before parsing
2015-09-07 14:47:33 +02:00
Rafal Leszczynski 837d0ec171 update test after adding check for not rendering labels row if all labels in horizontal group are empty strings 2015-09-07 13:26:07 +02:00
idradm 2aa83e9e57 DAT-3197 wrap content tags contents in CDATA before parsing 2015-09-07 12:22:56 +02:00
idradm bfef593cc0 DAT-3153 map defaultValue to default, publish will work only in template namespace 2015-09-04 12:54:07 +02:00
idradm 6f70123af7 DAT-3153 test renamed 2015-09-01 09:42:51 +02:00
idradm 69ee848c1b DAT-3153 infobox builder publish added 2015-08-31 17:42:38 +02:00
Rafal Leszczynski 91b490c05a unify portable infobox item side spacing 2015-08-04 12:06:14 +02:00
Rafal Leszczynski 61ffd930f1 add additional class name for easy access to overwrite border color in custom theming 2015-07-31 14:54:10 +02:00
Rafal Leszczynski 5618734513 fix tests after refactoring 2015-07-29 17:40:21 +02:00
Rafal Leszczynski a2680407f3 fix error after solving merge conflicts 2015-07-29 15:22:28 +02:00
Rafal Leszczynski 9ecc835603 Merge branch 'dev' into DAT-3003-cleanup-feature-branch 2015-07-29 15:04:51 +02:00
Rafal Leszczynski ec7369d378 remove return from doc block 2015-07-29 14:16:58 +02:00
Rafal Leszczynski c773f43c9c address CR comments 2015-07-29 13:51:55 +02:00
Rafal Leszczynski c92bce20cd finish test refactoring 2015-07-29 10:58:39 +02:00
Rafal Leszczynski 22371f6bf3 change render service helper fron singleton to instantiable class and refactor tests 2015-07-28 16:13:36 +02:00
marzjan f5b26aac82 Fixing File mocking 2015-07-28 12:15:27 +00:00
Rafal Leszczynski 1324073ccb move helper methods from render service to separate class and refactor tests in progress 2015-07-28 13:51:30 +02:00
Rafal Leszczynski 0b44c38814 fix test after default layout change 2015-07-27 16:49:15 +02:00
Rafal Leszczynski bc22980d2a Merge branch 'dev' into DAT-3025 2015-07-27 11:39:40 +02:00
dianafa 654b8da8ce merge with dev 2015-07-22 15:28:39 +02:00
marzjan bdee8bab34 Fix the test 2015-07-22 13:24:18 +00:00
Rafal Leszczynski 07fbcc4f18 add test to image node for video 2015-07-22 13:04:41 +02:00
Rafal Leszczynski c3d81dd456 add tests for rendering video thumbnail 2015-07-22 12:11:19 +02:00
Diana cf22303f9d don't render image inside hero module title 2015-07-21 23:13:28 +00:00
Diana ccfd342a3d update comment 2015-07-21 14:30:13 +02:00
Diana e8bfd73381 change MAIN to PLATFORM ticket 2015-07-21 12:11:36 +00:00
Diana d12cea9be6 add comments TODO 2015-07-21 12:02:51 +00:00
Diana fe85628f0e fix logic & tests 2015-07-21 11:33:24 +00:00
Diana 6425ac0299 move sanitizeInfoboxTitle to renderService 2015-07-20 13:00:35 +00:00
Diana 3bea79bbe9 add NodeTitle test 2015-07-20 12:02:10 +00:00
Diana 225321ca8a refactor & test update 2015-07-20 09:52:32 +00:00
Diana 57279eb5da fast fix, test will not pass but works 2015-07-17 16:02:24 +00:00
Diana ece0d06c84 render hero module only for images big enough 2015-07-17 13:43:08 +00:00
Diana 403ff30d2a fix tests after merge 2015-07-16 11:21:20 +00:00
dianafa 2e0e607b73 merge with dev 2015-07-16 13:06:17 +02:00
Diana 4bfe7cf215 rename functions 2015-07-13 08:56:19 +00:00
Diana eb7be6fcb4 refactor test functions 2015-07-10 14:57:57 +00:00
Diana ecc7caf1ef git add descrs 2015-07-10 12:31:43 +00:00
Diana 837b67bbb3 fix functionality of renderImage 2015-07-10 12:10:03 +00:00
Diana cc01be9176 refactor tests 2015-07-10 11:19:08 +00:00
Diana 286617ac8b typo 2015-07-09 19:08:25 +02:00
Diana 8ff4d4c491 add invalid thumb case 2015-07-09 17:07:10 +00:00
Diana b1e13f6a4e add else 2015-07-09 16:06:22 +00:00
Diana 238a28a071 mock methods 2015-07-09 13:50:12 +00:00
Diana e56afa7f84 update tests 2015-07-09 07:03:41 +00:00
Diana 7ddf7b4782 fix tests 2015-07-07 10:49:05 +00:00
idradm 597503b643 DAT-2933 add more test cases 2015-07-07 09:06:37 +02:00
dianafa bf790b3322 Merge branch 'dev' into DAT-2909 2015-07-06 18:46:02 +02:00
idradm f3c4062db7 DAT-2933 support html entities in infobox templates 2015-07-06 18:15:29 +02:00
idradm e33a0b77f2 DAT-2941 fix setUp method 2015-07-03 12:17:24 +02:00
Sebastian Marzjan 86bfcc7592 Cherry-picking 9eb06cc 2015-07-03 12:16:18 +02:00
idradm e065533850 Merge remote-tracking branch 'origin/dev' into DAT-2909
# Conflicts:
#	extensions/wikia/GameGuides/assets/GameGuidesAssets.json
#	extensions/wikia/PortableInfobox/services/PortableInfoboxRenderService.class.php
2015-07-03 10:51:32 +02:00
Rodrigo Molinero Gomez 7360054705 Merge pull request #7698 from Wikia/DAT-2944
DAT-2944 remove source for label tag functionality
2015-07-02 16:38:03 +02:00
Rodrigo Molinero Gomez d2a069d56d Merge pull request #7714 from Wikia/DAT-2940
DAT-2940 rename footer tag to navigation
2015-07-02 15:27:47 +02:00
idradm edda7bebbd DAT-2940 rename css selectors 2015-07-02 10:22:37 +02:00
Rafal Leszczynski 04e268d57a add hero tests plus general render test refactor 2015-07-01 18:03:57 +02:00
Rafal Leszczynski 57e5d5f59f add render tests for hero component 2015-07-01 16:34:34 +02:00