Commit graph

1088 commits

Author SHA1 Message Date
idradm 28c4d0051d XW-2443 refactor if statement 2016-12-27 10:07:10 +01:00
idradm ac52e392bc XW-2443 remove unnecessary assignment 2016-12-27 10:01:49 +01:00
idradm 8ce60507f0 XW-2443 refactor unit tests, add more cases 2016-12-27 10:00:26 +01:00
idradm 116427f924 XW-2443 use both static and variable based themes 2016-12-27 09:25:44 +01:00
idradm 3ef4b30456 reset page props on template edit 2016-12-21 09:09:25 +01:00
idradm 4b29763fb0 use both themes 2016-12-19 17:24:50 +01:00
idradm 7166ca0470 XW-2415 make sure render data is an array 2016-12-19 15:17:40 +01:00
idradm b4f12c868f XW-2415 reparse if parser version missing 2016-12-19 13:27:19 +01:00
Igor Rogatty f4e8e30306 XW-2415 | test getMetadata 2016-12-14 17:32:10 +01:00
Igor Rogatty 4705117c83 XW-2415 | test getSourcesMetadata method and fix an issue that was found 2016-12-14 15:46:17 +01:00
Igor Rogatty 7889cb59e4 XW-2415 | fix multiple warnings in tests 2016-12-14 15:20:10 +01:00
Igor Rogatty 380c2900b9 XW-2415 | fix unit tests 2016-12-14 13:54:53 +01:00
Igor Rogatty 74eaae9559 XW-2415 | reparse only the pages with infoboxes property 2016-12-14 12:44:23 +01:00
Igor Rogatty f138e36089 XW-2415 | make TemplatesHelper more generic 2016-12-14 12:31:25 +01:00
Igor Rogatty c599b34595 XW-2415 | simplify logic in getSourcesMetadata() 2016-12-13 17:56:33 +01:00
Igor Rogatty 38aec59849 XW-2415 | treat infobox templates and articles with infoboxes separately 2016-12-13 17:41:55 +01:00
Igor Rogatty cefbe11d71 XW-2415 | handle groups when format=xml 2016-12-13 14:49:32 +01:00
Igor Rogatty 80a9500997 XW-2415 | keep it dry 2016-12-09 17:11:17 +01:00
Igor Rogatty 6dea854d48 XW-2415 | use parser tag version and reparse infoboxes if needed 2016-12-09 16:55:42 +01:00
Igor Rogatty 7ad06f684a XW-2415 | handle images inside groups 2016-12-09 15:56:57 +01:00
Igor Rogatty 5712de9f05 XW-2415 | save infobox metadata, not just labels 2016-12-09 14:01:49 +01:00
Igor Rogatty e9dc03726d XW-2415 | set title for RefreshLinksForTitleTask 2016-12-09 10:59:03 +01:00
Igor Rogatty 3b704769ff XW-2415 | infobox dialog in VE knows the source types 2016-12-07 19:02:00 +01:00
Damian Jozwiak 4acf41caef XW-2307 | Whitelist videos in Portable Infoboxes 2016-11-22 13:02:56 +01:00
Weronika Rudnicka c9363473b2 XW-2307 | mocking getMediaType method in custom width logic test 2016-11-21 23:17:32 +01:00
Weronika Rudnicka 8d055fb35c XW-2307 | fixed whitespaces, using getMediaType method 2016-11-21 23:15:51 +01:00
Weronika Rudnicka 33210522f2 XW-2307 | in infobox only image files are displayed 2016-11-21 15:13:13 +01:00
idradm 3e586523e4 XW-2278 fix wikitext lists after variables were replaced 2016-11-14 11:24:44 +01:00
Weronika Rudnicka 0fd6074159 Merge pull request #11770 from Wikia/XW-2277
XW-2277 | Replace image links in PI on Monobook with File page URLs
2016-11-04 13:27:38 +01:00
Igor Rogatty 7a9a95b81c XW-2277 | cancel the change if there is no data-image-key 2016-11-04 13:14:34 +01:00
Igor Rogatty 3dee529ca8 XW-2277 | data-image-key is already encoded with urlencode() 2016-11-04 13:00:41 +01:00
Igor Rogatty bcc409483a XW-2277 | use wgArticlePath 2016-11-03 16:56:35 +01:00
Igor Rogatty 7d505ab62f XW-2277 | replace link only on click 2016-11-03 16:11:23 +01:00
Damian Jozwiak d4a9943eaf XW-2234 | Fix testRenderInfobox unit test 2016-11-03 15:40:21 +01:00
Damian Jozwiak 6e1a075cad XW-2234 | Fix testCustomWidthLogic unit test 2016-11-03 15:32:16 +01:00
Weronika Rudnicka 89ba74b37e XW-2234 | displaying better quality images for retina for infoboxes image collections 2016-11-03 15:04:37 +01:00
Igor Rogatty e0394adb61 XW-2277 | replace image links in PI on Monobook with File page URLs 2016-11-03 14:44:29 +01:00
Weronika Rudnicka ee7404ef6b XW-2234 | added srcset to infobox image, to display better quality images for retina 2016-11-03 14:27:43 +01:00
macbre a444abc707 Revert "PortableInfoboxRenderServiceTest: temporarily skip testRenderInfobox"
This reverts commit 63ba16643458ce39f61050acc4259156cfb35305.
2016-06-27 12:19:13 +02:00
macbre 4f5e9462dc PortableInfoboxRenderServiceTest: temporarily skip testRenderInfobox 2016-06-24 10:23:45 +02:00
grunny 36f77e2a8d Add comment explaining where the Mercury PI replacements occur 2016-06-20 18:24:38 +10:00
grunny c006c42035 (CE-3844) Refactor fix for PI and parser tag fix
A security fix from MW core added quotes to the Parser's strip tag
markers in order to prevent an XSS vulnerability. When this was deployed
PIs and our Wikia tag extensions broke in Mercury because ArticlesAsJson
JSON encodes the parser output in the ParserAfterTidy, but then PI and
the tag extensions were manually replacing the Parser tag strip markers
on the already JSON encoded string within their own ParserAfterTidy methods
(which were always run after the ArticlesAsJson method). This meant that the
strip marker had the quote escaped with a backslash in the encoded string,
so the string replacements failed.

This change follows the previous quick and dirty fix by moving the replacements
in PI and the tag extensions to just before ArticlesAsJson encodes the output.
Which also removes the need from before the fix in #10701 to JSON encode the
parser output of the tags that will be replaced into the text.
2016-06-17 20:57:12 +10:00
grunny 61bdc6e652 (DAT-4494) Only decode when it's the main JSON array 2016-06-17 04:14:47 +10:00
grunny ddd6c61e79 (DAT-4494) We don't need to json encode here anymore 2016-06-17 03:59:52 +10:00
grunny e191fbd396 Fix unit tests 2016-06-17 03:52:32 +10:00
grunny 899b127b00 (DAT-4494) Don't perform replacements on JSON encoded content 2016-06-16 17:39:06 +00:00
grunny 8186618eb9 (DAT-4494) Fix galleries and tabber in PortableInfoboxes 2016-06-16 16:59:48 +00:00
Warkot 10f96eaa96 XW-1478 | extendImageData has to be run even for the first PI 2016-05-31 00:20:39 +02:00
Warkot 1fa29ea03b XW-1478 | don't render the whole hero module including the title on Mercury 2016-05-30 21:30:25 +02:00
Warkot 908327db5d XW-1478 | don't render hero image in first infobox on Mercury 2016-05-30 18:35:11 +02:00