Universal-Omega/PortableInfobox
1
0
Fork 0
mirror of https://github.com/Universal-Omega/PortableInfobox.git synced 2024-11-15 11:59:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

unify the file creation method

Browse source
This commit is contained in:
Diana 2015-05-25 11:02:35 +00:00
parent ff623260e7
commit 8e1834c810
2 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
services/Parser/Nodes/NodeImage.php
View file

@ -41,8 +41,8 @@ class NodeImage extends Node {
*/
public function resolveImageUrl( $title ) {
if ( $title ) {
$file = \WikiaFileHelper::getFileFromTitle($title);
if ($file) {
$file = \WikiaFileHelper::getFileFromTitle( $title );
if ( $file ) {
return $file->getUrl();
}
}

10
services/PortableInfoboxRenderService.class.php
View file

@ -185,7 +185,7 @@ class PortableInfoboxRenderService extends WikiaService {
private function createVignetteThumbnail( $url ) {
return VignetteRequest::fromUrl( $url )
->thumbnailDown()
->width(F::app()->checkSkin( 'wikiamobile' ) ?
->width( F::app()->checkSkin( 'wikiamobile' ) ?
self::MOBILE_THUMBNAIL_WIDTH :
self::DESKTOP_THUMBNAIL_WIDTH
)
@ -197,15 +197,15 @@ class PortableInfoboxRenderService extends WikiaService {
* @desc If the image is served from an old
* service we have to again obtain file to
* call the createThumb function
* @param $name
* @param $title
* @return mixed
*/
private function createOldThumbnail( $name )
private function createOldThumbnail( $title )
{
$file = wfFindFile( $name );
$file = \WikiaFileHelper::getFileFromTitle( $title );
if ( $file ) {
return $file->createThumb(
F::app()->checkSkin('wikiamobile') ?
F::app()->checkSkin( 'wikiamobile' ) ?
self::MOBILE_THUMBNAIL_WIDTH :
self::DESKTOP_THUMBNAIL_WIDTH
);