Universal-Omega/PortableInfobox
1
0
Fork 0
mirror of https://github.com/Universal-Omega/PortableInfobox.git synced 2024-11-15 11:59:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

do not treat 0 as empty footer

Browse source
This commit is contained in:
Diana 2015-05-20 14:57:43 +00:00
parent 68b9b27a93
commit 3a706ef159
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/Parser/Nodes/NodeFooter.php
View file

@ -11,6 +11,6 @@ class NodeFooter extends Node {
public function isEmpty( $data ) {
$links = trim( $data['value'] );
return empty( $links );
return empty( $links ) && $links != '0';
}
}

6
tests/NodeFooterTest.php
View file

@ -25,7 +25,11 @@ class NodeFooterTest extends WikiaBaseTest {
],
[
'string' => '<footer>0</footer>',
'expectedOutput' => true
'expectedOutput' => false
],
[
'string' => '<footer>\'0\'</footer>',
'expectedOutput' => false
],
[
'string' => '<footer></footer>',