StarCitizenTools/mediawiki-skins-Citizen
1
0
Fork 0
mirror of https://github.com/StarCitizenTools/mediawiki-skins-Citizen.git synced 2024-11-13 17:49:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): 🐛 pass namespace key as string

Browse source 
When the namespace key only consists of number, it can cause a TypeError.

Fixes: #849
This commit is contained in:
alistair3149 2024-05-18 19:47:30 -04:00 committed by GitHub
parent b9225057a7
commit f781773cba
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/Hooks/SkinHooks.php
View file

@ -287,7 +287,7 @@ class SkinHooks implements
// Since talk keys have namespace as prefix // Since talk keys have namespace as prefix
foreach ( $links['associated-pages'] as $key => $item ) { foreach ( $links['associated-pages'] as $key => $item ) {
// I wish I can use str_ends_with but need to wait for PHP 7.X to be dropped // I wish I can use str_ends_with but need to wait for PHP 7.X to be dropped
if ( substr( $key, -4 ) === 'talk' ) { if ( substr( (string)$key, -4 ) === 'talk' ) {
$links['associated-pages'][$key]['icon'] = 'speechBubbles'; $links['associated-pages'][$key]['icon'] = 'speechBubbles';
} }
} }