From e6538888fe745489b395f2abaab322d13a6dca1b Mon Sep 17 00:00:00 2001 From: alistair3149 Date: Mon, 4 Nov 2024 18:50:07 -0500 Subject: [PATCH] =?UTF-8?q?refactor(core):=20=E2=99=BB=EF=B8=8F=20fix=20va?= =?UTF-8?q?rious=20phpcs=20issues?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- includes/Api/ApiWebappManifest.php | 2 ++ includes/Components/CitizenComponentSearchBox.php | 8 +++----- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/includes/Api/ApiWebappManifest.php b/includes/Api/ApiWebappManifest.php index 41325c2c..b862be26 100644 --- a/includes/Api/ApiWebappManifest.php +++ b/includes/Api/ApiWebappManifest.php @@ -121,6 +121,8 @@ class ApiWebappManifest extends ApiBase { /** * Get src, sizes, and type for each icon for the manifest * + * @param string $logoPath + * @param string $logoContent * @return array|null */ private function getIconData( $logoPath, $logoContent ) { diff --git a/includes/Components/CitizenComponentSearchBox.php b/includes/Components/CitizenComponentSearchBox.php index fd32aca5..dcf35303 100644 --- a/includes/Components/CitizenComponentSearchBox.php +++ b/includes/Components/CitizenComponentSearchBox.php @@ -67,15 +67,13 @@ class CitizenComponentSearchBox implements CitizenComponent { * @inheritDoc */ public function getTemplateData(): array { - $searchBoxData = $this->searchBoxData; - $randompageUrl = SpecialPage::getTitleFor( 'Randompage' )->getLocalURL(); - - return $searchBoxData += [ + $searchBoxData = $this->searchBoxData + [ 'array-keyboard-hint' => $this->getKeyboardHintData(), 'msg-citizen-search-footer' => $this->getFooterMessage(), 'msg-citizen-search-toggle-shortcut' => '[/]', // TODO: Replace with SkinComponentUtils on 1.43 - 'html-random-href' => $randompageUrl, + 'html-random-href' => SpecialPage::getTitleFor( 'Randompage' )->getLocalURL() ]; + return $searchBoxData; } }