StarCitizenTools/mediawiki-skins-Citizen
1
0
Fork 0
mirror of https://github.com/StarCitizenTools/mediawiki-skins-Citizen.git synced 2024-11-15 02:24:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(search): 🐛 do not add empty term to search history

Browse source
This commit is contained in:
alistair3149 2023-08-22 14:20:54 -07:00
parent 2ed6b71165
commit bd41516190
No known key found for this signature in database
GPG key ID: 16076C01E5C88864
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
resources/skins.citizen.search/typeahead.js
View file

@ -194,14 +194,15 @@ const typeahead = {
const item = event.target.closest( '.citizen-typeahead__item' );
if ( item instanceof HTMLElement ) {
let historyLabel;
// User click on a suggestion -> save the matched title > title
if ( item.classList.contains( 'citizen-typeahead__item-page' ) ) {
historyLabel = item.querySelector( '.citizen-typeahead__label' ).innerText ?? item.querySelector( '.citizen-typeahead__title' ).innerText;
historyLabel = item.querySelector( '.citizen-typeahead__label' ).innerText || item.querySelector( '.citizen-typeahead__title' ).innerText;
} else {
historyLabel = searchQuery.value;
}
searchHistory.add( historyLabel );
if ( historyLabel ) {
searchHistory.add( historyLabel );
}
}
}
},