From b39452d3b5684b085d679f17842d67e9a000100e Mon Sep 17 00:00:00 2001 From: alistair3149 Date: Sun, 1 May 2022 18:45:48 -0400 Subject: [PATCH] refactor(core): remove unnessecary style overrides for links * Visited link styles are removed from MW already, there are no need to use important to override those rules. * Citizen should not override text-decoration setting if users want to have underline links. --- resources/skins.citizen.styles/Catlinks.less | 4 ++-- resources/skins.citizen.styles/common/common.less | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/resources/skins.citizen.styles/Catlinks.less b/resources/skins.citizen.styles/Catlinks.less index bdd53ed8..16f5c3ab 100644 --- a/resources/skins.citizen.styles/Catlinks.less +++ b/resources/skins.citizen.styles/Catlinks.less @@ -50,12 +50,12 @@ a { display: inline-block; padding: 7px 15px; - color: var( --color-base--subtle ) !important; // Override + color: var( --color-base--subtle ); transition: @transition-background-quick; &:hover { background-color: var( --color-primary--hover ); - color: @base-100 !important; + color: #fff; } &.new:hover { diff --git a/resources/skins.citizen.styles/common/common.less b/resources/skins.citizen.styles/common/common.less index f3a999e6..64fb97e3 100644 --- a/resources/skins.citizen.styles/common/common.less +++ b/resources/skins.citizen.styles/common/common.less @@ -134,7 +134,7 @@ td { a { color: var( --color-link ); - text-decoration: none !important; + text-decoration: none; &:not( [ href ] ) { cursor: pointer; @@ -150,14 +150,14 @@ a { } &.new { - color: var( --color-link-new ) !important; // Override visited + color: var( --color-link-new ); // Override visited &:hover { - color: var( --color-link-new--hover ) !important; + color: var( --color-link-new--hover ); } &:active { - color: var( --color-link-new--active ) !important; + color: var( --color-link-new--active ); } }