StarCitizenTools/mediawiki-skins-Citizen
1
0
Fork 0
mirror of https://github.com/StarCitizenTools/mediawiki-skins-Citizen.git synced 2024-11-28 08:10:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): ♻️ re-implement VE action icon

Browse source
This commit is contained in:
alistair3149 2024-05-06 13:37:33 -04:00
parent 9a403ee44a
commit a81bf1fc16
No known key found for this signature in database
3 changed files with 7 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
includes/Hooks/SkinHooks.php
View file

@ -417,10 +417,7 @@ class SkinHooks implements
'edit' => 'edit', 'edit' => 'edit',
'view-foreign' => 'linkExternal', 'view-foreign' => 'linkExternal',
// Extension:VisualEditor // Extension:VisualEditor
// For some reason the icon span element keeps getting removed 've-edit' => 'edit',
// So we are adding this the legacy way
// Bug: T323188
// 've-edit' => 'edit',
// Extension:DiscussionTools // Extension:DiscussionTools
'addsection' => 'speechBubbleAdd' 'addsection' => 'speechBubbleAdd'
]; ];

13
resources/skins.citizen.styles/components/Pagetools.less
View file

@ -171,7 +171,6 @@
} }
} }
> a,
.citizen-ui-icon { .citizen-ui-icon {
&::before { &::before {
filter: invert( 1 ); filter: invert( 1 );
@ -184,18 +183,6 @@
// VE styles shouldn't be core but it is just a few lines :/ // VE styles shouldn't be core but it is just a few lines :/
#ca-ve-edit { #ca-ve-edit {
order: 98; // Before source edit order: 98; // Before source edit
> a {
// See SkinHooks.php for why VE is here
&::before {
width: var( --size-icon );
height: var( --size-icon );
content: '';
background-repeat: no-repeat;
background-position: center;
background-size: var( --size-icon );
}
}
} }
#ca-edit { #ca-edit {

8
skin.json
View file

@ -19,6 +19,11 @@
"Disabled": [ "Disabled": [
"citizen" "citizen"
] ]
},
"VisualEditor": {
"IconSkins": [
"citizen"
]
} }
}, },
"ValidSkinNames": { "ValidSkinNames": {
@ -277,8 +282,7 @@
"selector": "{name}", "selector": "{name}",
"defaultColor": "#000", "defaultColor": "#000",
"images": { "images": {
".citizen-toc__top:before": "resources/skins.citizen.icons/backToTop.svg", ".citizen-toc__top:before": "resources/skins.citizen.icons/backToTop.svg"
"#ca-ve-edit > a:before": "resources/skins.citizen.icons/wmui/edit.svg"
} }
}, },
"skins.citizen.icons.wmui": { "skins.citizen.icons.wmui": {