StarCitizenTools/mediawiki-skins-Citizen
1
0
Fork 0
mirror of https://github.com/StarCitizenTools/mediawiki-skins-Citizen.git synced 2024-11-28 08:10:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): 🐛 check for mw-heading wrapper first before mw-parser-output

Browse source 
The current implementation will fail with the new mw-heading wrapper
This commit is contained in:
alistair3149 2023-09-11 14:04:43 -04:00
parent 9cba4f5a63
commit 672740a23a
No known key found for this signature in database
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
includes/Partials/BodyContent.php
View file

@ -230,16 +230,14 @@ final class BodyContent extends Partial {
$parentClasses = DOMCompat::getClassList( $parent );
// Only target page headings, but not other heading tags
// TODO: Drop this when T13555 is deployed on LTS
if ( !$parentClasses->contains( 'mw-parser-output' ) ) {
continue;
}
// Use the `<div class="mw-heading">` wrapper if it is present. When they are required
// (T13555), the querySelectorAll() above can use the class and this can be removed.
if ( $parentClasses->contains( 'mw-heading' ) ) {
$el = $parent;
} else if ( !$parentClasses->contains( 'mw-parser-output' ) ) {
// Only target page headings, but not other heading tags
// TODO: Drop this when T13555 is deployed on LTS
continue;
}
// This check can be removed too when we require the wrappers.