refactor(core): ♻️ use the same code pattern for SkinEditSectionLinks

This commit is contained in:
alistair3149 2022-11-15 22:39:10 -05:00
parent 2ec7da29a5
commit 5c375bb71d
No known key found for this signature in database

View file

@ -116,19 +116,22 @@ class SkinHooks implements
* @param Language $lang
*/
public function onSkinEditSectionLinks( $skin, $title, $section, $sectionTitle, &$result, $lang ) {
/*
* FIXME: For some reason if you modify the VE button, it duplicates one automatically
* Bug: T323186
*
* if ( $result['veeditsection'] ) {
* $result['veeditsection']['attribs']['class'] = 'mw-ui-icon-wikimedia-edit';
* }
*/
// Be extra safe because it might be active on other skins with caching
if ( $skin->getSkinName() === 'citizen' && $result ) {
/*
* FIXME: For some reason if you modify the VE button, it duplicates one automatically
* Bug: T323186
*
* if ( isset( $result['veeditsection'] ) ) {
* $result['veeditsection']['attribs']['class'] = 'mw-ui-icon-wikimedia-edit';
* }
*/
// Add icon to edit section link
// If VE button is present, use wikiText icon
if ( $result['editsection'] ) {
$result['editsection']['attribs']['class'] = $result['veeditsection'] ? 'mw-ui-icon-wikimedia-wikiText' : 'mw-ui-icon-wikimedia-edit';
// Add icon to edit section link
// If VE button is present, use wikiText icon
if ( isset( $result['editsection'] ) ) {
$result['editsection']['attribs']['class'] = $result['veeditsection'] ? 'mw-ui-icon-wikimedia-wikiText' : 'mw-ui-icon-wikimedia-edit';
}
}
}