StarCitizenTools/mediawiki-skins-Citizen
1
0
Fork 0
mirror of https://github.com/StarCitizenTools/mediawiki-skins-Citizen.git synced 2024-11-11 16:48:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(stickyHeader): 🐛 use margin and padding instead of grid gap for body spacing

Browse source 
That should address the flickering issue caused by the sticky header
This commit is contained in:
alistair3149 2024-07-02 19:26:50 -04:00
parent 7ec0ae5b8e
commit 2f7ae8fc1d
No known key found for this signature in database
3 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
resources/skins.citizen.styles/components/PageFooter.less
View file

@ -3,6 +3,7 @@
flex-direction: column; flex-direction: column;
grid-area: footer; grid-area: footer;
gap: var( --space-xl ); gap: var( --space-xl );
padding-top: var( --space-md );
margin-top: var( --space-md ); margin-top: var( --space-md );
line-height: var( --line-height-sm ); line-height: var( --line-height-sm );
} }

1
resources/skins.citizen.styles/components/StickyHeader.less
View file

@ -16,7 +16,6 @@
.citizen-page-header--sticky { .citizen-page-header--sticky {
.citizen-page-header { .citizen-page-header {
flex-wrap: nowrap; flex-wrap: nowrap;
padding-bottom: var( --space-md );
white-space: nowrap; white-space: nowrap;
.citizen-sticky-header; .citizen-sticky-header;

3
resources/skins.citizen.styles/layout.less
View file

@ -18,7 +18,7 @@
'footer'; 'footer';
// Using auto as min value will cause overflow // Using auto as min value will cause overflow
grid-template-columns: minmax( 0, var( --width-layout ) ); grid-template-columns: minmax( 0, var( --width-layout ) );
gap: var( --space-md ) var( --space-xl ); gap: 0 var( --space-xl );
justify-content: center; justify-content: center;
padding: 0 var( --padding-page ); padding: 0 var( --padding-page );
margin: var( --space-xl ) 0; // don't collide with other components (e.g. notice) margin: var( --space-xl ) 0; // don't collide with other components (e.g. notice)
@ -33,6 +33,7 @@
gap: var( --space-md ); gap: var( --space-md );
align-items: center; align-items: center;
padding-top: var( --space-md ); padding-top: var( --space-md );
padding-bottom: var( --space-md );
} }
.citizen-page-heading { .citizen-page-heading {