StarCitizenTools/mediawiki-skins-Citizen
1
0
Fork 0
mirror of https://github.com/StarCitizenTools/mediawiki-skins-Citizen.git synced 2024-11-13 17:49:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): 🐛 inconsistent search focus behavior

Browse source
This commit is contained in:
alistair3149 2023-07-16 03:50:43 -04:00
parent 6af0900185
commit 1aba52b870
No known key found for this signature in database
GPG key ID: 16076C01E5C88864
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
resources/skins.citizen.scripts/search.js
View file

@ -169,11 +169,11 @@ function renderSearchClearButton( input ) {
input.focus(); input.focus();
} ); } );
input.addEventListener( 'input', ( event ) => { input.addEventListener( 'input', () => {
if ( event.target.value === '' ) { if ( input.value === '' ) {
clearButton.remove(); clearButton.remove();
} else { } else {
event.target.after( clearButton ); input.after( clearButton );
} }
} ); } );
} }
@ -204,13 +204,13 @@ function initSearch( window ) {
if ( isPrimarySearch ) { if ( isPrimarySearch ) {
const checkbox = document.getElementById( 'citizen-search__checkbox' ); const checkbox = document.getElementById( 'citizen-search__checkbox' );
bindExpandOnSlash( window, checkbox, input ); bindExpandOnSlash( window, checkbox, input );
renderSearchClearButton( input );
// Focus when toggled // Focus when toggled
checkbox.addEventListener( 'input', () => { checkbox.addEventListener( 'input', () => {
focusOnChecked( checkbox, input ); focusOnChecked( checkbox, input );
} ); } );
} }
renderSearchClearButton( input );
setLoadingIndicatorListeners( searchBox, true, renderSearchLoadingIndicator ); setLoadingIndicatorListeners( searchBox, true, renderSearchLoadingIndicator );
loadSearchModule( input, searchModule, () => { loadSearchModule( input, searchModule, () => {
setLoadingIndicatorListeners( searchBox, false, renderSearchLoadingIndicator ); setLoadingIndicatorListeners( searchBox, false, renderSearchLoadingIndicator );