From d2f9882b202b213b99bdfc396d96652ec39bd52d Mon Sep 17 00:00:00 2001 From: alistair3149 Date: Mon, 8 Mar 2021 10:25:22 -0500 Subject: [PATCH 1/7] feat: make whole VE toolbar avaliable in mobile --- .../VisualEditor/ext.visualEditor.less | 39 ++++++++++++------- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/skinStyles/extensions/VisualEditor/ext.visualEditor.less b/skinStyles/extensions/VisualEditor/ext.visualEditor.less index a9daf5c0..c0e31841 100644 --- a/skinStyles/extensions/VisualEditor/ext.visualEditor.less +++ b/skinStyles/extensions/VisualEditor/ext.visualEditor.less @@ -30,7 +30,30 @@ .ve-ui { &-toolbar { > .oo-ui-toolbar-bar { + display: flex; + border-color: var( --border-color-base--darker ); background-color: var( --background-color-dp-00 ); + + .oo-ui-toolbar-bar { + border: 0; + background-color: transparent; + } + + > .oo-ui-toolbar-actions { + order: 9999; // Set to the right + border-left: 1px solid var( --border-color-base ); + } + + > .oo-ui-toolbar-tools { + flex-grow: 1; + overflow-x: auto; + overflow-y: hidden; + } + + .oo-ui-toolbar-tools { + display: inline-block; + white-space: nowrap; + } } &-floating { @@ -157,22 +180,8 @@ .ve-ui-toolbar-group { // Hide some dropdown tools in smaller screen - // format - Paragraph - // link - Link - // strcture - List bullet - // insert - Insert - // specialCharacter - Special character // help - Help - // notices - Notices - // pageMenu - Menu - &-format, - &-link, - &-structure, - &-insert, - &-specialCharacter, - &-help, - &-notices, - &-pageMenu { + &-help { display: none; } } From 009333884add5d9dd327cb7f001e688f566aca95 Mon Sep 17 00:00:00 2001 From: alistair3149 Date: Mon, 8 Mar 2021 10:31:46 -0500 Subject: [PATCH 2/7] fix: VE tool popup menu height --- skinStyles/extensions/VisualEditor/ext.visualEditor.less | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/skinStyles/extensions/VisualEditor/ext.visualEditor.less b/skinStyles/extensions/VisualEditor/ext.visualEditor.less index c0e31841..68b1a873 100644 --- a/skinStyles/extensions/VisualEditor/ext.visualEditor.less +++ b/skinStyles/extensions/VisualEditor/ext.visualEditor.less @@ -54,6 +54,12 @@ display: inline-block; white-space: nowrap; } + + /* Fix inline height */ + .oo-ui-popupToolGroup-tools.oo-ui-popupToolGroup-active-tools { + height: auto !important; + overflow: auto !important; + } } &-floating { From daeb073c748614995878d3d3af630096e3e00311 Mon Sep 17 00:00:00 2001 From: github-actions Date: Mon, 8 Mar 2021 15:32:37 +0000 Subject: [PATCH 3/7] ci: lint code to MediaWiki standards Check commit and GitHub actions for more details --- skinStyles/extensions/VisualEditor/ext.visualEditor.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/skinStyles/extensions/VisualEditor/ext.visualEditor.less b/skinStyles/extensions/VisualEditor/ext.visualEditor.less index 68b1a873..d085f32d 100644 --- a/skinStyles/extensions/VisualEditor/ext.visualEditor.less +++ b/skinStyles/extensions/VisualEditor/ext.visualEditor.less @@ -57,8 +57,8 @@ /* Fix inline height */ .oo-ui-popupToolGroup-tools.oo-ui-popupToolGroup-active-tools { - height: auto !important; overflow: auto !important; + height: auto !important; } } From 12fc1527d96c22d457c900b11ff7707e7ebe498e Mon Sep 17 00:00:00 2001 From: alistair3149 Date: Mon, 8 Mar 2021 10:50:18 -0500 Subject: [PATCH 4/7] feat: prevent thumbnail overflow when width is larger than window size --- resources/skins.citizen.styles/layout.less | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/resources/skins.citizen.styles/layout.less b/resources/skins.citizen.styles/layout.less index a85c2390..881d9744 100644 --- a/resources/skins.citizen.styles/layout.less +++ b/resources/skins.citizen.styles/layout.less @@ -36,9 +36,13 @@ } } -a.image > img { +a.image { max-width: 100%; - height: auto; + + > img { + max-width: 100%; + height: auto; + } } @media ( min-width: @width-breakpoint-tablet ) { From b8fbb6eb108e63ae06532a788dbbf0a9cd108f4f Mon Sep 17 00:00:00 2001 From: github-actions Date: Mon, 8 Mar 2021 15:51:13 +0000 Subject: [PATCH 5/7] ci: lint code to MediaWiki standards Check commit and GitHub actions for more details --- resources/skins.citizen.styles/layout.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/skins.citizen.styles/layout.less b/resources/skins.citizen.styles/layout.less index 881d9744..754e33d2 100644 --- a/resources/skins.citizen.styles/layout.less +++ b/resources/skins.citizen.styles/layout.less @@ -39,7 +39,7 @@ a.image { max-width: 100%; - > img { + > img { max-width: 100%; height: auto; } From 16b08fb2eac04b700d3b78b6f3c4402c0c8753e1 Mon Sep 17 00:00:00 2001 From: alistair3149 Date: Mon, 8 Mar 2021 10:52:46 -0500 Subject: [PATCH 6/7] fix: img inherit a.image max width --- resources/skins.citizen.styles/layout.less | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/skins.citizen.styles/layout.less b/resources/skins.citizen.styles/layout.less index 754e33d2..7a248a93 100644 --- a/resources/skins.citizen.styles/layout.less +++ b/resources/skins.citizen.styles/layout.less @@ -39,8 +39,8 @@ a.image { max-width: 100%; - > img { - max-width: 100%; + > img { + max-width: inherit; height: auto; } } From a6b5bb35461bde7ca996477e5f9d52031feb377a Mon Sep 17 00:00:00 2001 From: github-actions Date: Mon, 8 Mar 2021 15:53:46 +0000 Subject: [PATCH 7/7] ci: lint code to MediaWiki standards Check commit and GitHub actions for more details --- resources/skins.citizen.styles/layout.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/skins.citizen.styles/layout.less b/resources/skins.citizen.styles/layout.less index 7a248a93..e4309475 100644 --- a/resources/skins.citizen.styles/layout.less +++ b/resources/skins.citizen.styles/layout.less @@ -39,7 +39,7 @@ a.image { max-width: 100%; - > img { + > img { max-width: inherit; height: auto; }