StarCitizenTools/mediawiki-skins-Citizen
1
0
Fork 0
mirror of https://github.com/StarCitizenTools/mediawiki-skins-Citizen.git synced 2024-11-24 06:24:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf(sections): ⚡️ re-order conditions to short circuit earlier

Browse source 
We should not call MediaWikiServices first every time for formatting sections.
Instead it should be done last as other checks are cheaper.
This commit is contained in:
alistair3149 2024-10-23 15:14:18 -04:00
parent 18ad833bce
commit 01419e7619
No known key found for this signature in database
1 changed files with 14 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
includes/Partials/BodyContent.php
View file

@ -60,23 +60,27 @@ final class BodyContent extends Partial {
* @return bool
*/
private function shouldFormatPage( $title ) {
$shouldFormat = (
$this->getConfigValue( 'CitizenEnableCollapsibleSections' ) === true &&
$title->canExist() &&
!$title->isMainPage() &&
$title->isContentPage() &&
$title->getContentModel() === CONTENT_MODEL_WIKITEXT
);
if ( !$shouldFormat ) {
return false;
}
// Check if page is in mobile view and let MF do the formatting
try {
$mfCxt = MediaWikiServices::getInstance()->getService( 'MobileFrontend.Context' );
// Check if page is in mobile view and let MF do the formatting
return !$mfCxt->shouldDisplayMobileView();
} catch ( NoSuchServiceException $ex ) {
// MobileFrontend not installed. Don't do anything
}
$enableSections = (
$this->getConfigValue( 'CitizenEnableCollapsibleSections' ) === true &&
$title->canExist() &&
$title->getContentModel() == CONTENT_MODEL_WIKITEXT &&
!$title->isMainPage() &&
$title->isContentPage()
);
return $enableSections;
return true;
}
/**