Commit graph

33 commits

Author SHA1 Message Date
alistair3149 f87c43e8e4 fix: drop unused variable 2024-11-16 03:19:11 -05:00
alistair3149 56619bf56f feat: simplify implementation and drop hash usage
Instead of doing JS hashing, just append the tabber count to the end of the ID.
Having the same tab label within the same Tabber breaks in the previous behavior anyways
2024-11-16 03:19:11 -05:00
alistair3149 910f5c72f4 perf: drop incorrect usage of rAF and do not set aria-hidden on tabpanels 2024-11-16 03:19:11 -05:00
alistair3149 1e1d3de9cd feat: render all HTML server-side 2024-11-16 03:19:11 -05:00
alistair3149 f24ddb58ee feat: only add empty paragraph for wikitext list elements
We don't need the empty paragraph hack for non-list elements.
Related: #151
2024-11-16 03:19:11 -05:00
alistair3149 1b60511ae7
feat: add TabberNeueUseLegacyTabIds config option (#184)
Also fix the issue where disabling TabberNeueEnableAnimation didn't actually work

---------

Co-authored-by: Jayden Bailey <jaydenkieran@gmail.com>
2024-11-10 03:16:11 -05:00
Eamon Heffernan 795c76b4bd
fix: ensure that the active tab is set before the tabber event is initialized (#173)
Closes: #167, #172
2024-08-31 19:57:41 -04:00
Jayden 2f7e652e28
fix: incorrect conditions for shouldShowAnimation (#165) 2024-07-17 13:04:52 -04:00
alistair3149 1e5ad6592b
fix: prevent browser from scrolling to the tab before Tabber updates the aria attributes
Fixes: #161
2024-07-03 17:49:19 -04:00
alistair3149 421c42b6f0
feat: change tab when URL hash matches one of the tabs
Added an event listener to watch for hash change after the page is loaded.
If the hash matches a tabber tab, it will emit a tab click to switch the tab.

Closes: #150
2024-07-03 13:26:16 -04:00
alistair3149 d453adde07
fix: URL hash should be escaped when used as selector 2024-07-03 13:09:11 -04:00
alistair3149 ee54cc1bb3
perf: set active tab by hash on builder phase
Instead of setting first tab as the initial active tab the set the active tab from the URL,
just set it from the beginning. This can save a lot of code and makes it more maintainable.
2024-06-23 16:28:29 -04:00
alistair3149 05e95d880d
perf: only attach resize observer for active tabpanel when it is in viewport 2024-06-23 15:38:27 -04:00
alistair3149 72adfbc74e
fix: attach resize observer properly to current active tabpanel
This should finally fix #137
2024-06-23 15:31:44 -04:00
alistair3149 8a88a43d58
fix: make sure that init functions are run sequentially
Also fix the bug where the page does not scroll to the active tab on load by href.
It was introduced with the commit related to #133.

Closes: #148
2024-06-20 14:44:20 -04:00
alistair3149 35ffe555c0
perf: merge activeTabpanel resize observer into the main resizeObserver 2024-06-07 14:53:48 -04:00
alistair3149 a414d2df70
perf: only use one resizeObserver for header overflow 2024-06-07 14:20:41 -04:00
alistair3149 0177715f2b
fix: use resizeObserver on active tabpanel instead 2024-06-06 16:54:31 -04:00
alistair3149 8b39e9e970
fix: refresh Tabber height when it comes into viewport
Fixes: #137
2024-06-06 15:07:55 -04:00
alistair3149 0904298948
feat: add screen reader text to navigation button 2024-06-02 14:02:34 -04:00
alistair3149 7e921a4a3a
fix: set tabindex -1 on hidden tabs 2024-06-02 14:00:36 -04:00
alistair3149 ac27855dec
feat: add home and end key shortcuts on tablist 2024-06-02 13:53:44 -04:00
alistair3149 def11349b1
fix: do not unobserve tabber 2024-05-26 22:29:20 -04:00
alistair3149 2819ba83a9
perf: detach event listeners when not needed 2024-05-26 21:54:17 -04:00
alistair3149 032aef7989
fix: do not use passive scroll event listener for tab header
The buttons and indicator are all depending on it
2024-05-25 23:00:06 -04:00
alistair3149 476af1352b
refactor: separate classes into other files 2024-05-25 16:38:57 -04:00
alistair3149 bbde0ae7bd
feat: add keyboard navigation to tabs 2024-05-25 16:20:59 -04:00
alistair3149 78a987d7c1
refactor: drop spread syntax for iterating nodeList 2024-05-25 15:40:10 -04:00
alistair3149 b4b66b8172
feat: improve handling of animation 2024-05-25 15:27:47 -04:00
alistair3149 8d410dfb49
refactor: use init module instead of inline style for skeleton screen 2024-05-25 03:02:18 -04:00
alistair3149 6ad24645e9
feat: use button elements instead of div for header navigations 2024-05-25 02:42:22 -04:00
alistair3149 6d09429849
fix: attach tabber--live class after tabber has finished init 2024-05-25 00:42:40 -04:00
alistair3149 bb110c6d98
feat: rewrite Javascript implementation
To ensure easier development and maintenance, IE support is dropped to allow
modern Javascript features. The old tabber module is rewritten into newer
standard and using classes to ensure proper scoping.
2024-05-25 00:33:22 -04:00