perf: only call one instance of MediaWikiServices

This commit is contained in:
alistair3149 2024-11-16 02:13:53 -05:00 committed by alistair3149
parent a98f2f7791
commit 724e347ca1

View file

@ -169,8 +169,9 @@ class TabberTransclude {
$frame
);
} else {
$service = MediaWikiServices::getInstance();
// Add a link placeholder, as a fallback if JavaScript doesn't execute
$linkRenderer = MediaWikiServices::getInstance()->getLinkRenderer();
$linkRenderer = $service->getLinkRenderer();
$tabBody = sprintf(
'<div class="tabber__transclusion">%s</div>',
$linkRenderer->makeLink( $title, null, [ 'rel' => 'nofollow' ] )
@ -182,13 +183,13 @@ class TabberTransclude {
urlencode( $pageName )
);
$utils = MediaWikiServices::getInstance()->getUrlUtils();
$utils = $service->getUrlUtils();
$utils->expand( wfScript( 'api' ) . $query, PROTO_CANONICAL );
$dataProps['load-url'] = $utils->expand( wfScript( 'api' ) . $query, PROTO_CANONICAL );
$oldTabBody = $tabBody;
// Allow extensions to update the lazy loaded tab
MediaWikiServices::getInstance()->getHookContainer()->run(
$service->getHookContainer()->run(
'TabberNeueRenderLazyLoadedTab',
[ &$tabBody, &$dataProps, $parser, $frame ]
);