StarCitizenTools/mediawiki-extensions-TabberNeue
1
0
Fork 0
mirror of https://github.com/StarCitizenTools/mediawiki-extensions-TabberNeue.git synced 2024-11-24 00:13:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: various issues found in code review

Browse source
This commit is contained in:
alistair3149 2024-11-16 03:08:26 -05:00 committed by alistair3149
parent 9e8ac878cc
commit 1f75afc217
3 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/Tabber.php
View file

@ -63,7 +63,7 @@ class Tabber {
$html = self::render( $input, $count, $parser, $frame ); $html = self::render( $input, $count, $parser, $frame );
$parserOutput->appendExtensionData( 'tabber-count', $count++ ); $parserOutput->appendExtensionData( 'tabber-count', ++$count );
if ( self::$useCodex === true ) { if ( self::$useCodex === true ) {
$parser->getOutput()->addModules( [ 'ext.tabberNeue.codex' ] ); $parser->getOutput()->addModules( [ 'ext.tabberNeue.codex' ] );

5
modules/ext.tabberNeue/ext.tabberNeue.js
View file

@ -424,8 +424,9 @@ class TabberBuilder {
if ( !urlHash ) { if ( !urlHash ) {
return activeTab; return activeTab;
} }
const idFromUrlHash = urlHash.replace( 'tabber-tabpanel-', 'tabber-tab-' ); const escapedHash = mw.util.escapeIdForAttribute( urlHash );
if ( idFromUrlHash === urlHash ) { const idFromUrlHash = escapedHash.replace( 'tabber-tabpanel-', 'tabber-tab-' );
if ( idFromUrlHash === escapedHash ) {
return activeTab; return activeTab;
} }
const activeTabFromUrlHash = document.getElementById( idFromUrlHash ); const activeTabFromUrlHash = document.getElementById( idFromUrlHash );

3
modules/ve-tabberNeue/ve.ce.MWTabberTranscludeNode.js
View file

@ -33,9 +33,6 @@ ve.ce.MWTabberTranscludeNode.static.primaryCommandName = 'mwTabberTransclude';
ve.ce.MWTabberTranscludeNode.static.lastHeader = null; ve.ce.MWTabberTranscludeNode.static.lastHeader = null;
/* Methods */ /* Methods */
// eslint-disable-next-line no-var
var lastHeader;
/** /**
* @inheritdoc * @inheritdoc
*/ */